From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 46D7B212F89 for ; Wed, 27 May 2026 13:02:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779886977; cv=none; b=ZJE54Qqlio8fPi+dsIxLpQmCoEMNimbNQC0ggDCOifogDSoSk+aVxJ5qtwKo5LUbxHffj4cU0RoDFOoDASIGeIP/S52NkLigDzbHKqNNlXJSeaL2vO2uzO6ytB1+gL44vdXGIHtLAtG9sUsGpTsa4IQpSPziPEiHrj7sf1m9eT8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779886977; c=relaxed/simple; bh=olwuAvE45gX2gonXfFGwwcXXzEiunQSujFG8I1jxrhY=; h=Mime-Version:Content-Type:Date:Message-Id:Subject:Cc:From:To: References:In-Reply-To; b=LRRHVnCEXc6l9hvtxZX2qw3O6ymiPxwMRVK+Wyd+PgaGD6FNQEHYTBCalKAS/7076GTZJqdF//Xc+W6PyyM2XTu5GKLWAqpXIqLFXkNRMUuHGwp3P5/Ywr265WYoJrpT8piOAZ0c3ubtqUCAAVev7Psf3Yx/0PPySqTCZRu9IO0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=g+kiaaWm; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="g+kiaaWm" Received: by smtp.kernel.org (Postfix) with UTF8SMTPSA id 87B1E1F000E9; Wed, 27 May 2026 13:02:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1779886976; bh=E1jxI8tTzqktadCjLzF4moaT/MinNtSN0WSsv3YjWYM=; h=Date:Subject:Cc:From:To:References:In-Reply-To; b=g+kiaaWmzv2RpsBGpjk74ewa6TXWlv08NNZGM/4WUzUd7fZDPk6sX3XXrIjbKmpEn BbbBRylfmDZRzKEi6WieiDTdFwHny79gPKwEBrM54CVW2Znzr3cIa9Aejdre7UVAom 8AwL6iPfpcw9mobSNdG7L3a0B4PbKQ8x/wU3B0ahDVR6nDsTIWbsDfPhIOJLaCljpX /CRF9OiRIz0PH8AU70gLxt/cZ9KhmKkNkv28uj5JcI+eBCezF0o6Ut4RKkPa6IOwU5 BWjUotZMiyhSwGA02iiMKP90YvvarLxjfZKQ4SB01Oz/39DxGkIXTLDrS21NBQ0i/z AshtkIuh9QL4g== Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: multipart/signed; boundary=ea913eb2bebc50e230e6c2e938d90e8ccba46ba56ec65308be6fef02085f; micalg=pgp-sha384; protocol="application/pgp-signature" Date: Wed, 27 May 2026 15:02:51 +0200 Message-Id: Subject: Re: [PATCH v2 2/2] mtd: spi-nor: spansion: add die erase support in s28hx-t Cc: , , "Takahiro Kuwano" From: "Michael Walle" To: , "Tudor Ambarus" , "Pratyush Yadav" , "Miquel Raynal" , "Richard Weinberger" , "Vignesh Raghavendra" X-Mailer: aerc 0.20.0 References: <36045be168c5e9525f9c649986b0f1a54dcb2be1.1779872008.git.takahiro.kuwano@infineon.com> In-Reply-To: <36045be168c5e9525f9c649986b0f1a54dcb2be1.1779872008.git.takahiro.kuwano@infineon.com> --ea913eb2bebc50e230e6c2e938d90e8ccba46ba56ec65308be6fef02085f Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 On Wed May 27, 2026 at 11:05 AM CEST, tkuw584924 wrote: > From: Takahiro Kuwano > > S28Hx-T family has multi-die devices that support die erase opcode. > Update die erase opcode when the device is multi-die. > > Reviewed-by: Tudor Ambarus > Reviewed-by: Pratyush Yadav > Reviewed-by: Miquel Raynal > Signed-off-by: Takahiro Kuwano > --- > drivers/mtd/spi-nor/spansion.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/mtd/spi-nor/spansion.c b/drivers/mtd/spi-nor/spansio= n.c > index b6023076903a..65227d989de1 100644 > --- a/drivers/mtd/spi-nor/spansion.c > +++ b/drivers/mtd/spi-nor/spansion.c > @@ -762,6 +762,9 @@ static int s28hx_t_late_init(struct spi_nor *nor) > params->ready =3D cypress_nor_sr_ready_and_clear; > cypress_nor_ecc_init(nor); > =20 > + if (params->n_dice > 1) > + params->die_erase_opcode =3D SPINOR_OP_CYPRESS_DIE_ERASE; > + So this seems to be a common theme for the spansion/cypress flashes. Does it make sense to have a .mfr_flag USE_DIE_ERASE or SUPPORTS_DIE_ERASE that can be set in the flash entry instead of having many different fixups? -michael --ea913eb2bebc50e230e6c2e938d90e8ccba46ba56ec65308be6fef02085f Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iKgEABMJADAWIQTIVZIcOo5wfU/AngkSJzzuPgIf+AUCahbrexIcbXdhbGxlQGtl cm5lbC5vcmcACgkQEic87j4CH/iqTwGAhk4gnkzIxcLLW2JLayDRAlIaV4HjYIdy MESLSGwJy3HWG2PKalgZkIZ63srs/b57AX9Kgj+mR5p09gOtZMssDfMi+4MnloXu Di42q4X/kvC8yy2gnG3ejVPvgjN99WaykrI= =6XWl -----END PGP SIGNATURE----- --ea913eb2bebc50e230e6c2e938d90e8ccba46ba56ec65308be6fef02085f--