From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DB0492F8EB8 for ; Sun, 31 May 2026 19:26:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780255615; cv=none; b=faTGP2t77xc2LE0vmzDVMf+6zixR4ldJW64lefZToosEX8s36z3atNTzw07NyZEU0fOoeNcJssKSVyk7Zbg3iOAhqh+BAVjVDTh4SXAOjIUxWllOS7Kbkcyut3DnQqlbOZqWklRyd+fmYqedoIm9uIyL15zIfOfLzKYLdUFE+Mw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780255615; c=relaxed/simple; bh=BVgKf01OgskgygeFY43Z0W3nhM0vUepIGbcC73EKjk0=; h=Mime-Version:Content-Type:Date:Message-Id:Subject:Cc:To:From: References:In-Reply-To; b=hPIhwVTOEX2zANxhJWoDmIM/3uuRaVdk5YIfQ6vQANkfjjSDHtCRJWs85JYgSleaytBRx7eRoZ+9C0+WtQ/rj7lpwMOYUvG96SxoJg/vGptuWpUHUIoWG0KqMT+gzKX9JbvJE3qYa1G+20/aW88185iTnIX18XxhyHJXnl3goGQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=pq5W56my; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pq5W56my" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-490aaa51683so237045e9.1 for ; Sun, 31 May 2026 12:26:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780255612; x=1780860412; darn=vger.kernel.org; h=in-reply-to:references:from:to:cc:subject:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=acBxYatXtrUI34saUQ8bjI1t/UrspULYpylE92l4Z84=; b=pq5W56myaRdY0FHLaSAMvxFc/SgBtatj5UKXDUrCVkbBWh8qhEhF/W5jwe8wrzwWxk F5JHD8SCRrbhoLKQhGs5NIq9WBQXC1I21SRtcGwBAGtW0HFQrJMdaTmD3jItm1sV3icJ yskK1vDM6G00Ll2mwConqQw5nAzDII3AyULuTnjkWXVnBWq+/enG8zuKr7D6B/rsIteD kgKW70lDMdFUNoIDA0x605jDUg5shryHonGaey4qZpeUPoIviKerBAHKI04wzxGlrhni zUTI2RnO77urS7WDsrdMU984OzBpnLPGD5DwVfqPc9agMP2t2jLlSbhziomwhuadp8h3 URug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780255612; x=1780860412; h=in-reply-to:references:from:to:cc:subject:message-id:date :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=acBxYatXtrUI34saUQ8bjI1t/UrspULYpylE92l4Z84=; b=p2d2+fEYt/iXdKfYcNgRgLDNQKIxm0lRowWWJr3VLcFXAe6YLk28TYQQEG1VWOoSr0 a+/g3/3xdAw5+hvTyok4rY36pwK15YmdM1dwK63FbBDM2HvlEgDgdohhwBuTdf6cC57T zNwf8HNDfvbW1Uc19IUFR4Ijzpt95KkDadrK3llyvEipGsJyfvsLmptf+UgPfhAT6Bz4 Gab3MdL739y5iuJOSvedkry7EzHFbv9QSHRGU2AKiZP042y9HTey9NDx7icoQ3oaswe1 PLt1DdteV9NG2sIkq/kwkvFszyMmO/VdDWvZYtTY6FnD0U5yOWSo1VkC4vj4DH2zxK+6 VrLw== X-Forwarded-Encrypted: i=1; AFNElJ8GqxrLlvdEJjakCPXDSc7vd3P3f73YsK+s33Gl6RMkoT5WnlAfNX2Mr788+z5tjyWsyoxduoqBwvT2W8g=@vger.kernel.org X-Gm-Message-State: AOJu0YyOEBheyTDr0R96U7e7waMtA2nKyWgs0tzVk94AUEFwu0cgjkUw dQ45kc7RxWyClN2FiJmLnK8MV9VmstPJEieWzLSTvkq6uP7MvZULcQ2I X-Gm-Gg: Acq92OEe25CzV1+dl5kApasEwnT/Qpfl27127rLLUeO0LGG4mH67WKF3+1hDyqrEvP+ Jkd7UJ9Y/y1AXu0Z4qOtIG0SCJFl5YOyr4HZ4PGb5Atlf5DAIjDxKSlaWUDfm3VMG3VuqH7TEAv GxsPjIeHXdx9AZz7btCtOdqpotykvtMJ/lLDab1BPzQTpYXIF4MZC+Gc2/p0UBZCR/OEKlk/viD HwYaEXJM4IS2QP4SgIDj1iaXLhdEMVTH10gSDke9JUPouwK8gyuwc3VDfh2wCTLj5auk+9SfGTC fMNhtoNi4/LwmhR2d3HkuRjiv8LuNUvz3zPIqRRbgYBmacHd+zlCut6iKE0KL0r1u7HNPrldLWf M5rUnJEfPVYCIS6J6dunrLvjCXAv36S7CCAADpBkRsi6idw5gNbQuo1sgs1Zlm2aOxq7xXV9riD nnQfMBV1V0vMMt0EkgvuqUg5H51u7j4amQiL/O5H947ozJphQ= X-Received: by 2002:a05:600d:848a:b0:490:9d1b:f06b with SMTP id 5b1f17b1804b1-490a2943afamr100906285e9.26.1780255612025; Sun, 31 May 2026 12:26:52 -0700 (PDT) Received: from localhost ([2001:4bb8:152:df59:bc17:a305:8902:fb31]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4909c0af2d6sm69505675e9.14.2026.05.31.12.26.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 31 May 2026 12:26:51 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Sun, 31 May 2026 21:26:49 +0200 Message-Id: Subject: Re: [PATCH v4 2/2] iio: light: veml3328: add support for new device Cc: , , To: "Joshua Crofts" , "Javier Carrasco" , "Jonathan Cameron" , "David Lechner" , =?utf-8?q?Nuno_S=C3=A1?= , "Andy Shevchenko" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Rishi Gupta" From: "Javier Carrasco" X-Mailer: aerc 0.21.0-143-g2f3a2e260c09 References: <20260531-veml3328-v4-0-f9b65d71d917@gmail.com> <20260531-veml3328-v4-2-f9b65d71d917@gmail.com> In-Reply-To: <20260531-veml3328-v4-2-f9b65d71d917@gmail.com> Hi Joshua, Just a nitpick I caught on the fly because it was missing in a driver I recently sent as well. On Sun May 31, 2026 at 6:56 PM CEST, Joshua Crofts wrote: > Add support for the Vishay VEML3328 RGB/IR light sensor communicating > via I2C (SMBus compatible). > > Also add a new entry for said driver into Kconfig and Makefile. > > Assisted-by: Gemini:3.1-Pro > Signed-off-by: Joshua Crofts > --- > MAINTAINERS | 5 + > drivers/iio/light/Kconfig | 11 ++ > drivers/iio/light/Makefile | 1 + > drivers/iio/light/veml3328.c | 422 +++++++++++++++++++++++++++++++++++++= ++++++ > 4 files changed, 439 insertions(+) > > +++ b/drivers/iio/light/veml3328.c > @@ -0,0 +1,422 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Vishay VEML3328 RGBCIR light sensor driver > + * > + * Copyright (c) 2026 Joshua Crofts > + * > + * Datasheet: https://www.vishay.com/docs/84968/veml3328.pdf > + */ > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include At least linux/mod_devicetable.h is missing to include of_device_id. Probably that's the only missing header, and it could be added without sending a new version, but that is not for me to decide :) > +#include > +#include > +#include > +#include > +#include > +#include > + > +#include > + Best regards, Javier