From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.3ffe.de (0001.3ffe.de [159.69.201.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 43EFE2E36F8 for ; Tue, 2 Jun 2026 11:08:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.69.201.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780398515; cv=none; b=aKlYwg4BVvEqvt1Zi1jR5ZN9LbM9lOOpf88XjGQrpHyvDl/qaV4I1YqgELlNsxLnyCQKFr25djf6y7jLP8Y9u/GDmNT1sbMMD1hE11hjJm0tqtM7Yof++F1v3xmjtu5CrXrXVxTKP63X3PmBso3WutR0lZe5k1DUbvv9N5HaXDY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780398515; c=relaxed/simple; bh=kUo6KOaUghG1vvRIzF2FHKuCZ5Ka/UMNOsuGKDNcvpk=; h=Mime-Version:Content-Type:Date:Message-Id:Subject:Cc:From:To: References:In-Reply-To; b=u5zOMaIUQc67+i8Osrg1BFakyu4syd6uK5hzIaKS3Gtr/kckgVxSwJpFAAPmvveevxFq4V4hPuCXDw6iZJLbW8Jzx5InqXF3z1xV1gx38YaObr88hDW9/nh8on4SeXIZQ0wjFN/mAXG2owmzkM6uVjONjV4djqhHvUP+HD5jNxY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=kernel.org; spf=pass smtp.mailfrom=walle.cc; arc=none smtp.client-ip=159.69.201.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=kernel.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=walle.cc Received: from localhost (unknown [IPv6:2a02:810b:4320:1000:4685:ff:fe12:5967]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.3ffe.de (Postfix) with ESMTPSA id 4B3D8AA; Tue, 2 Jun 2026 13:01:44 +0200 (CEST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 02 Jun 2026 13:01:43 +0200 Message-Id: Subject: Re: [RFC PATCH 1/3] mtd: spi-nor: spansion: s25fl256s0: remove SKIP_SFDP flag Cc: "Pratyush Yadav" , "Takahiro Kuwano" , "Richard Weinberger" , "Vignesh Raghavendra" , "Tudor Ambarus" , , From: "Michael Walle" To: "Miquel Raynal" X-Mailer: aerc 0.20.0 References: <20260601125438.3481722-1-mwalle@kernel.org> <20260601125438.3481722-2-mwalle@kernel.org> <875x41nu2c.fsf@bootlin.com> In-Reply-To: <875x41nu2c.fsf@bootlin.com> On Tue Jun 2, 2026 at 11:57 AM CEST, Miquel Raynal wrote: > Hi Michael, > >> diff --git a/drivers/mtd/spi-nor/spansion.c b/drivers/mtd/spi-nor/spansi= on.c >> index 65227d989de1..092450375d4e 100644 >> --- a/drivers/mtd/spi-nor/spansion.c >> +++ b/drivers/mtd/spi-nor/spansion.c >> @@ -868,7 +868,7 @@ static const struct flash_info spansion_nor_parts[] = =3D { >> .name =3D "s25fl256s0", >> .size =3D SZ_32M, >> .sector_size =3D SZ_256K, >> - .no_sfdp_flags =3D SPI_NOR_SKIP_SFDP | SPI_NOR_DUAL_READ | SPI_NOR_QU= AD_READ, >> + .no_sfdp_flags =3D SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ, >> .mfr_flags =3D USE_CLSR, >> }, { >> .id =3D SNOR_ID(0x01, 0x02, 0x19, 0x4d, 0x00, 0x81), > > Fine by me. I believe the expected behaviour should just be an empty > feedback, leading to the SFDP to be invalid and thus SFDP parsing > skipped, right? Right. Probably it will read all ones or all zeros and the parsing will fail and skipped. -michael