From: "Mathieu Dubois-Briand" <mathieu.dubois-briand@bootlin.com>
To: "Srinivas Kandagatla" <srini@kernel.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
Cc: "Miquel Raynal" <miquel.raynal@bootlin.com>,
"Grégory Clement" <gregory.clement@bootlin.com>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH v2 1/2] nvmem: layouts: Add fixed-layout driver
Date: Mon, 08 Jun 2026 15:17:49 +0200 [thread overview]
Message-ID: <DJ3P3UDLPP2D.X4DC9XWSHPR7@bootlin.com> (raw)
In-Reply-To: <a13529db-a85a-4cee-9269-17c0f8fc9781@kernel.org>
On Tue May 19, 2026 at 4:59 PM CEST, Srinivas Kandagatla wrote:
>
>> -static int nvmem_add_cells_from_dt(struct nvmem_device *nvmem, struct device_node *np)
>> +int nvmem_add_cells_from_dt(struct nvmem_device *nvmem, struct device_node *np)
>
> Export this in this patch itself.
>
Sure, I will export this here.
>> +
>> +static int fixed_layout_add_cells(struct nvmem_layout *layout)
>> +{
>> + struct device_node *np;
>> +
>> + np = of_nvmem_layout_get_container(layout->nvmem);
>> + if (!np)
>> + return -ENOENT;
>> +
>> + return nvmem_add_cells_from_dt(layout->nvmem, np);
>
> np is leaking here.
>
Right, thanks for catching this.
I'm going to send a v3 soon.
Thanks for your review.
Mathieu
--
Mathieu Dubois-Briand, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2026-06-08 13:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-15 11:56 [PATCH v2 0/2] nvmem: layouts: Add fixed-layout driver Mathieu Dubois-Briand
2026-05-15 11:56 ` [PATCH v2 1/2] " Mathieu Dubois-Briand
2026-05-18 7:40 ` Miquel Raynal
2026-05-19 14:59 ` Srinivas Kandagatla
2026-06-08 13:17 ` Mathieu Dubois-Briand [this message]
2026-05-19 15:02 ` Srinivas Kandagatla
2026-05-15 11:56 ` [PATCH v2 2/2] nvmem: layouts: Make the fixed-layout driver optional Mathieu Dubois-Briand
2026-05-18 7:41 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DJ3P3UDLPP2D.X4DC9XWSHPR7@bootlin.com \
--to=mathieu.dubois-briand@bootlin.com \
--cc=gregkh@linuxfoundation.org \
--cc=gregory.clement@bootlin.com \
--cc=linux-kernel@vger.kernel.org \
--cc=miquel.raynal@bootlin.com \
--cc=srini@kernel.org \
--cc=stable@vger.kernel.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox