From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ua1-f44.google.com (mail-ua1-f44.google.com [209.85.222.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A92B8304BB3 for ; Mon, 15 Jun 2026 04:40:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781498435; cv=none; b=Gx6YcHfI0ZdfQqDd6TlrDbkIjzGxZBAj9T79y64zXuNxXP6hdsZcYWyCadqN4Av6cGdB6T3HlguWmSpok5qifSdy3YNJQmj5p+QvDC7vKnZCdRifbR1cppwuGi33x5EQFz9zy+y+uiZ4NcKvp7n8pyL7xlNKoVp8gU9FvMjWfk8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781498435; c=relaxed/simple; bh=7duavQ222Pjg3G2ZNfIGpmYS3Gzto3uKYx0OaVsfd2U=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=U1dPrs176yFc1/z4+DXmnbjamHiw0QEaHrwX+xABsksAGy3bP6E/+CNcFZpItDHuY2HMSxxl36RGzM3Y8krq76G/MPUo22ToNiJsZch7ncdVr9rUj+U/A6eiFNv4N2BACOxBSUb806+a0MP+eIxrQSwbGdfUt3bhqBrByhWU/Xw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LSq7aa6D; arc=none smtp.client-ip=209.85.222.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LSq7aa6D" Received: by mail-ua1-f44.google.com with SMTP id a1e0cc1a2514c-96358d0a024so1968721241.3 for ; Sun, 14 Jun 2026 21:40:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781498433; x=1782103233; darn=vger.kernel.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=dGB285QQfzjMEZKVcQE1jA6+Ydb7tIVKdW6CKVeUVnE=; b=LSq7aa6Dh2KBSg+dICMeTnDHu0bQLvd3xq9k1Qymi6uAThcYmwaRZ0f+QdYUcA8SzJ qoFdXyEB3k+unvb549Z+OaP+6B1xf/Xdhjl5kggib3Wrt+tmbic5RdHX42Uad/ZXmA3D 4IrGO+wSRNziabpHgLdmoj2qZ5HJRFEXtlc39zp0tgHK0cNDS2G0fKEeH7sjthumrxpr WNvA/GiT3RMUgI5/35X1R1/SjSFca9yN1uTG0wOiijJq1TOSeyjAKz6+PQbBx97tXKS3 qZZXizJ6ejUAC+f8OSTRLpBcwzKK7u0dmOQbkerNfcZ5A6EZJ+e54W/I5bAT4HGU0vsk 3ifQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781498433; x=1782103233; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=dGB285QQfzjMEZKVcQE1jA6+Ydb7tIVKdW6CKVeUVnE=; b=C1LL0hzo+PvJ3LCfgmG86b4yVByZHbZs99zB9OCV2oJVHgTC22iVm+920YUnhMzjWr r9rmem77pbfXUjEJLzF1N1GH3uEravUyBf5qADuskhLvsq4Z0bepxSIu0QUYJCSMNDex 5hFwD/gSF1f76TE7Q+KgbIAp6yLGYe6P4eLhXsgeT/wVVMEZTVaaRls+E8OrXlRRQagE V+QsCizK2ouAh2VqZudjAG6mmWNnxyUDWRHz5mJyOu3qURxkJrtoUMQAI6Ypsh91dfjr gxbqNPODHnEp4jQwW6RD+e5ebNbVL9lUr/0AHZJI8WcbTKigy+4U1eCkgzfoIoCvOg4f gbBA== X-Forwarded-Encrypted: i=1; AFNElJ+LiECQB8789BiV6Y84/ctDee6gs8ziiv9LRilsy2TZ3mti165hm3k4B/uKi84FWWftFMsNyZpGzxmjAUQ=@vger.kernel.org X-Gm-Message-State: AOJu0YxPK1gp6EsZUr9p0kFCKxnETsO0lrBP6UbaT/MtcpEhZ3xa1uwn UEcjLPgViLQ/GxIy2+GDiXVS4uO714eRlb2r8XpQh5VsFz/v1jCf6Q7E X-Gm-Gg: Acq92OHi2JMjBUzydXT9ZfUGQq+8WW4p9fp5ixAchRKnLLOjSmgo2wcpU7XsWrScVag pnqGCv/jhqpepADkDa0CW4XCYkymob5hE+ygsj7vKPsD50QFGnppic1+sDFQJEz6WYiAh6EOp5a lGHBzk9EQ585OV9XXl4/pwUNhujQh+BAL5OEU6M6j5MzmgNACi2vmvN4HRVlTEAlxYYPaRO/Y/T cdg7gPk3klv2ei03Wv8VRhhAE3dO4b5JNrzYPhg4VSblZ2c91/IJv/my+PUJpIgWgPhlZldCU3v 1cJQ26cDjwOJArcfWaE1cVni5gzGCpzQUGb42CZwVTW/dgNHXcusOVJvKSXD5//MX5ZmH2Cr5fe kMgcEfa8BmLaaEx0hNfsC57c33nqJQ9k1BPCmMmLpFNwm9JpGmskHFb/tabEW8sb4msO64rY9/e xN+3v/1dIvoMlcrg== X-Received: by 2002:a05:6102:4243:b0:633:d7ec:153c with SMTP id ada2fe7eead31-71f5e0f9832mr4264466137.3.1781498432649; Sun, 14 Jun 2026 21:40:32 -0700 (PDT) Received: from localhost ([2800:bf0:82:11a2:7ac4:1f2:947b:2b6]) by smtp.gmail.com with ESMTPSA id ada2fe7eead31-7208788587esm1915399137.10.2026.06.14.21.40.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 14 Jun 2026 21:40:32 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Sun, 14 Jun 2026 23:40:25 -0500 Message-Id: Cc: "Jonathan Cameron" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Linus Walleij" , "Bartosz Golaszewski" , "David Lechner" , =?utf-8?q?Nuno_S=C3=A1?= , "Andy Shevchenko" , , , , Subject: Re: [PATCH 1/5] dt-bindings: iio: adc: Add TI ADS126x ADC family From: "Kurt Borja" To: "Krzysztof Kozlowski" , "Kurt Borja" X-Mailer: aerc 0.21.0-0-g5549850facc2 References: <20260612-ads126x-v1-0-894c788d03ed@gmail.com> <20260612-ads126x-v1-1-894c788d03ed@gmail.com> <20260613-loyal-azure-goldfish-cf6d54@quoll> <73d85fad-d39a-4c34-90c2-819998656f7a@kernel.org> In-Reply-To: <73d85fad-d39a-4c34-90c2-819998656f7a@kernel.org> On Sun Jun 14, 2026 at 11:34 PM -05, Krzysztof Kozlowski wrote: > On 14/06/2026 22:53, Kurt Borja wrote: >> Hi Krzysztof, >>=20 >> On Sat Jun 13, 2026 at 1:54 PM -05, Krzysztof Kozlowski wrote: >>> On Fri, Jun 12, 2026 at 05:46:19PM -0500, Kurt Borja wrote: >>>> + ti,neg-refmux: >>>> + $ref: /schemas/types.yaml#/definitions/uint32 >>>> + description: | >>>> + Selects the negative voltage reference input: >>>> + 0: Internal 2.5 V reference >>>> + 1: AIN1 pin >>>> + 2: AIN3 pin >>>> + 3: AIN5 pin >>>> + 4: AVSS pin >>>> + minimum: 0 >>>> + maximum: 4 >>>> + default: 0 >>>> + >>>> + ti,vbias: >>>> + $ref: /schemas/types.yaml#/definitions/flag >>>> + description: Enables the level-shift voltage on the AINCOM pin. >>>> + default: false >>> >>> There is no such syntax, drop. >>=20 >> The "default: false" syntax? Sure I'll drop. >>=20 >>> >>>> + >>>> + ti,idac1-pin: >>>> + $ref: /schemas/types.yaml#/definitions/uint32 >>>> + description: | >>>> + Selects the analog input pin to connect IDAC1: >>>> + 0: AIN0 >>>> + 1: AIN1 >>>> + 2: AIN2 >>>> + 3: AIN3 >>>> + 4: AIN4 >>>> + 5: AIN5 >>>> + 6: AIN6 >>>> + 7: AIN7 >>>> + 8: AIN8 >>>> + 9: AIN9 >>>> + 10: AINCOM >>>> + 11: No Connection >>>> + minimum: 0 >>>> + maximum: 11 >>>> + default: 11 >>>> + >>>> + ti,idac1-microamp: >>>> + description: Selects the current values of IDAC1. >>>> + enum: [0, 50, 100, 250, 500, 750, 1000, 1500, 2000, 2500, 3000] >>>> + default: 0 >>>> + >>>> + ti,idac2-pin: >>>> + $ref: /schemas/types.yaml#/definitions/uint32 >>>> + description: | >>>> + Selects the analog input pin to connect IDAC2: >>>> + 0: AIN0 >>>> + 1: AIN1 >>>> + 2: AIN2 >>>> + 3: AIN3 >>>> + 4: AIN4 >>>> + 5: AIN5 >>>> + 6: AIN6 >>>> + 7: AIN7 >>>> + 8: AIN8 >>>> + 9: AIN9 >>>> + 10: AINCOM >>>> + 11: No Connection >>>> + minimum: 0 >>>> + maximum: 11 >>>> + default: 11 >>>> + >>>> + ti,idac2-microamp: >>>> + description: Selects the current values of IDAC2. >>>> + enum: [0, 50, 100, 250, 500, 750, 1000, 1500, 2000, 2500, 3000] >>>> + default: 0 >>>> + >>>> + clocks: >>>> + maxItems: 1 >>>> + >>>> + '#io-channel-cells': >>>> + const: 1 >>>> + >>>> + '#gpio-cells': >>>> + const: 2 >>>> + >>>> + gpio-controller: true >>>> + >>>> + adc: >>>> + $ref: /schemas/iio/adc/ti,ads1263-adc2.yaml# >>> >>> Not a separate device node. Fold into the parent... or explain in >>> commit msg. You have entire commit msg to explain odd things. >>> >>> In that binding description you call it "independent", so it should hav= e >>> its own SPI chip select? Why "independent" and part of this binding? >>> Maybe not independent, so basically part of this device? >>=20 >> It's independent in the sense that it is a proper subdevice on the same > > You cannot use DT syntax as argument why you use DT syntax like that. I'm not saying subdevice in the DT sense, I'm saying subdevice in the actual secondary ADC inside the chip sense. > > >> chip. It shares the serial interface but operates completely in >> parallel. > > How completely in parallel? If the interface is the same, then it does > not operate in parallel. It's impossible. It does conversions in parallel, communication is of course still serial. > >>=20 >> I decided to add a subnode because other devices might request their >> io-channels and most importantly a different voltage reference might be >> connected to it. >>=20 >> I'll clarify this in the commmit message on the next version. Although >> after seeing this submitted bindings [1], I wonder if it's a better >> approach to do something like >>=20 >> spi@0 { >> mydevice@0 { >> ... >> adc@0 { ... }; >> adc@1 { ... }; >> }; >> }; >>=20 >> Any thoughts? > > Does not look like separate subnode. You still did not provide arguments > why this is independent. Well, there's not more arguments than this [1]. Anyway, I'll go for David's #io-channels-cells =3D <2> approach and drop the subnode. > > Best regards, > Krzysztof [1] https://lore.kernel.org/linux-iio/DJ93WSYC3HTT.3NXQW390CLQ82@gmail.com/ --=20 Thanks, ~ Kurt