From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ua1-f50.google.com (mail-ua1-f50.google.com [209.85.222.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 62B382F745E for ; Mon, 15 Jun 2026 04:43:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781498584; cv=none; b=TnFy1WKfQ6JsoDk+IY/WRIV4dJpGO8P/VkMoWgBhxlC54nHYYu/9LT4a7BOXvXAt+IvRzBI6B6z76prWNHQnQzp2nT2kVv9PNT3/6jRP+aEzbxrVnllAWZKgjk/XWJmPHThZdyHhZJ5eqfrSVDmSMY7vHV36+F6cNU/MpDjaXtY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781498584; c=relaxed/simple; bh=FdzmA9cNqe8kCysYCqcBOJeAapnnHealTPUZxbjYDTU=; h=Mime-Version:Content-Type:Date:Message-Id:From:To:Cc:Subject: References:In-Reply-To; b=nVxE0HwrnTbZLe+jN0J1QuC1MTQdwQ/idqPVCBJ9J6E7NPnNKjXBhS6jxTCOnLs6dHdCfZk5fdf3HK7+R+/Lxc9IYf+spKq0OZMs8owN6pPZpmPWP5FHjUl7gVdHYWitq7FBdbbzwHpi4bn/Nq4wARhS9HlALAWDVL3Yf2EF8XQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=AyLEMwkG; arc=none smtp.client-ip=209.85.222.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AyLEMwkG" Received: by mail-ua1-f50.google.com with SMTP id a1e0cc1a2514c-96358d0a024so1969754241.3 for ; Sun, 14 Jun 2026 21:43:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781498582; x=1782103382; darn=vger.kernel.org; h=in-reply-to:references:subject:cc:to:from:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=n/0zATgZkedxxJFW8wtHE/FC+bydOMretvCllv2EasY=; b=AyLEMwkGNYVTjVg7PGXKEDWRALnxpwuukJRK0nT1NR0c8NHtaCRy3RGNmrUAicTn+Q oPVEwbHXpGxfbXbSELUIpWEkCd7V3WejIWP10A3pAyva+osPq3AHLEA4OgTtrbs0dwdH ay28MVzNH+qMr8aEpV94zsHUlWd65vowhEEB2Lot6i/C0KxBNldW3juBuVdQw/dzBr7T J1NGIF3UK+wPLZMQ5ORXRrO7YMUL5bcT1xVMIajXOx1rqnVKrflNddfs8iM5i6QWvnhO bQ7wWXQqK5lXULbKGgmpvRQmoq+Yf4dWH9SiUywmpIW7OiVR0F8mno3w2jHVrK7dPjXn 28mA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781498582; x=1782103382; h=in-reply-to:references:subject:cc:to:from:message-id:date :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=n/0zATgZkedxxJFW8wtHE/FC+bydOMretvCllv2EasY=; b=XLJHSVvlPN3JIK6fmJMhYcG7QkpE7NGk/BPoVFGC9/Rw1aN/jcVYmtozFlCvQnZhx4 b3Bl0SVOyIg8mWx6cAXKPIYx92SlBFT3q7CVMk6AnUbevfZLmRG1FELHAnnCKy8jOqTR bkiGfCLPnfNMKjuKjoOz/6yEk/9UqeG6orKYQi81Vgi/UnK3LGEAEQ4f8hCpCmPBM3Sh xCn3TBOrOY9518sseMecuLO7mV3Fp9+SGRl/D3IEngFFDtuQmQBV/j6UzHeHzNIGu+S6 ClibJAQKyKQOKwczlFEuQ8sA/TiktpSR07Z2bg+ts8NK6XqJpr19Y2BNydxxItb+kHtJ mkJg== X-Forwarded-Encrypted: i=1; AFNElJ/exyMTietV2nncPPpVJFuSAcqt/Jio7YN89tbsX72N6CjM3lQSYUnntgU696DkA+eUm3LMkgWVITzAjwQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yyd6LuI5zMOA3JY/DSUcf0a+Xgz8ZurSyhz0CLRzaXOnilNXJZp QDixVdNP4fB8o5DeGXac5iacFgWznYOna63FC+uoti1hbsCHUlHlycJN X-Gm-Gg: Acq92OE1DyYmW4UPAsdY6yPN/nwh2FItGJLWOiOr3By0gqS6H5QgmGj1ml6kfzd2bDl K0gvOczmCwsxYcK0u7oVYIWIpIc0xpukkQSmM2/oMsz63vF507ZteGk9fpauDQ+BFqLuVKv2A5o tGTqbVU2ZKZ+BHO4JhR+YS8MqIRSsIGmlKgMriGew4blIhwZOa5imQQPoWY/2V1Yri2090wJ/aZ EyCsnchUSsnOCBpBsjdr9Inbbjn6Ah+gZBSO9saIue4Rtjn/5yU1a0QZROR10mAaDJAGTskKLFO xGQhAKc7qtt4gFUqJlv5syqWXhFYJHmS9kBM/B+mLaN75rFCDIWzz7T0Pq7iWwpJr8bsBRx3sME LMJIgl7ysP96qO2pUO+c1CD6BTupw59Br8VtB0GdiAmy2pjGeF9VKpRWMh6yISMf4CeruSMi0CM X4L0XDm0uW8cv1pg== X-Received: by 2002:a05:6102:80a0:b0:634:eb91:695 with SMTP id ada2fe7eead31-71f5e0fa7f2mr4814652137.5.1781498582422; Sun, 14 Jun 2026 21:43:02 -0700 (PDT) Received: from localhost ([2800:bf0:82:11a2:7ac4:1f2:947b:2b6]) by smtp.gmail.com with ESMTPSA id ada2fe7eead31-720847c15a5sm1934151137.3.2026.06.14.21.43.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 14 Jun 2026 21:43:02 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Sun, 14 Jun 2026 23:42:55 -0500 Message-Id: From: "Kurt Borja" To: "Krzysztof Kozlowski" , "Jonathan Cameron" Cc: "Kurt Borja" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Linus Walleij" , "Bartosz Golaszewski" , "David Lechner" , =?utf-8?q?Nuno_S=C3=A1?= , "Andy Shevchenko" , , , , Subject: Re: [PATCH 2/5] iio: adc: Add ti-ads1262 driver X-Mailer: aerc 0.21.0-0-g5549850facc2 References: <20260612-ads126x-v1-0-894c788d03ed@gmail.com> <20260612-ads126x-v1-2-894c788d03ed@gmail.com> <20260613-sparkling-naughty-tuna-3e9bf1@quoll> <20260614143918.35503c5a@jic23-huawei> <08a9a68a-f0f3-45eb-b018-43007a0acfdf@kernel.org> In-Reply-To: <08a9a68a-f0f3-45eb-b018-43007a0acfdf@kernel.org> On Sun Jun 14, 2026 at 11:33 PM -05, Krzysztof Kozlowski wrote: > On 14/06/2026 15:39, Jonathan Cameron wrote: >>=20 >>>> + >>>> +DEFINE_RUNTIME_DEV_PM_OPS(ads1262_runtime_pm, ads1262_runtime_suspend= , >>>> + ads1262_runtime_resume, NULL); >>>> + >>>> +static const struct of_device_id ads1262_of_match[] =3D { >>>> + { .compatible =3D "ti,ads1262" }, >>>> + { .compatible =3D "ti,ads1263" }, =20 >>> >>> So devices are fully compatible? Then it should be expressed in the >>> binding and drop one entry here. >>=20 >> They aren't. It's relying on one of them having a subnode that spins up = an > > I don't see anything in the this patch that would be using the other > compatible, so driver looks like handling it fully compatible. > > > >> auxdev for the hardware block they don't share. A fallback would be fin= e > > Patch #5 adding auxdev still does it uncoditionally, thus driver > clearly treats them as 100% compatible. > > Or I missed piece of code - please point me where is any incompatible > behavior coded. You're right, Jonathan mentioned the same thing. This was the only check when creating the auxiliary device. node =3D device_get_named_child_node(dev, "adc"); if (!node) return 0; But I should definitely check if chip is actually ads1263. I just assumed user would know better, but I'm dropping the subnode anyway so I'll check the model. > > > > Best regards, > Krzysztof --=20 Thanks, ~ Kurt