From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from CH5PR02CU005.outbound.protection.outlook.com (mail-northcentralusazon11012048.outbound.protection.outlook.com [40.107.200.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C2E7E2AE8D for ; Thu, 18 Jun 2026 19:08:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.200.48 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781809712; cv=fail; b=Gy73RUEi8BDmp4I8QkIUaUdnJYpgORHBOTZy51UC5giIL8WxOR5w/sQjJK4EUzJ+S84ZAjqAtEN6py4hgZR3jGeVD0r5h6stg1dHm8piWF5UeK40ey2dKaQpRNNYmcbbNGO+84lDe86MnB7ECLSuar24LsiI0yOwSiHblBxsrok= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781809712; c=relaxed/simple; bh=P+9EqmmCfvVrvSwgJ6ftcedYOP0woDx3vrvvOR46kOY=; h=Content-Type:Date:Message-Id:Subject:Cc:To:From:References: In-Reply-To:MIME-Version; b=mBqgu0I5oX40EojWJK7mXg6dt9WSvstl8hjRFs+UbJaWkf0r9JUjNRU1MsU3Co2ASogRGfFvj4bW+2jLUXFOcMvS09ozMUbaYEONwiFOS3DkulFkymc9vQ27ikqafPSOAw1h2ZZbBIh93AQ8AB3Ez6GP1e3xCGxY32IZuQUzG+s= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=hoX5kAiT; arc=fail smtp.client-ip=40.107.200.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="hoX5kAiT" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=NhTXxzBid7hDDg2T7e2zwccqiRFdNCutJmXVFZLpgU2icGQ4VPeFlqCYSfixFMYD796vWSecZRsb02kcdg+7Ksudea/kyCjGYJPCjeeWUL/NsNheixwxyLIyIuc4ldY8bYFlXgbYrMhTHr33UxyKqe1KubWZmXiueFi9FgILbvDO+ygzvWu7lXT8811YyTYtVEa230KuqNrkzB9aBA2z+MxMMfBxFcSWkfQzRkFzF9g5mwCH9wDwQwO6mxSazI1ERNP6e3PwP44mll2ogJDSKa73vuej1iGbMwdNt5rJQbhDh143CGXgd5KHa62Ma9KQLY8rs1vpbhVR7VpQJmxOHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Naq+rnMyF9C8xmgLJHp//VJ9JlPKaC4QfAzJScDZzCc=; b=WRPaw7OnxkJWw9LBLInxc6viqALER5aq/KSEHufJfubkryENGvIr80zJtRBiGEZ2GBVLsRY/69jPzbqvgFS9a1Nldyv8tnNvA8d6VkoO0rlevdhnjR+X2FNbdta81GOQcJFSVVMj2uW67R1hbEiAdBTD4WZSc269bMvw/4to1/qQrhCxsG34C6JR8XiYexM3++MkvqYIiru7vo0D9d2LlrZ7vGuAzgUX1TQeX+AvuA42z/CDraS5XopLArAiJNlIRGKJQrsLKGi+MeL1j4I3ZY9n4T2Io4kS4GJG7KMwwgiJpU+hNo7xrCnxszVCQ3PZtn21ZVnuw/oTdDZzlZWI7w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Naq+rnMyF9C8xmgLJHp//VJ9JlPKaC4QfAzJScDZzCc=; b=hoX5kAiTc6ttj6GNutMcLzADWiMgJEURXsjOHQa7TXwme4RQc0uJap/ZqwRb+TKqAIbG0t9kQTZ7+gNt5UpOtAZfK9j3zPS5pl/5oAhhagQgK5x+1a+9pW0Bi26looYGfHtZU+s5S1cta/xH+evEcs7EcJBbYB3N5tblOm47TWd+P+mniKczQ3ePyWXWopWYpvsXtnMxD839tgmQJcKTi0Y+m+mCuIIEuGzTA38VTWtFGVDJmXo1rrvL/rYaD1arDk99/rIckiD8LGJR+r2mCXlhjJT+dXWH9UGEn6VXXEFYd2BNCcN7X1TQwVY9KS/T8Pg+bZzhO4F8S145IxpfGQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from IA0PR12MB8374.namprd12.prod.outlook.com (2603:10b6:208:40e::7) by MN2PR12MB4192.namprd12.prod.outlook.com (2603:10b6:208:1d5::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.139.11; Thu, 18 Jun 2026 19:08:25 +0000 Received: from IA0PR12MB8374.namprd12.prod.outlook.com ([fe80::d85f:4c87:ae84:3f16]) by IA0PR12MB8374.namprd12.prod.outlook.com ([fe80::d85f:4c87:ae84:3f16%5]) with mapi id 15.21.0139.011; Thu, 18 Jun 2026 19:08:25 +0000 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Thu, 18 Jun 2026 15:08:24 -0400 Message-Id: Subject: Re: [PATCH] mm/page_alloc: don't build vm_numa_stat_key if CONFIG_NUMA=n Cc: To: "Ben Dooks" , "Andrew Morton" , "Vlastimil Babka" , "Suren Baghdasaryan" , "Michal Hocko" , "Brendan Jackman" , "Johannes Weiner" , "Zi Yan" , , From: "Zi Yan" X-Mailer: aerc 0.21.0 References: <20260618100614.1321950-1-ben.dooks@codethink.co.uk> In-Reply-To: <20260618100614.1321950-1-ben.dooks@codethink.co.uk> X-ClientProxiedBy: BLAPR05CA0004.namprd05.prod.outlook.com (2603:10b6:208:36e::8) To IA0PR12MB8374.namprd12.prod.outlook.com (2603:10b6:208:40e::7) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: IA0PR12MB8374:EE_|MN2PR12MB4192:EE_ X-MS-Office365-Filtering-Correlation-Id: 084a2423-aa8b-494b-b3e7-08decd6cf900 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|7416014|23010399003|376014|921020|18002099003|22082099003|56012099006|11063799006; X-Microsoft-Antispam-Message-Info: dpk0tqVwcA3pdaF0foi99mFs1XXFBVMs4+cSxWDm2/JhIt8fxD0bqO+nsHIEkPVF9SaRK0CLT/FLUaLtdm8miUMr3bz6BN0mT4zf3/bfOtdcPBerHBdoU6ZCX24cB0oGz8fSY0ZHKJKBxC78yMs7ZGHjw9roC/KGUiVrG8f71zT775tX6bcl5Bb6K3V9h4oYxy28QUvfsm8YBKWORaT6Wmv9bZ+MmKx+54gjz2cwn9haN6pzd3ZZkys9/ongu8nZXHWtJ1CaOFX1UDMMB50iga+MwQ/J84o0YZX1tyCux6SitLAws8T5O1ub+QcRV63MTYkW7QgXFSz2sVDpTCTIQBmtF6CF/VhoLism6k8BWpW0W03gr5Vg9QHaT+aHSMB1bZK88riPj9moIl0z1mPR3dqJnHzb4NhXw1j3ezIJHG+n0K65lUHV2rrDdOkc0b18pF2RQNg2zY2/G/bLbcDnX6fY81FVFx58PshJ9V5E6bHLBF7Baxp2XglOS08SRJFvDDczuZaOoU6VA/f8V3G/mEBoRETz5SMwd2VYtp6szW4C4fgRzLcoYekRxU1j6oI3YZ9FFvFWhScMkdjz4JrOrsVUfMiOe5UnHtOWh0+sdFP6L17OvkNL4eW2XwApqzXraAVI+7tjgxXXbF18cy4rmisgsxoSMbrj/hdQzqsIPklMSCaLKAlZD6Horty3bhZgYjVUl9/PEyc/DTXeSZqvogt/7ccArccOUGxmLF2DBNA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:IA0PR12MB8374.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(7416014)(23010399003)(376014)(921020)(18002099003)(22082099003)(56012099006)(11063799006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MWNGZ2FRN3lQL3I2ZHhiTXFFNVJVL0kxQW4xdWFoWDJYSFUzbXlXWUhJeWpl?= =?utf-8?B?aFNrR2cvejRDREZyam1PbHd5cC83L3lxczduK2VyUGZXUW9qbHhFY1lJRWtG?= =?utf-8?B?ZDE2Z2hmcUhMTEFXbzFhU3ByajhLRzdhSHNtRnhMWVV6RlVFaHJGTzhvVGU4?= =?utf-8?B?MmYySWhZY1JEZjVieXV5ZkdMVEx3ZDBPeG03UVlQWVl3OTN1OTYwVUlDMHhp?= =?utf-8?B?RDhLTHNraW13V2pEc1lmeU4zV2w1NlJ2S2oyVkdkaHcxTjlUemNFdnVJMGhY?= =?utf-8?B?bXVPcjBOMGwwbVc4YisxV3BEd1Z6d0xrM2QydWx6UUdqSDlFekxabXg0U1Bp?= =?utf-8?B?eGNRVmxQbUtqOVRMY01OdmFDZSs4K1VQeDZoZXJSbWltTXEydmhmakkxUmVl?= =?utf-8?B?eFo2NERaVThPYzJpOUJhTlFFRHJrb2lBalR1RWdGMTVBb3AwYlBldk5zSmF5?= =?utf-8?B?cEtORUlMSDFzS3EzbHZhMmtZdWRKUFVEV3h3OXRTVW5XOTFVWUZmb3psNjVy?= =?utf-8?B?VWxkYW9wOWtZWTVSSEdxK3Nzb0svblB5SEdsdXdlNUFhRU9JdHNQQkQrek9O?= =?utf-8?B?Wk43NTd4OWVESHZlU3duUkpXWC9FRzUwWlBwcjdXQUhJUDhBS0p0WlVFdnZW?= =?utf-8?B?T0UrN0FuRkFEa2JxQUJITzlOQkpTNklla2F4a2plVWhIUVlsRXYwOHVtS2Zo?= =?utf-8?B?ZGl1QzM3RVNoN1BlSXcwUHZUeXhMaWZoWHJuU2tLVVFpSzI2TzAwSm1FL09v?= =?utf-8?B?aEtrQU9RbTRudTZ2VzFSalUyS0E2OWhhS0lPOTJFSVdodlFaN0lyZTE0dm1r?= =?utf-8?B?OTlKMUZnR2tEdUhuRGU5RW1BdGlBd1dUeGFSU3NGYWpZTVovQ3FPdVJ6T1l3?= =?utf-8?B?dldXSnFycDhQSUtzbWpCQlJBNk1LWWZlR0JyRkVwaEhBaFpBWjhwajhWTU40?= =?utf-8?B?Ui81VzZwOEV0YWtWTFR4cXhXWDQ0cFBkeFJ3dk9ZTXJxdkVKcU1VcmxrTTJ3?= =?utf-8?B?d05xMkRsQ2xDTUlsWEc3M3hIdEtNK3AwaDhSMlBnK3UvWGVrVmJvblJpdFJK?= =?utf-8?B?VWhOMVA2NjhFUjl0dGhmUkdGZ281dW9DL1Z0bGFGY0g5TmRQK21qYVJScUdz?= =?utf-8?B?VHh0SmNWR2cvRUpFSTVoSUpTZ2ErS2EzQkpnMm80TDQ0aDRkWFJOa3FTdVNN?= =?utf-8?B?VkpSNVl6U2FzUUY2bmFkMXJZbUN6TVB2Y0hRRzB6QVBMY3FINDNNbVhVOXp0?= =?utf-8?B?clJtWnI0ZUpQRkc0MjNvWUhQRnB6b2ZXL3hFWmdMUTZwZll1VXNhQmJaU1pW?= =?utf-8?B?MW5MNUJ6Q1VWZWEzK2Yzd1RvU1BIb2Q2TThnNWxyV1FMNmFqYUllVzQwMk9p?= =?utf-8?B?YzZsVnVjUUd5UXAvbE94WTU0L3V6VTJzbTB4Tk9VTWtNL3ZCOUFmcmszNVdk?= =?utf-8?B?SDBQMEd6YWo3eUhDY04vOFZJNTBMdklkNVUyQ3Q3SENEMk9paUk0ODg2Z3R2?= =?utf-8?B?TmNRQXI4TnFzenFoTWx0SWlEN2pyNDdHUlloVk9PbTJyWmszRVo4M3cxNFFq?= =?utf-8?B?MENvbHBUTHBmK1VUSWVYZ3NvMmpMMlVtWWdwQTV6L0dSWVZadjRRMG5oUHVl?= =?utf-8?B?T29pbUUzZ0Y0c1YvK0V5UGJabWg2Mnc4ZjRoWTIwNTgrY2xYK3cxdnBCeExn?= =?utf-8?B?SU9JQUNZZzQ4WlVNanZJZHhGa3J4QjRVTXpTbS83MitEODNDU2tQSzMvazBT?= =?utf-8?B?U0QyNlQvZjBYeVVyNzczVy8ydFJVRm8vVTl2VDd1OEJqa2JiTGxOd1dhWUJj?= =?utf-8?B?djRtOVJWK0tEQmRUN3lwcHhJdndwQ1N5NTVSYityMGkrQ2J3cEh4YjNyRUli?= =?utf-8?B?dDhoU0pVNEw5ZVRSN3dvVUJWVVhrN3V4cUJZUFA2Tk1TWTlCOEFQcXBTbUps?= =?utf-8?B?bXN0TTlDQ094eVM4Yk5YRHlkNkZOWEJVb0pHSlYyTU9ValU3RnZVTVBQTjNY?= =?utf-8?B?M3ZuQk5OVktFVWxBbU81NXZhYVBSTzFleXAwcVNQYWlpdzVTdHhyOGo5ZWR0?= =?utf-8?B?V29kZ2wvMHc2T25SMlZBTUhrdC9nUUR4RU9uZ1p1c2tPVm03QlViMzl6VHZP?= =?utf-8?B?Rkl6YnIxMUhYUEtOcHRpS2pGbW11RmhUVFFTZ2tjeWlmTlVvMHlrOE05TUxx?= =?utf-8?B?Rm9MWjVOaVIwcVV3cnVFSjRRVm5oSEVqTm92RWNTL3RIY3RqQzRvZ0JHK0lI?= =?utf-8?B?S0VSbXNBT3JmVGQxZFBBZkpFVHlYT1E1OWdXV1BpVE5UOVJYQTg1S3FxZ291?= =?utf-8?Q?bTp9IDqxT/JuCw+wuH?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 084a2423-aa8b-494b-b3e7-08decd6cf900 X-MS-Exchange-CrossTenant-AuthSource: IA0PR12MB8374.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jun 2026 19:08:25.2290 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /Ssp/o26SCpKrQ8wH248ss7zSkQ5QaeHdC/10JB6OLdlJiqSqTARbxPxbSCgM0tF X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4192 On Thu Jun 18, 2026 at 6:06 AM EDT, Ben Dooks wrote: > The vm_numa_stat_key is only exported if CONFIG_NUMA is set, > so avoid the following warning by guarding it in an #ifdef > on CONFIG_NUMA: > > mm/page_alloc.c:165:1: warning: symbol 'vm_numa_stat_key' was not declare= d. Should it be static? > > Signed-off-by: Ben Dooks > --- > mm/page_alloc.c | 2 ++ > 1 file changed, 2 insertions(+) > LGTM. Thanks. Reviewed-by: Zi Yan --=20 Best Regards, Yan, Zi