From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f43.google.com (mail-dl1-f43.google.com [74.125.82.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5FF6D4A33 for ; Mon, 29 Jun 2026 16:19:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782749997; cv=none; b=Zt6d5csEqpcUZv1m4nhtH8ZQnUTcycyHd5kLhVqGr81tBYGalhZY2b7INbVO2Y5a4mLULM1KIfDdJZJKlNUx8FfxO67pa1+r3avFCGf1+1vOx95qzs8NbuXitfNjSbKoRwsWYfQI6O6l44uXWn1/mofVra/p3+G8qqTXLN3C6J4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782749997; c=relaxed/simple; bh=8kJlmWX0DcPls/y5kYXSMMtb2vwTKbR1/3EaOhL0E2M=; h=Mime-Version:Content-Type:Date:Message-Id:From:To:Cc:Subject: References:In-Reply-To; b=pQYLpottop4ChglYihpk+maADJYBihX3Nz3CgDN8UnI4hR9ZJnlqDpadXqhPGuQU9fhrfRk5RmgF4dNtxi/4N8HuJwHOaOasBUTCrpLEGfr+iLsDLBXwsS5OCmttkFB6cZHp1v15Ee/kbJfcudY129FVv431JZbu21crylPGERY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ihoz6JLG; arc=none smtp.client-ip=74.125.82.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ihoz6JLG" Received: by mail-dl1-f43.google.com with SMTP id a92af1059eb24-13986d61b4eso8371456c88.0 for ; Mon, 29 Jun 2026 09:19:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782749995; x=1783354795; darn=vger.kernel.org; h=in-reply-to:references:subject:cc:to:from:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=8kJlmWX0DcPls/y5kYXSMMtb2vwTKbR1/3EaOhL0E2M=; b=ihoz6JLGpkKqeX8UE/VhiStRyNyUrVWnJV0pJgFQwzk5vrSlYt4nyaHEnQytzNZ90z 2yKz3IA0onzbOMkHUaW5bzKBZhnMeOz7sRwkzft1K4KMmuWP5clihGrsho/IY3uUxVQX JNKNvdlq/EBsl2rj/9LVqJtJSLQ4tQLbQQp710EanWH7XGpUIelkS3kASFzV2bdVklfJ dDt8nSyBwv25jdmx1IuU/ECJUD5sFBlp9LJ9TXCivUoIzPctOFtn1F4pTPq1sRfOmwu9 /6M5fuycYvaEfcHqt9cQYeHy3JVYahZQ/8r+Q7DRuyn8aO7/WUt6xaLnmZjYEOS9BogV PxtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782749995; x=1783354795; h=in-reply-to:references:subject:cc:to:from:message-id:date :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=8kJlmWX0DcPls/y5kYXSMMtb2vwTKbR1/3EaOhL0E2M=; b=j+FzqNmhSPYPs0SEm5eU135DeduwkxWWrgSgV2Yf03qAUDLT40Z8nFVv5piLR2GJ/w 2rwSNZuor2je4mAsrzoPiREz/kHdlpv82+ATTIMT8UgyB1FoRC2oKy2RqR4Cr+Vwuo/z UrKsRHixtissvi9jIHqu9wR5KuBlODgyfRzBtdgDGbkz6IatxaSf8ToEu6qIOl/sq1RL 893IBqpTHZMM4zCTkFMc6GrxRsZZtYNmZAlFugED4a7Q411yHsnnq8QWKOwvt6XILuCA VW1n0pdtHo01xI5i1YlyQz7FdXzv8aBI8TKbAGVZ/BzaAcAXwP7e8jV8jznx/6A8SX/5 dhfA== X-Forwarded-Encrypted: i=1; AFNElJ9uL0hFp8znn4Dsk0dYrZ4BpbGszlCUs83F5sUAKSA7WdOIXzOtsqbT47RgdOdq8HfQeA1NRJMxJ7+gRaE=@vger.kernel.org X-Gm-Message-State: AOJu0YxXfwNOruT4Gy4Boa188M765emqFx2XQvr+tVwksdfBBMDUSjm+ IDmi3JAX7hehDlgy/FAZoc6g7xzDW9Cu+2XHZlEcktxC7pTjlRpVbZURqgVAL+9TsY8= X-Gm-Gg: AfdE7cnFCIbVZIEkQ+8YbbB4cJcfwXKnvmxOskM0NuMkXFVX9+b9i/79UaCVZZy27JH bBKvZ3wWWllTjCAbaAjUlORLPLsropH1xt7N5/zvfpuDpauVAYh9Qzo7LWNur2aRx7ujAtJuEn/ C1XQ89Bq1eXieItGydMCe/DwkMBp6wt1iWQTnUEIatisBBAENuBPg2eZU0F9n/W0vd0R2ixuS4h Lqoz5rheKWs8qHWvU8yn+aS4g4E9IfejI89XIhxlULp/TAXUSA1OaYn2Vi8sPu/npSnmJI6ZrDc BHoj1YO+HDXduVLtcSuCe5IdPDliR2EGmIYy9Ai1EG/SBo8d/BfpAO05GalScjfbA4lUOZ0FeRx 09N2iEkbyjVzTJQI72PWjT9+CZXrAhlcA5ie+kerKkiJN8EV+HH8nu/iGFvJgQh2/LPq20gnd71 65mlQAJWGAx02gHvhW/FXQMuNtKRfFcIzDkPXbqjDmE/LKW3pqZBOMh+DjXOGZG3wZ7hovE1cLu Hda X-Received: by 2002:a05:7022:41a4:b0:139:819b:f5b7 with SMTP id a92af1059eb24-13b2a1ac2bfmr68831c88.29.1782749995408; Mon, 29 Jun 2026 09:19:55 -0700 (PDT) Received: from localhost ([45.64.226.42]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-13a00324b3dsm9730982c88.1.2026.06.29.09.19.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 29 Jun 2026 09:19:54 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Mon, 29 Jun 2026 21:49:49 +0530 Message-Id: From: "Prashant Rahul" To: "Dan Carpenter" , "Prashant Rahul" Cc: "Greg Kroah-Hartman" , "Shuah Khan" , , Subject: Re: [PATCH 4/4] staging: octeon: handle rx/tx initialization failures in probe X-Mailer: aerc 0.21.0 References: <20260628-staging-driver-octeon-panic-v1-0-fe8c34989254@gmail.com> <20260628-staging-driver-octeon-panic-v1-4-fe8c34989254@gmail.com> In-Reply-To: On Mon Jun 29, 2026 at 1:14 PM IST, Dan Carpenter wrote: > cvmx_pko_shutdown() has a built in call to > cvmx_pko_disable() so why are we calling that separately? Didn't realize cvmx_pko_shutdown did that. Will remove that. Also, Should I remove the cvmx_pko_disable() call in the remove function in this patch series? Or should I do that in a new patch? > Also I feel like probe() should fail if alloc_netdev() fails > or register_netdev(), but that's not introduced by this patch > either. My main goal with the patch series was to get rid of panic() calls in some of the initialization error paths. I will look into properly handling alloc_etherdev and register_netdev errors but in new patch(es). regards, Prashant Rahul