From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f174.google.com (mail-dy1-f174.google.com [74.125.82.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ED52A450903 for ; Tue, 30 Jun 2026 15:43:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782834213; cv=none; b=sqVFdIvavwkq+5TQsthjXaK1AApyc5mmqcOCZK1aECXwsPhk0Lh47iBDpTfdE7TCrjGSCDzVtREVsLs6owcmpk1D+9SRoKo2xSZ/Uc2HGSl4AlvId05/K49AS4D9qjwypaAHG9N4BLeN6wyjEg8sbbox/WMXrjIwF1jHCXpqrrc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782834213; c=relaxed/simple; bh=aqUwzODJXitno7dT5jgjJUU9tcfO6dAji0U1J60gUM0=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=lxKwhLbE3QhKZwRYjVfwif9hLH6cQRF6nsVm4M5Uq8rGpxRv/jR762Ktj6Cx3KnxNTnEdkjwXJtK2+Yjb41xyM5gh+3oTupic3dZ7yppMUmKj6sieHGEODYi03DSAXzboop1mtsHNQjGMtU+tg1Hg/Z+w4hzpz0bPmCY16XPp5k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bkHpQ7XT; arc=none smtp.client-ip=74.125.82.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bkHpQ7XT" Received: by mail-dy1-f174.google.com with SMTP id 5a478bee46e88-30bbe98c3f0so954647eec.0 for ; Tue, 30 Jun 2026 08:43:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782834211; x=1783439011; darn=vger.kernel.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=YX8g/k8yrBFhKJutLCj94XGUjlLYYTnZwSVrPSJLJUA=; b=bkHpQ7XTLK7GvmJ10AKZ1hhZw9qRzWHOPb4CP0jeHBRdWvf/7/KDFE+nEbQ61h/MUC 3/0GtYQDrynanppsgk2AOE+e/sHi91xcP7jmSnkr5QDHjWQa6FvRrtFlMl/mBP8d1o3y XuKkyk0bxqMeRZJDFlxxDpn77VIVXcFx/ACMBEYqEmS7Vp4c/01Gs+lTEmSYQz2gW8g9 2gM4OZuMcKVtXZ1qGjty65aThqSeEicGaVsBzBVEKnIcNZj6zA5+8Bl9COvgLgTi49UV XIbIK26vHZrvHCn1BrXnlqlxMHpuOSHhYHwQjtmjtcjlZVc2nrzbrQWldAwblFpaZkAD 4UwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782834211; x=1783439011; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=YX8g/k8yrBFhKJutLCj94XGUjlLYYTnZwSVrPSJLJUA=; b=a2MkaIYAYUjzB6v0Q3QLm4mWo9VkVLnTvT9fjKNw7PWby+7e0BcSUGETX3Ki8ZyZ6G pGoN0yTiCkuEs5H6fjft4K/U8js6Cyf29+6l1YNfPnoXBnuKtWRyUWcliAmFcoW+4JBT hS+AK6XZsHr5FBCEwyEKZGZSPxcFLam8TJT8vMOGJAP5h1cqFfwIvWrdIVPUJrwPfSnj j0jIMoUH6cKENfE29Lv1vwFyb90QcIEB2bDarco6LgSx/zustpr2lA4LtSMwfqnPehRq vUxPloOAhGN17d0RjyEtsARE7HOtl54fuZESOAQ6fQFf9QZ/+I/AcYYP02MKSC0vbAU6 vuvw== X-Forwarded-Encrypted: i=1; AHgh+RrTkiAIzIoQJi+6rnC5BxsCS+P8JJW6T0tVxoRs4qeNxigWsaAeUVZliNVJXa5QXPmFXJ1kqKOr49KrnQ8=@vger.kernel.org X-Gm-Message-State: AOJu0YyH3ukp7JGjjMoal9TSubnHoRZ4cLI33GtR7lAx8eyMxXPvjobt U+Gxl0bnpiwc1mUMgcRNF/0XuGzYdGIp+fy6PPmBKjCN6PCxmFVmv78= X-Gm-Gg: AfdE7clvcAsIB9uwdrtfvTIRUMsvVWb9yWR0ORdXOgxXIUVgifk/82V6eqzk1A2fDIU Bg+3mWNVmHGtmaUr0chiKNJ8tTshteo8aTK12CThmL97HEhutYcVLBOpxo3CbEdVdkYj5cV1Q4X frRZ+hJ5OGhCidzCt2w14mwcDXYbO8/gnO89kkc9mXgAThi7igKTLBWwPqqLzr0r1bghnfvbf6e Rs5W6mo9i0vvXWUh/V2o8qj+/3BjjO0zsCbd1c8ZkhAbIjfKVdVJvRh7ss+ORRknZBIlJU78+Ys TCxIjmdTbnZdJlypnFFe/tmCbFqkXzDkcVD/5XN65Lni+c/U1Y7mJdg9T5AgE8F+fp76wxeDnqB yUa4dtyCW29U6m4VaU9pnl8YeUL8sVFE5EVMApLxcDOKCfyxG9IqoatkPvMK/anhj8LhinphCxI QZR2w4ZUb1zf0kXscfoPRi0urM/8/EuUb0GCaEb+XnwtUZjnnd X-Received: by 2002:a05:7300:2325:b0:30e:d236:57b5 with SMTP id 5a478bee46e88-30ee128cd0fmr3421948eec.16.1782834211044; Tue, 30 Jun 2026 08:43:31 -0700 (PDT) Received: from localhost ([186.158.238.108]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-30ee2f5c4c3sm9520156eec.2.2026.06.30.08.43.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Jun 2026 08:43:30 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 30 Jun 2026 12:43:25 -0300 Message-Id: Cc: "Greg Kroah-Hartman" , =?utf-8?q?Arve_Hj=C3=B8nnev=C3=A5g?= , "Todd Kjos" , "Christian Brauner" , "Carlos Llamas" , "Alice Ryhl" , "Alexandre Courbot" , "Miguel Ojeda" , "Andreas Hindborg" , "Benno Lossin" , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , "Boqun Feng" , "Daniel Almeida" , "Danilo Krummrich" , "Gary Guo" , =?utf-8?q?Onur_=C3=96zkan?= , "Shuah Khan" , "Tamir Duberstein" , "Trevor Gross" , , , Subject: Re: [PATCH] rust_binder: use pin_init::zeroed for file_operations initialization From: =?utf-8?q?Nicol=C3=A1s_Antinori?= To: "Miguel Ojeda" X-Mailer: aerc 0.20.0 References: <20260626214404.852685-1-nico.antinori.7@gmail.com> In-Reply-To: On Sun Jun 28, 2026 at 7:16 AM -03, Miguel Ojeda wrote: > On Fri, Jun 26, 2026 at 11:44=E2=80=AFPM Nicol=C3=A1s Antinori > wrote: >> >> - // SAFETY: All zeroes is safe for the `file_operations` type. >> - let zeroed_ops =3D unsafe { core::mem::MaybeUninit::zeroed().assume= _init() }; >> + let zeroed_ops =3D pin_init::zeroed(); > > I would just remove the variable and put `zeroed()` directly in the > fops initializer like we do in other cases, but it is fine of course. I thought of that as well but I tried to touch as little as possible (I assumed that was in a variable for a reason). I can send a v2 if that is=20 preferred! Thank you, Nicol=C3=A1s