The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: "Gary Guo" <gary@garyguo.net>
To: "Mark Brown" <broonie@kernel.org>,
	"Tetsuo Handa" <penguin-kernel@I-love.SAKURA.ne.jp>,
	"Boqun Feng" <boqun@kernel.org>
Cc: <linux-next@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	"Miguel Ojeda" <ojeda@kernel.org>,
	"Linus Torvalds" <torvalds@linux-foundation.org>
Subject: Policy regarding linux-next only changes
Date: Thu, 02 Jul 2026 12:49:39 +0100	[thread overview]
Message-ID: <DJO29EZB2BIT.2AQMSG44P9M46@garyguo.net> (raw)

Hi Mark,

While testing lockdep changes on linux-next, I found there is a commit
ca65ccfdc5b3 ("locking/lockdep: make lockdep_print_held_locks() always print if
CONFIG_DEBUG_AID_FOR_SYZBOT=y") applied to lockdep. Checking the history it
looks like this commit has been in linux-next for quite a while (at least 2
months); there were no emails on LKML about this commit at all.

I asked Boqun and as a maintainer of the file he's not aware of such changes
being made. This commit is being added to linux-next via the TOMOYO security
module tree; checking the merge it appears that none of the changes pulled in
via the TOMOYO tree is related to LSM at all:

e07d10ed0f23 lib/Kconfig.debug: enable CONFIG_PREEMPT_RT for syzbot kernels.
8f598d86dc9c net: add "struct dst_entry" debugging
295e1a24166f net: update dev_put()/dev_hold() debugging
ca65ccfdc5b3 locking/lockdep: make lockdep_print_held_locks() always print if CONFIG_DEBUG_AID_FOR_SYZBOT=y
83d2b1cd5d27 lib/Kconfig.debug: add CONFIG_DEBUG_AID_FOR_SYZBOT option

For obvious reasons I have concern about this practice; being a maintainer
shouldn't mean that you're allowed to add random stuff to linux-next. This
reminds me of another case last month
https://lore.kernel.org/all/20260604210704.41751-1-ojeda@kernel.org/ where the
added stuff via TOMOYO tree breaks Rust build on linux-next. I think this
practice is questionable and I would like a clarification on the policy of
adding stuff that is not upstream material.

I recognize that there is a need to add commits that serve as testing and
debugging purpose to linux-next, but I think any of these changes should be
temporary in nature and have acknowledgement from maintainers of touched code.
Perhaps these changes should also be in a separate topic branch which gets
pulled from linux-next temporarily.

Best,
Gary

             reply	other threads:[~2026-07-02 11:49 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-02 11:49 Gary Guo [this message]
2026-07-02 12:49 ` Policy regarding linux-next only changes Tetsuo Handa
2026-07-02 13:37   ` Miguel Ojeda
2026-07-02 14:11   ` Boqun Feng
2026-07-04 10:14     ` Tetsuo Handa
2026-07-04 12:06       ` Miguel Ojeda
2026-07-04 13:22         ` Theodore Tso
2026-07-05 11:36           ` Tetsuo Handa
2026-07-05 12:02             ` Miguel Ojeda
2026-07-05 12:06               ` Miguel Ojeda
2026-07-05 12:20               ` Mark Brown
2026-07-05 12:06         ` Mark Brown
2026-07-05 14:16           ` Tetsuo Handa
2026-07-06 17:23             ` Mark Brown
2026-07-05  9:05       ` [PATCH] lockdep: Enable the printing of held locks of running non-current tasks (was: Policy regarding linux-next only changes) Ingo Molnar
2026-07-05 11:05         ` [PATCH] lockdep: Enable the printing of held locks of running non-current tasks Tetsuo Handa
2026-07-05 14:59       ` Policy regarding linux-next only changes Boqun Feng
2026-07-02 13:22 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DJO29EZB2BIT.2AQMSG44P9M46@garyguo.net \
    --to=gary@garyguo.net \
    --cc=boqun@kernel.org \
    --cc=broonie@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=ojeda@kernel.org \
    --cc=penguin-kernel@I-love.SAKURA.ne.jp \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox