From: "Danilo Krummrich" <dakr@kernel.org>
To: "Alice Ryhl" <aliceryhl@google.com>
Cc: "Deborah Brouwer" <deborah.brouwer@collabora.com>,
"Joerg Roedel (AMD)" <joro@8bytes.org>,
"Will Deacon" <will@kernel.org>,
"Robin Murphy" <robin.murphy@arm.com>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Boqun Feng" <boqun@kernel.org>, "Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Trevor Gross" <tmgross@umich.edu>,
iommu@lists.linux.dev, rust-for-linux@vger.kernel.org,
linux-kernel@vger.kernel.org, samitolvanen@google.com,
boris.brezillon@collabora.com, laura.nao@collabora.com,
daniel.almeida@collabora.com
Subject: Re: [PATCH] rust: iommu: add device lifetime to IoPageTable
Date: Fri, 03 Jul 2026 18:53:19 +0200 [thread overview]
Message-ID: <DJP3CGLE438Q.1EM46SY9PWLHB@kernel.org> (raw)
In-Reply-To: <akdaMa7hQbAjWbox@google.com>
On Fri Jul 3, 2026 at 8:44 AM CEST, Alice Ryhl wrote:
> I would suggest renaming this method to just `new()`.
Agreed.
> As for creating a device resoure version with DevresLt, I think that can
> be the secondary constructor and be called `new_devres()` or similar.
Other device resources use an into_devres() method consuming self. However, I
wouldn't add it until we have a valid use-case anyway.
prev parent reply other threads:[~2026-07-03 16:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-02 23:47 [PATCH] rust: iommu: add device lifetime to IoPageTable Deborah Brouwer
2026-07-03 6:44 ` Alice Ryhl
2026-07-03 16:53 ` Danilo Krummrich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DJP3CGLE438Q.1EM46SY9PWLHB@kernel.org \
--to=dakr@kernel.org \
--cc=a.hindborg@kernel.org \
--cc=aliceryhl@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun@kernel.org \
--cc=boris.brezillon@collabora.com \
--cc=daniel.almeida@collabora.com \
--cc=deborah.brouwer@collabora.com \
--cc=gary@garyguo.net \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=laura.nao@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=ojeda@kernel.org \
--cc=robin.murphy@arm.com \
--cc=rust-for-linux@vger.kernel.org \
--cc=samitolvanen@google.com \
--cc=tmgross@umich.edu \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox