From: "Danilo Krummrich" <dakr@kernel.org>
To: "Deborah Brouwer" <deborah.brouwer@collabora.com>
Cc: "Joerg Roedel (AMD)" <joro@8bytes.org>,
"Will Deacon" <will@kernel.org>,
"Robin Murphy" <robin.murphy@arm.com>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Boqun Feng" <boqun@kernel.org>, "Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
iommu@lists.linux.dev, rust-for-linux@vger.kernel.org,
linux-kernel@vger.kernel.org, laura.nao@collabora.com,
boris.brezillon@collabora.com, daniel.almeida@collabora.com,
samitolvanen@google.com
Subject: Re: [PATCH v2] rust: iommu: add device lifetime to IoPageTable
Date: Fri, 03 Jul 2026 21:37:53 +0200 [thread overview]
Message-ID: <DJP6UGQMBAXD.1UHYDZXIF88ZD@kernel.org> (raw)
In-Reply-To: <20260703-pgtable_lt_b4-v2-1-f14da6d4106d@collabora.com>
On Fri Jul 3, 2026 at 8:52 PM CEST, Deborah Brouwer wrote:
> +impl<'bound, F: IoPageTableFmt> IoPageTable<'bound, F> {
We settled on the convention to only call a lifetime 'bound when it actually
described the entire bound scope. This might be shorter lived, so maybe just 'a.
> + // TODO: Provide the option to return `IoPageTable` as a device resource
> + // when DevresLt is available.
I'd drop this comment, we only really need it once there's a justified use-case,
or do you have something in mind already?
next prev parent reply other threads:[~2026-07-03 19:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-03 18:52 [PATCH v2] rust: iommu: add device lifetime to IoPageTable Deborah Brouwer
2026-07-03 19:37 ` Danilo Krummrich [this message]
2026-07-03 23:57 ` Deborah Brouwer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DJP6UGQMBAXD.1UHYDZXIF88ZD@kernel.org \
--to=dakr@kernel.org \
--cc=a.hindborg@kernel.org \
--cc=aliceryhl@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun@kernel.org \
--cc=boris.brezillon@collabora.com \
--cc=daniel.almeida@collabora.com \
--cc=deborah.brouwer@collabora.com \
--cc=gary@garyguo.net \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=laura.nao@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=ojeda@kernel.org \
--cc=robin.murphy@arm.com \
--cc=rust-for-linux@vger.kernel.org \
--cc=samitolvanen@google.com \
--cc=tmgross@umich.edu \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox