Re: [PATCH 00/30] mtd: spi-nor: Clean Winbond W25QxxJV family

["Michael Walle" <mwalle@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 4633 bytes --]

On Fri May 29, 2026 at 5:22 PM CEST, Miquel Raynal wrote:
> Thanks to Winbond collaboration, I was able to test almost the entire JV
> SPI NOR family. A few chips could not be sourced, I decided to apply the
> very same logic than the other chips, all of them behave identically as
> shown in all the logs that I am sharing in each and every commit.
>
> This series is pretty straightforward, it is here to cleanup the JV
> entries by:
> - Removing the useless part names (which are going to become a problem)
> - Aligning the comments and "fixing" the chip names in them
> - Reordering the chips by density and family
> - Testing and showing all the SFDP content and passing all the SPI NOR
>   tests to ensure a good level of support.
> - Describing only what needs to be described, parsing the SFDP tables
>   otherwise.
> - Adding all the locking information when it is missing.
>
> This work is necessary because I am about to propose the addition of the
> W25QxxRV family, whose IDs actually collide with the JV chips. The chips
> are similar, they have been "improved" (especially the silicon/engraving
> smoothness) and we have a way to differentiate them based on their SFDP
> content, but that will be for a following series.

Why do you need to remove the no_sfdp_flags? I have only looked at
some of the patches, but overall it seems we'd be dropping support
for older chips - which we don't know if they are in use or not.

So although the comment might only point to one chip, there can be
many more with that very same id. And now.. with the RV family even
more. Ugh.

-michael

> NB: There is one collision with a Spansion chip as well (S25FL064K). On
> my side I commented out the Spansion entry to make sure the core was
> taking the Winbond entry (by alphabetical order) but it is due to an old
> joint agreement and is a legitimate ID duplication. We haven't found a
> good way to differentiate them so far, so I am keeping this aside for
> the moment and just assume we will have a solution later. In all cases,
> the colliding Winbond ID exist and is already fulfilled, so let's make
> sure the definition is accurate.
>
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> ---
> Miquel Raynal (30):
>       mtd: spi-nor: winbond: Move W25Q01NW to its right place
>       mtd: spi-nor: winbond: Normalize names
>       mtd: spi-nor: winbond: Stop filling the .name entry
>       mtd: spi-nor: winbond: Make the RDCR fixup Winbond wide
>       mtd: spi-nor: winbond: W25Q32JV-Q/N: Drop redundant data
>       mtd: spi-nor: winbond: W25Q64JV-Q/N: Drop redundant data
>       mtd: spi-nor: winbond: W25Q512JV-Q/N: Drop redundant data
>       mtd: spi-nor: winbond: W25Q32JV-Q/N: Add quad page program capability
>       mtd: spi-nor: winbond: W25Q64JV-Q/N: Add quad page program capability
>       mtd: spi-nor: winbond: W25Q128JV-Q/N: Add quad page program capability
>       mtd: spi-nor: winbond: W25Q32JV-Q/N: Fill locking information
>       mtd: spi-nor: winbond: W25Q64JV-Q/N: Fill locking information
>       mtd: spi-nor: winbond: W25Q128JV-Q/N: Fill locking information
>       mtd: spi-nor: winbond: W25Q512JV-Q/N: Fill locking information
>       mtd: spi-nor: winbond: W25Q01JV-Q/N: Fill locking information
>       mtd: spi-nor: winbond: W25Q32JV-M: Drop redundant data
>       mtd: spi-nor: winbond: W25Q64JV-M: Drop redundant data
>       mtd: spi-nor: winbond: W25Q128JV-M: Drop redundant data
>       mtd: spi-nor: winbond: W25Q32JV-M: Add quad page program capability
>       mtd: spi-nor: winbond: W25Q64JV-M: Add quad page program capability
>       mtd: spi-nor: winbond: W25Q128JV-M: Add quad page program capability
>       mtd: spi-nor: winbond: W25Q32JV-M: Fill locking information
>       mtd: spi-nor: winbond: W25Q64JV-M: Fill locking information
>       mtd: spi-nor: winbond: W25Q128JV-M: Fill locking information
>       mtd: spi-nor: winbond: W25Q02JV-M: Fill locking information
>       mtd: spi-nor: winbond: W25Q512JV-M: New chip
>       mtd: spi-nor: winbond: W25Q01JV-M: New chip
>       mtd: spi-nor: winbond: W25QxxJV-Q/N/M: Drop redundant data
>       mtd: spi-nor: winbond: W25QxxJV-Q/N/M: Add quad page program capability
>       mtd: spi-nor: winbond: W25QxxJV-Q/N/M: Fill locking information
>
>  drivers/mtd/spi-nor/winbond.c | 147 +++++++++++++++++++++---------------------
>  1 file changed, 73 insertions(+), 74 deletions(-)
> ---
> base-commit: 361a4eb81d0bb23dd27919f969e14a4a372af6e2
> change-id: 20260529-winbond-v7-1-spi-nor-jv-cleanup-817889edd1f7
>
> Best regards,


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 297 bytes --]