From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 60F82385D64 for ; Mon, 6 Jul 2026 14:34:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783348465; cv=none; b=ahuDV0CXTsM2AQXSWur2rENKs6MZ3T8sej0L9tB1/D28kISlszNS/8xX56uoYw45go7SS7c/7bR+FoaskaLuwWsWGyMZqBoR6/JlegvV+4JZEch4zc4xaoyje53aiwoCNsq3R7y4dJaSYR1JmFVul/aHNnHC348Mk5AUcy4NNac= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783348465; c=relaxed/simple; bh=a90AOddR9g9tUk96DYOh4ouN1uFTR+pQ/33Q0Ef321A=; h=Mime-Version:Content-Type:Date:Message-Id:Subject:Cc:From:To: References:In-Reply-To; b=dGiF4NpDHmlp3A6eWIC4GgZcdsSo3MCmm6KQjAC24fNE+LBB7Y1C/Dv3kW/+5Elzr9sG/hEIl9qM3uOqQ2s7e7GcHyeqUex9KzXR89omg3h2TqFu18ijWHkbP8jUhl4/3vzTTrPVtXQs3Pvb8JLLJMSFrZ7mk1HnVPvs3OIvJ5g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=XE9/Xt1K; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="XE9/Xt1K" Received: by smtp.kernel.org (Postfix) with UTF8SMTPSA id B03DA1F000E9; Mon, 6 Jul 2026 14:34:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783348464; bh=YxRrCXlWN9ARPXX/Q3oLuamYQn0AXB/KIJFWqLuNswY=; h=Date:Subject:Cc:From:To:References:In-Reply-To; b=XE9/Xt1KJmK+ku8BM/Ll6WvmBhsV/o7VxOrubaxBtpbhA+vB1Q63KHE9tSYUKpSyp wEZ1QGxUZWWFTrlMxXHd6/IB1OA20tnB8HQDKNA+XW/Ieo6ZGw3O9YnrKR+MelqTCr P2Hb8vIo00qIbd5oji4hZJKWqRxA09mWRsEdIlQmWoNqbG9NzKnWM+CSGljzxxK8+v imeMaPYEPVG+5twOlz1DxnIx8IGyNd1bOVo7HwpjlXwSqIwaL13T862C5E09Tz4C+O f3RgoqYHDrK1zf5YdhNLZRkN1Kg3oUyPa5zmH2hTnKiQBcUzLIcBH02WeW3JItSPUM bzegLGNZ4vN8w== Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: multipart/signed; boundary=e18ae1c96ffc1fa382f365316a0edf4ab68d498cab596b2ef6f08fc6ab07; micalg=pgp-sha384; protocol="application/pgp-signature" Date: Mon, 06 Jul 2026 16:34:20 +0200 Message-Id: Subject: Re: [PATCH v1 7/8] mtd: spi-nor: push the rollback mechanism into the sfdp module Cc: "Pratyush Yadav" , "Takahiro Kuwano" , "Richard Weinberger" , "Vignesh Raghavendra" , "Tudor Ambarus" , , "Cheng Ming Lin" , From: "Michael Walle" To: "Miquel Raynal" X-Mailer: aerc 0.20.0 References: <20260703143003.1809579-1-mwalle@kernel.org> <20260703143003.1809579-8-mwalle@kernel.org> <874iickxki.fsf@bootlin.com> In-Reply-To: <874iickxki.fsf@bootlin.com> --e18ae1c96ffc1fa382f365316a0edf4ab68d498cab596b2ef6f08fc6ab07 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 On Mon Jul 6, 2026 at 4:22 PM CEST, Miquel Raynal wrote: > On 03/07/2026 at 16:29:18 +02, Michael Walle wrote: > >> Right now, the core is handling the rollback of the parameters. But it >> doesn't have the knowledge what has to be rolled back. And in fact, >> havent rolled back everything. Push it down to the called function and >> make it mandatory, that this function has no side effects if it fails. >> >> Funny enough, there is a comment in the SFDP table handing code that > > handling? ^ yeah ;) >> each table parser is responsible to roll back any changes. But none of >> them did. So while add it, expand the logic to that and roll it back for >> them. There is one simple rule though: >> >> SFDP parsing and fixups may only modify the spi_nor_flash_parameters. > > Ok. > > Reviewed-by: Miquel Raynal Btw Sashiko found a problem with the new rollback logic [1]. So expect that there will be at least a v2. -michael [1] https://sashiko.dev/#/patchset/20260703143003.1809579-1-mwalle%40kernel= .org --e18ae1c96ffc1fa382f365316a0edf4ab68d498cab596b2ef6f08fc6ab07 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iKgEABMJADAWIQTIVZIcOo5wfU/AngkSJzzuPgIf+AUCaku87BIcbXdhbGxlQGtl cm5lbC5vcmcACgkQEic87j4CH/gWGwGAh0RJ2eLKgbbbse46YPQft8AK3TXMwDxk UhRdx3r2MCtpprB4l9rbWQjRbDnzlGstAYClTn+s8IIaRo/TM7xkh2KphHBJ2ep1 Wo5X6OoN0jFbY1+65rkLYYuRi1J+HYBHBzg= =MkP+ -----END PGP SIGNATURE----- --e18ae1c96ffc1fa382f365316a0edf4ab68d498cab596b2ef6f08fc6ab07--