The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: "Alexandre Courbot" <acourbot@nvidia.com>
To: "Miguel Ojeda" <miguel.ojeda.sandonis@gmail.com>
Cc: "Gary Guo" <gary@garyguo.net>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	"Danilo Krummrich" <dakr@kernel.org>,
	"Miguel Ojeda" <ojeda@kernel.org>,
	"Boqun Feng" <boqun@kernel.org>,
	"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
	"Benno Lossin" <lossin@kernel.org>,
	"Andreas Hindborg" <a.hindborg@kernel.org>,
	"Alice Ryhl" <aliceryhl@google.com>,
	"Trevor Gross" <tmgross@umich.edu>,
	"Daniel Almeida" <daniel.almeida@collabora.com>,
	"Tamir Duberstein" <tamird@kernel.org>,
	"Onur Özkan" <work@onurozkan.dev>,
	"Matthew Maurer" <mmaurer@google.com>,
	driver-core@lists.linux.dev, rust-for-linux@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rust: soc: silence clippy warning with rustc >= 1.88
Date: Wed, 08 Jul 2026 19:11:39 +0900	[thread overview]
Message-ID: <DJT3XNKGKVNE.3BN1EWKCE8SQT@nvidia.com> (raw)
In-Reply-To: <CANiq72n2KwCE1DCp2HR6CJF-vR-VNBYFgXYv3j0Kvv81dH6rng@mail.gmail.com>

On Wed Jul 8, 2026 at 6:04 PM JST, Miguel Ojeda wrote:
> On Wed, Jul 8, 2026 at 10:25 AM Alexandre Courbot <acourbot@nvidia.com> wrote:
>>
>> Done: https://github.com/rust-lang/rust-clippy/issues/17379
>>
>> As for this patch, I guess we don't need it then?
>
> Thanks a lot for taking the time to fill the issue! Linked to our usual list:
>
>   https://github.com/Rust-for-Linux/linux/issues/349
>
> But why do you mean we don't need it? It is still reproducible within
> our possible toolchains, right? Or did I misunderstand something? Or
> do you mean it is fairly rare and thus maybe not needed?

I mean that both the code and clippy setting are properly set, so
using a workaround for this particular occurrence seems like a
half-measure, as the problem can very well arise somewhere else.

>
> We can also always just disable that particular lint, and perhaps
> later on re-enable it conditionally when fixed -- we have support for
> that now.

That sounds like a better way to address this, yes.

      reply	other threads:[~2026-07-08 10:11 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-07 10:12 [PATCH] rust: soc: silence clippy warning with rustc >= 1.88 Alexandre Courbot
2026-07-07 11:11 ` Onur Özkan
2026-07-07 11:43 ` Gary Guo
2026-07-07 12:12   ` Alexandre Courbot
2026-07-07 12:12   ` Miguel Ojeda
2026-07-07 14:19     ` Alexandre Courbot
2026-07-07 14:30       ` Gary Guo
2026-07-08  8:25         ` Alexandre Courbot
2026-07-08  9:04           ` Miguel Ojeda
2026-07-08 10:11             ` Alexandre Courbot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DJT3XNKGKVNE.3BN1EWKCE8SQT@nvidia.com \
    --to=acourbot@nvidia.com \
    --cc=a.hindborg@kernel.org \
    --cc=aliceryhl@google.com \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun@kernel.org \
    --cc=dakr@kernel.org \
    --cc=daniel.almeida@collabora.com \
    --cc=driver-core@lists.linux.dev \
    --cc=gary@garyguo.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lossin@kernel.org \
    --cc=miguel.ojeda.sandonis@gmail.com \
    --cc=mmaurer@google.com \
    --cc=ojeda@kernel.org \
    --cc=rafael@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=tamird@kernel.org \
    --cc=tmgross@umich.edu \
    --cc=work@onurozkan.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox