From: "Kumar Kartikeya Dwivedi" <memxor@gmail.com>
To: "Mike Rapoport" <rppt@kernel.org>, <bot+bpf-ci@kernel.org>
Cc: <ast@kernel.org>, <andrii@kernel.org>, <luto@kernel.org>,
<bp@alien8.de>, <daniel@iogearbox.net>,
<dave.hansen@linux.intel.com>, <eddyz87@gmail.com>,
<mingo@redhat.com>, <memxor@gmail.com>, <peterz@infradead.org>,
<song@kernel.org>, <tglx@kernel.org>, <emil@etsalapatis.com>,
<jolsa@kernel.org>, <john.fastabend@gmail.com>,
<martin.lau@linux.dev>, <hpa@zytor.com>,
<yonghong.song@linux.dev>, <bpf@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <x86@kernel.org>,
<martin.lau@kernel.org>, <clm@meta.com>,
<ihor.solodrai@linux.dev>
Subject: Re: [PATCH bpf-next v3 1/5] bpf: dispatcher: allocate bpf_dispatcher->rw_image with vzalloc()
Date: Thu, 16 Jul 2026 11:49:53 +0200 [thread overview]
Message-ID: <DJZWHCHQJF16.5908MHLHMK0I@gmail.com> (raw)
In-Reply-To: <alikAx7_8tp_ryky@kernel.org>
On Thu Jul 16, 2026 at 11:27 AM CEST, Mike Rapoport wrote:
> On Thu, Jul 16, 2026 at 08:52:25AM +0000, bot+bpf-ci@kernel.org wrote:
>> > diff --git a/kernel/bpf/dispatcher.c b/kernel/bpf/dispatcher.c
>> > index ea2d60dc1fee..79f0c222c583 100644
>> > --- a/kernel/bpf/dispatcher.c
>> > +++ b/kernel/bpf/dispatcher.c
>> > @@ -148,7 +148,10 @@ void bpf_dispatcher_change_prog(struct bpf_dispatcher *d, struct bpf_prog *from,
>> > d->image = bpf_prog_pack_alloc(PAGE_SIZE, bpf_jit_fill_hole_with_zero, false);
>> > if (!d->image)
>> > goto out;
>> > - d->rw_image = bpf_jit_alloc_exec(PAGE_SIZE);
>> > + /* d->rw_image doesn't need to be in module memory range, so we
>> > + * can use vzalloc.
>> > + */
>> > + d->rw_image = vzalloc(PAGE_SIZE);
>>
>> This isn't a bug, but for multi-line comments under kernel/bpf/ the opening
>> /* is expected to sit on its own line, so would this read better as:
>>
>> /*
>> * d->rw_image doesn't need to be in module memory range, so we
>> * can use vzalloc.
>> */
>
> This really contradicts what I see in the code :/
>
We ended up changing to the multi-line convention, but you can let it be. People
are out on vacation, hence things are moving slow, but I plan to get to this
series soon. Sorry about the delay.
>> > if (!d->rw_image) {
>> > bpf_prog_pack_free(d->image, PAGE_SIZE);
>> > d->image = NULL;
>>
>>
>> ---
>> AI reviewed your patch. Please fix the bug or email reply why it's not a bug.
>> See: https://github.com/kernel-patches/vmtest/blob/master/ci/claude/README.md
>>
>> CI run summary: https://github.com/kernel-patches/bpf/actions/runs/29482648692
next prev parent reply other threads:[~2026-07-16 9:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-16 7:51 [PATCH bpf-next v3 0/5] bpf, x86: enable EXECMEM_ROX_CACHE for BPF allocations Mike Rapoport (Microsoft)
2026-07-16 7:51 ` [PATCH bpf-next v3 1/5] bpf: dispatcher: allocate bpf_dispatcher->rw_image with vzalloc() Mike Rapoport (Microsoft)
2026-07-16 8:52 ` bot+bpf-ci
2026-07-16 9:27 ` Mike Rapoport
2026-07-16 9:49 ` Kumar Kartikeya Dwivedi [this message]
2026-07-16 7:51 ` [PATCH bpf-next v3 2/5] bpf: drop __weak from bpf_jit_alloc_exec() and bpf_jit_free_exec() Mike Rapoport (Microsoft)
2026-07-16 7:51 ` [PATCH bpf-next v3 3/5] bpf: alloc_prog_pack(): skip ROX management for already ROX memory Mike Rapoport (Microsoft)
2026-07-16 7:51 ` [PATCH bpf-next v3 4/5] bpf, x86: make sure allocation in arch_bpf_trampoline_size() is writable Mike Rapoport (Microsoft)
2026-07-16 7:51 ` [PATCH bpf-next v3 5/5] x86/bpf: enable EXECMEM_ROX_CACHE for BPF allocations Mike Rapoport (Microsoft)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DJZWHCHQJF16.5908MHLHMK0I@gmail.com \
--to=memxor@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bot+bpf-ci@kernel.org \
--cc=bp@alien8.de \
--cc=bpf@vger.kernel.org \
--cc=clm@meta.com \
--cc=daniel@iogearbox.net \
--cc=dave.hansen@linux.intel.com \
--cc=eddyz87@gmail.com \
--cc=emil@etsalapatis.com \
--cc=hpa@zytor.com \
--cc=ihor.solodrai@linux.dev \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=martin.lau@kernel.org \
--cc=martin.lau@linux.dev \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rppt@kernel.org \
--cc=song@kernel.org \
--cc=tglx@kernel.org \
--cc=x86@kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox