From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from CWXP265CU009.outbound.protection.outlook.com (mail-ukwestazon11021131.outbound.protection.outlook.com [52.101.100.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9147D33A9FC for ; Tue, 21 Jul 2026 19:03:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.100.131 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784660628; cv=fail; b=gP1HhHbpiRgETMKk/PE60ckZ8vnasxa2a6gy95aNG2A2MwrlPZwe+kPV6ilaJ1ErWODRH7czQdKFjeYqGzM3DL/RKVxJ/cTvVJbRPjbQLjIB8Gs4jF6eT1y/qsZZL/IigLPuxbbh8OU4tk9RHH0Sox+7rInr55tgDRb1WDl5+jA= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784660628; c=relaxed/simple; bh=nmCs22CUrYakTrCtlKI8U5IYtMmV84hQflQGe/VDK0w=; h=Content-Type:Date:Message-Id:Cc:Subject:From:To:References: In-Reply-To:MIME-Version; b=U9AMWYKcR6bOw5ZC/U5/dIvZEQtSr9Pf56+CNhaTbX0n1htyrSfTloW7LQXz71ceZ9G4zOHF4PPDQ4YFymdd4NJ1sxsuI3ii7iTHrn4gTv/UOOv2uw1ihlOF4prxn3LKvXG7o4/ifkWhRD3Hz7Rs2uovJuS5SNpMjoUtkcBHa8c= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=garyguo.net; spf=pass smtp.mailfrom=garyguo.net; dkim=pass (1024-bit key) header.d=garyguo.net header.i=@garyguo.net header.b=O+sgyg1T; arc=fail smtp.client-ip=52.101.100.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=garyguo.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=garyguo.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=garyguo.net header.i=@garyguo.net header.b="O+sgyg1T" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=uwzl2aXY/SuY1Lcc2hu7v+IutqqNNhhKb9lVlr35ws7jQzcKLl8DO4Ss211/jS39+E5m7sWHF2TetE7BVnPkY5TmDmDN9mFki8iZ+sKdmuWt8SPg9DGS40RQjl3WkYvpW349IKpgy3WTYgjCGv9o5Alr4JbvZNlF3WVlKunducE9nTtL7b74xYPQMc+oUEPUS2TyK7sYpVA6j6nHKi+NZTKkygqyjUv3rPattlVv9jqvYkw0NNejktoMqAQi2VTXGpn/yDfNVpa7aGXF15xdJeYc+78cbxtwPWjk6dHcBSnj+2wXDVH0fw6+3+C3ZIg4O1JHv8+UvhhMMB+vyrltXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=R37rfSWOT35+z4ZnM62MFRlgFqjVOW3UhO2w/dY/28Y=; b=bhDKzz8+G0Og3zdcYqxVHr78Q0lZ6JlGy20kvTnCvaOIUkHNfaS9J6SR5KOfYwLIaCXGZiPsr++DVJM1B6gMxzYPG3PXOg0iF9OXeTKufqpTGlQX5r5BVdgrJOxaXFG0vaaoo03DkITWBOi6jn41I68KJdV8P9IdBLQeulmmXKSwg5HlgG7CqvKR/zVdGtRlxzKpv/Ap61fTUEMA9jltHe0PaNTzL4w5XvxHco25lFChBEwkGdXd0brbiDDJaGFJyH+UZaTNsob07YIFqKfxw3KqcnRwQM1xvUB/4oFuZq7r0SD9boKSRWmgDoaEJEXHbBCGp5ViMP3UlZ0ilwzexA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=garyguo.net; dmarc=pass action=none header.from=garyguo.net; dkim=pass header.d=garyguo.net; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=garyguo.net; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=R37rfSWOT35+z4ZnM62MFRlgFqjVOW3UhO2w/dY/28Y=; b=O+sgyg1T3enGdX8uZCd5MDtLL0PXbKsuaUbCl2ajIM2c+UAFXvlGPCwwj0yhUsMzDkSaCrh6PRQSA4a+GwA0lBvu1dz9neFrVpKUd3TyhvM2S1z6gIeJHsn6FIhYJqrE7LYUx1xCO//bD5M+XVuLXWn5yX0jdjaSfbQc3p5sixc= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=garyguo.net; Received: from LOVP265MB8871.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:488::16) by LO8P265MB7767.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:3ab::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.245.10; Tue, 21 Jul 2026 19:03:43 +0000 Received: from LOVP265MB8871.GBRP265.PROD.OUTLOOK.COM ([fe80::1c3:ceba:21b4:9986]) by LOVP265MB8871.GBRP265.PROD.OUTLOOK.COM ([fe80::1c3:ceba:21b4:9986%4]) with mapi id 15.21.0223.017; Tue, 21 Jul 2026 19:03:42 +0000 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 21 Jul 2026 20:03:42 +0100 Message-Id: Cc: "John" , "Daniel Drake" , "Marek Szyprowski" , "Florian Fainelli" , "Daniel Lezcano" , "Thomas Gleixner" , "Mark Rutland" Subject: Re: [PATCH] clocksource/drivers/arm_arch_timer: Workaround bcm2712 broken EL2 virtual timer From: "Gary Guo" To: "Marc Zyngier" , , X-Mailer: aerc 0.21.0 References: <20260710080958.491620-1-maz@kernel.org> In-Reply-To: <20260710080958.491620-1-maz@kernel.org> X-ClientProxiedBy: LO4P302CA0026.GBRP302.PROD.OUTLOOK.COM (2603:10a6:600:2c1::18) To LOVP265MB8871.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:488::16) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LOVP265MB8871:EE_|LO8P265MB7767:EE_ X-MS-Office365-Filtering-Correlation-Id: 28057250-e98a-4e8e-b40c-08dee75ac85d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|376014|7416014|1800799024|366016|56012099006|5023799004|10067099003|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: XksSIrXznJeI985ItYGuvroznJKPY3ChisJ518w2WEbCByREJGVrDG2O9MIFb4CVD/lD65YP/7QFeVr5w5Mv+gXh9g3qOqgZ/QOvdIX9tkaxhh7HWPj1bFUfHltZZGNeg7qDSwDRCB1k75xVES5Gm9MpuLzUtpWiW9dVt07qkzdgRV2kxKLRmey1o1sshHaZJBCWFjubR+ce5DtCm42UxzDLVCkAtTrRMKNratU1ztLgE5t/RhZlfhUomkQd6Xn/4t8E0uZ5og+lBiEvwFi5KU0J8C5AFokLOwOXotcbOCH2TdmDMoe/3pX1+JWZ6BF+sxC2I1cjmezTFI634vhEABwvkUKtJnZCNOr27TcjOqehMW1nJb3gZ3kLic7PHeb1aNplD/1J6jd9ulmyNWyq2AnPJsQhPGXJJ3/ap8LW82G4Mw7ivcih7NK9D3D9j7XU6Llfchr2I5CAANh/rSbWOy3EDv1LpRhPig0ddSUxfznE3Gw0jiVBdgBhgKYWjjnPnEh1jdwMVkU0r1J2IrNll3ByObLSLkMRG/e67iU/cNEKbKm1YDh6WEePyaYXxKYaRYWYKT5LSglH6vr8WX5jU1RhgfotPaUEpfCCEe48t5ACDaZ/13acWb+kbXrGb29fUYbGo6PVGOhqVbpXaW14GqHoH7iUcQUhSTFdT2KIL7o= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:LOVP265MB8871.GBRP265.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(23010399003)(376014)(7416014)(1800799024)(366016)(56012099006)(5023799004)(10067099003)(18002099003)(22082099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZzFqRzRqdHFDOUNVOU1YYzNZbC9teDczeGliUXVQZjhmNkFWQVhqaEdiaFBo?= =?utf-8?B?M21GTHJvclJneHhZN3FDTHNGb3lDUmQrcTBLTlZzRDI5cDFyL2d5bEJVUnFU?= =?utf-8?B?MUVrSG02aWtuYlRBY2RkWCtWRU1TY3VUZm80ZjE0T2t0eVZyYys1RlkraUQ3?= =?utf-8?B?bXVuMjlPRURtUVFBdXpjMlZ4UTRkYmlWQ1VKWSt5SXFxOWttZEZIay9KTUZy?= =?utf-8?B?RkVTYStBeVNLN09ubEt4WUNwQkNqOXI0dUZJUlA1d2RhNmdtMmdOYlM3MkRH?= =?utf-8?B?czNKNUt0TXZsOXZCZ1BrbjhWaTZwWVh5OWxOK2s3QmFmenV1NWViVGlkYmJi?= =?utf-8?B?TkdnLzFCaG1zZ1FBRkFaVkhmcm90QXBLLzNLVkphWG5qaUpxcDQ3Nm1YSGYw?= =?utf-8?B?SGJkcXBKZTU3dWI3VXkvQ21MMlljUExsMkJYdU1Jc3gvVzR1ck03YlJib0Zo?= =?utf-8?B?UDVWUmg3d1dVMzkrcnNiSEI3OGMzbU8yNVkram5sRmJrTnRtWGlGSm1rU3hk?= =?utf-8?B?TXJaN2pEMHl5Kzh0am1YUmVEZjg5STNBcnB3ZHNocFg3RkxkcEFJb1NBNVJm?= =?utf-8?B?VWRYVFZheHZQN3FzSkdsUEI5SGorZTNMUHpiL0twYjdzWnA5anFaNlkxeG56?= =?utf-8?B?RjFCbTV4bGtHSkx3d1F4VVRZbysxVVhJMGQxQmVXWnRwVVRNUjg0cjh2OEpO?= =?utf-8?B?TEd4T1lQVCtZcmJHNzFsaktGSW9peGl3N3NUVzd3bHZsTDhpVWtyY2NHWDJR?= =?utf-8?B?RUxpclRPT3J3WUM2MUFFNDBpZ1R6ZzUxY2tjREdGNXJydlN1WkxCMDMxbEhr?= =?utf-8?B?YU9wUFY2UFFHV1Q5Vkx4cHVNWDFXNUdURFBNSW5jUTRXbFMxWkd1cmlPSmdP?= =?utf-8?B?UmtyUzZKQmJsMXdkRVVRR29hd1l3djJFWnM0RjJpM0Z0QVhYc2hhR3RzV0gw?= =?utf-8?B?ZXNyamNkd29yN3gxMWU2a1R6amxZUURlVy9RMUNuOGZxSmVId0ZMVEtKTy9J?= =?utf-8?B?WmlRNDJaV1N2Q3ZLQXhhK3JhZm9qSDdhNG5UdjBTUG8yN2dCby9yN0cycThn?= =?utf-8?B?QSt5S3RqYzVFbEsybk9Zcmx5eUkwT2w4L0NJRG9qeXc4SFdnTVE2MEJlRldI?= =?utf-8?B?ZVV0SWo3YmpGSUQrRTd4cldoanpwWWZOT0ZUSjk3clpxNm1TWGZrQm94NGRa?= =?utf-8?B?aUN3WHB0eWczZVVHdUs0UFNKUUZtVjh5WnJFaWhIa0crWW9makROTndSNXZk?= =?utf-8?B?bTV6SDF3MmNSL2Z5QzJqb1BzRmZFcDNpWHNBNnlIM0lZRjhFR1AvSGhSUzRU?= =?utf-8?B?R1Jaakk5c2tyOVFBc2lsM2M2RVUzM1dFVUpQU2NaaFhtYXdyM21kS3J0UU9o?= =?utf-8?B?Q2J6Y2YwMVlXQXJYcklCNDEzOVNaMGFjZC80Z082Sm1ObDFlSzhCQm9yNENv?= =?utf-8?B?S0FpZmF4dDBGOThTVG1wNnpoc0xESEdadjBROUs0UFhlbStpc1U0ZU56cE85?= =?utf-8?B?K2dld3FJK1lOR1Bnb0M4dU8wR0RSeHV4Ky93bk0vRnlKVXorb0drZkFQcHJH?= =?utf-8?B?RzV0Ky9LSkdHMC9tenExUmQ1REpOM3NIL0FwN2JRMDR1Qm8vVHFSUThGTjZE?= =?utf-8?B?ZkNFNGZDTzlpWDZxTlF2K3duTVhGU2NKeUUxeDIvUHV2S0Z2bjkvVFhCSmdW?= =?utf-8?B?eWM0SGdnMENOOWZoZGYrckVpSXNjcVZ4b2k0alVnd3hNYkxkaFQ2NW1GdDNm?= =?utf-8?B?MmQxZTlqRkYrR3pJTnpBR2ZISFZPb2RJZVFQN0hZMVZUcGIyL0hCUlIyaXJV?= =?utf-8?B?YzZjLzB6OUZjTTRRUlRIcFZwbWZRRGRXdzliWSs2d2VkNENqWW9mRFRvUFBw?= =?utf-8?B?WHZQTkN5eC9rYWNUVVRYc1FSaWpnSGYwU3JXeGtOd2VlOVY3Rk9EdGJiamdl?= =?utf-8?B?cEhHdERGUGlzYUJITnI4em81NnMvVW9zSmpnQUY0Sm9jbHRya1dvcG1IM0JU?= =?utf-8?B?OGN5ZEJwblF1RnJSYXJqY0FoREtMeitiTHZoSmlubG1NRFl5Vm4yS3BBNGRX?= =?utf-8?B?ZDI5TktiaWRBK3pFZ3duTWtYVzVPN0t6dlE1N3FKTW1va1B3Vll2eDBhd2wv?= =?utf-8?B?aUlLSGVZUytrQkRnblJDOE4xN0Z4b2J0L3NNVXJpRnRGSXd0SWtRN3ZTYk9o?= =?utf-8?B?SHkzMVZYWUlTOXRtSmtMbGcyTUo3SjV5U1c3bnlnVUtJaUQxeEptQVJVTzVG?= =?utf-8?B?endyajEvZitRZmZRc21DWW1jbU1IMzhtWWRQZUhHTGU2QlA2OERiOTVZNGFQ?= =?utf-8?Q?nAw6zJUdwNeGPuxC5h?= X-OriginatorOrg: garyguo.net X-MS-Exchange-CrossTenant-Network-Message-Id: 28057250-e98a-4e8e-b40c-08dee75ac85d X-MS-Exchange-CrossTenant-AuthSource: LOVP265MB8871.GBRP265.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jul 2026 19:03:42.8701 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bbc898ad-b10f-4e10-8552-d9377b823d45 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5pcKRjAJ5XKlTi27h6vql634pA3tuBtaxK96xYRNIN5R0zgudHomLoEFW38BU0Hju7OhYXQnOMd1IEiBNu2zjA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: LO8P265MB7767 On Fri Jul 10, 2026 at 9:09 AM BST, Marc Zyngier wrote: > It appears that the bcm2712 SoC found in the relatively popular > RPi5 has a broken EL2 virtual timer. > > We do not know the reason why the timer isn't working (the timer > is ticking, but the interrupt never fires), and the SoC vendor > doesn't communicate on the reason why this isn't working, leaving > users and maintainers in the dark. > > Paper over the issue by detecting the broken HW, falling back to > the physical timer instead, and let the user know about it. > Also taint the kernel as the machine is definitely not compliant > with the spec, and we don't know what else is wrong with it. > > Reported-by: John > Reported-by: Daniel Drake > Reported-by: Marek Szyprowski > Signed-off-by: Marc Zyngier > Cc: Florian Fainelli > Cc: Daniel Lezcano > Cc: Thomas Gleixner > Cc: Mark Rutland Tested on my RPi 5 and this does make it boot again Tested-by: Gary Guo Best, Gary > --- > drivers/clocksource/arm_arch_timer.c | 24 +++++++++++++++++++++++- > 1 file changed, 23 insertions(+), 1 deletion(-) > > diff --git a/drivers/clocksource/arm_arch_timer.c b/drivers/clocksource/a= rm_arch_timer.c > index 4adf756423de9..7b4a98df6962b 100644 > --- a/drivers/clocksource/arm_arch_timer.c > +++ b/drivers/clocksource/arm_arch_timer.c > @@ -1090,6 +1090,27 @@ static int __init arch_timer_common_init(void) > return arch_timer_arch_init(); > } > =20 > +static bool __init has_broken_el2_vtimer(void) > +{ > + /* > + * SoCs described here have been found to be broken, though no > + * explanation has been volunteered by the vendor. Let the user know > + * we're papering over the vendor's lack of communication. > + */ > + static const char * const broken_el2_vtimer[] __initconst =3D { > + "brcm,bcm2712", > + NULL > + }; > + > + if (of_machine_compatible_match(broken_el2_vtimer)) { > + add_taint(TAINT_CPU_OUT_OF_SPEC, LOCKDEP_STILL_OK); > + pr_warn_once(HW_ERR "Known broken EL2 virtual timer, ignoring it\n"); > + return true; > + } > + > + return false; > +} > + > /** > * arch_timer_select_ppi() - Select suitable PPI for the current system. > * > @@ -1115,7 +1136,8 @@ static int __init arch_timer_common_init(void) > static enum arch_timer_ppi_nr __init arch_timer_select_ppi(void) > { > if (is_kernel_in_hyp_mode()) { > - if (arch_timer_ppi[ARCH_TIMER_HYP_VIRT_PPI]) > + if (arch_timer_ppi[ARCH_TIMER_HYP_VIRT_PPI] && > + !has_broken_el2_vtimer()) > return ARCH_TIMER_HYP_VIRT_PPI; > =20 > pr_warn_once(FW_BUG "VHE-capable CPU without EL2 virtual timer interru= pt\n");