The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: "Eliot Courtney" <ecourtney@nvidia.com>
To: "Timur Tabi" <ttabi@nvidia.com>,
	"simona@ffwll.ch" <simona@ffwll.ch>,
	"gary@garyguo.net" <gary@garyguo.net>,
	"Eliot Courtney" <ecourtney@nvidia.com>,
	"lossin@kernel.org" <lossin@kernel.org>,
	"airlied@gmail.com" <airlied@gmail.com>,
	"dakr@kernel.org" <dakr@kernel.org>,
	"aliceryhl@google.com" <aliceryhl@google.com>,
	"Alexandre Courbot" <acourbot@nvidia.com>
Cc: "dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	"Alistair Popple" <apopple@nvidia.com>,
	"nova-gpu@lists.linux.dev" <nova-gpu@lists.linux.dev>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"John Hubbard" <jhubbard@nvidia.com>,
	"rust-for-linux@vger.kernel.org" <rust-for-linux@vger.kernel.org>,
	"dri-devel" <dri-devel-bounces@lists.freedesktop.org>
Subject: Re: [PATCH v3 1/5] gpu: nova-core: correct FRTS vidmem offset calculation
Date: Tue, 28 Jul 2026 16:29:24 +0900	[thread overview]
Message-ID: <DKA10BN3PYYU.WC5VTPHPZL5J@nvidia.com> (raw)
In-Reply-To: <ae14f443778ebcee56e89a72441f3252fc020b96.camel@nvidia.com>

On Sat Jul 25, 2026 at 1:52 AM JST, Timur Tabi wrote:
> On Fri, 2026-07-24 at 15:56 +0900, Eliot Courtney wrote:
>> +++ b/drivers/gpu/nova-core/fsp/hal.rs
>> @@ -19,6 +19,10 @@ pub(super) trait FspHal {
>>  
>>      /// Returns the FSP Chain of Trust protocol version this chipset advertises.
>>      fn cot_version(&self) -> u16;
>> +
>> +    // TODO: consider moving this into the TLV firmware metadata when ready
>> +    /// Returns the size reserved at the end of the framebuffer, in bytes.
>> +    fn fb_end_reserved_size(&self) -> u32;
>
> Do you know where in OpenRM this value is encoded?
>
> There are quite a few places in the code, especially for GA100 stuff, that are arbitrary and GPU-
> specific.  Without a means to scrape that data from the OpenRM source, it will be impossible for the
> script to obtain the values.

Yerp, for before blackwell it's here [1]. For blackwell it's here [2].
According to [3] it seems to be able to vary based on openrm version and
it's required to boot GSP, so that's why I think TLV is a good spot for
it.

[1]: https://github.com/NVIDIA/open-gpu-kernel-modules/blob/452cec62d827034798072827d3866d1881662b77/src/nvidia/src/kernel/gpu/mem_mgr/arch/maxwell/mem_mgr_gm107.c#L1829
[2]: https://github.com/NVIDIA/open-gpu-kernel-modules/blob/452cec62d827034798072827d3866d1881662b77/src/nvidia/src/kernel/gpu/mem_mgr/arch/blackwell/mem_mgr_gb100.c#L64
[3]: https://github.com/NVIDIA/open-gpu-kernel-modules/blob/452cec62d827034798072827d3866d1881662b77/src/nvidia/src/kernel/gpu/fsp/arch/hopper/kern_fsp_gh100.c#L1399

  reply	other threads:[~2026-07-28  7:29 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-24  6:56 [PATCH v3 0/5] gpu: nova-core: blackwell follow-ups and fixes Eliot Courtney
2026-07-24  6:56 ` [PATCH v3 1/5] gpu: nova-core: correct FRTS vidmem offset calculation Eliot Courtney
2026-07-24 16:52   ` Timur Tabi
2026-07-28  7:29     ` Eliot Courtney [this message]
2026-07-24  6:56 ` [PATCH v3 2/5] gpu: nova-core: rename heap size field Eliot Courtney
2026-07-24  6:56 ` [PATCH v3 3/5] gpu: nova-core: return non-WPR heap size as u64 from HALs Eliot Courtney
2026-07-24  6:56 ` [PATCH v3 4/5] gpu: nova-core: split FbLayout into FSP and non-FSP versions Eliot Courtney
2026-07-28 14:00   ` Danilo Krummrich
2026-07-24  6:56 ` [PATCH v3 5/5] gpu: nova-core: pass WPR metadata ownership to FmcBootArgs Eliot Courtney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DKA10BN3PYYU.WC5VTPHPZL5J@nvidia.com \
    --to=ecourtney@nvidia.com \
    --cc=acourbot@nvidia.com \
    --cc=airlied@gmail.com \
    --cc=aliceryhl@google.com \
    --cc=apopple@nvidia.com \
    --cc=dakr@kernel.org \
    --cc=dri-devel-bounces@lists.freedesktop.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gary@garyguo.net \
    --cc=jhubbard@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lossin@kernel.org \
    --cc=nova-gpu@lists.linux.dev \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=simona@ffwll.ch \
    --cc=ttabi@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox