From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpbgeu2.qq.com (smtpbgeu2.qq.com [18.194.254.142]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F31D43DA7F3 for ; Wed, 29 Jul 2026 09:14:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=18.194.254.142 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785316465; cv=none; b=YQk7mY2+BfVnTgfbRJPgIpAJzerz3ad1pdz55TsrcQe2VcaBfSjGrD+eZggaNQICNPgiysZsfbmdw5wRr3Cyyv/166hlyrxVrNoT2dg+M2nqranknm7vaYdn4QBKrKQqRduTLzpp63Pk9C19anGR8dd0hk2hA5X181yqr8AYG2w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785316465; c=relaxed/simple; bh=7dQJOLYN/AMcn00lyTExvQ2yf6auzhnjf1GDAS+h8Qg=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=sKqGEOjVPj93+RHMTq3wJryKZ4VqcsSL0XeOuTfIveWTGxGy9N+/VOCsoINnPpmIRyVmOcO7NNlLUalVZ8j0NhpHsi2cKpgkhXCk/ajbC+tByafxFdOqjA00v8JjJb9SvCk7WnICC5XqcG/HnLig0O2meHmrBaLrCThRInb8A44= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=linux.spacemit.com; spf=none smtp.mailfrom=linux.spacemit.com; dkim=pass (1024-bit key) header.d=linux.spacemit.com header.i=@linux.spacemit.com header.b=UqH1d/0T; arc=none smtp.client-ip=18.194.254.142 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=linux.spacemit.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.spacemit.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.spacemit.com header.i=@linux.spacemit.com header.b="UqH1d/0T" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.spacemit.com; s=mxsw2412; t=1785316457; bh=7dQJOLYN/AMcn00lyTExvQ2yf6auzhnjf1GDAS+h8Qg=; h=Mime-Version:Date:Message-Id:Subject:From:To; b=UqH1d/0TgC+l78WYVDHiRncKlC9aEt3cT+oE4U3kv8R7xwcpSiGZ4yVUQKltjpPja 5rdFZWbLsCGuz4Qp11v5OuNf/7xikmiNEjuLC/Ml6N0+GCOI86iUpMqebxGFyPyk+r HfL/hhnp2JhSHXdpstO4C1L54hbcWkJfWDjKg7wE= X-QQ-mid: zesmtpgz5t1785316453t920e2043 X-QQ-Originating-IP: zAlwTsMr81y+gJMiR91lCYUcBGOKHctjS3NDk86hNXY= Received: from localhost ( [120.237.158.181]) by bizesmtp.qq.com (ESMTP) with id ; Wed, 29 Jul 2026 17:14:11 +0800 (CST) X-QQ-SSF: 0000000000000000000000000000000 X-QQ-GoodBg: 0 X-BIZMAIL-ID: 7786942154255255945 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 29 Jul 2026 17:14:11 +0800 Message-Id: Cc: "frank.binns" , "robh" , "krzk+dt" , "conor+dt" , "dlan" , "dri-devel" , "devicetree" , "linux-kernel" , "linux-riscv" , "spacemit" Subject: Re: [PATCH v3 1/2] dt-bindings: gpu: img,powervr-rogue: add spacemit,k3-gpu From: "Baihui Liang" To: "Krzysztof Kozlowski" X-Mailer: aerc 0.17.0 References: <065a229b-e6a8-4cce-8725-9c2e19c8f463@kernel.org> In-Reply-To: <065a229b-e6a8-4cce-8725-9c2e19c8f463@kernel.org> X-QQ-SENDSIZE: 520 Feedback-ID: zesmtpgz:linux.spacemit.com:qybglogicsvrgz:qybglogicsvrgz6b-0 X-QQ-XMAILINFO: ORqNQdnYjakCHXgNrmTcfxnv4EWQVlw+GuaL4A3WExIvph/YknP2M2El RlKoRwFYZC+0fSDiLO76QChlvH4txp/I6KteFIJTtb4OxFnfP5eoAjz1TYDroCNMj+r5WhB Nm53f8qgGaHpZUHpntMhLC1nwmgVPR7892K7y0vFWXpCKJ8ZkBzc6GbqdFVO0SYaKNOLijB 2fO1EI8iE8IukBWHgZFX5RyscZRDKqwWU3zMF1XP4XhEyEXNLimDd2IcJFciRwcmzBZddmJ itFoMX9pDFXpnstj+5VFoSo0rbKGKAnZfFSY8+t/L3NdHOTteZ1lW1RJIlBs6eR83UlE6J4 jOKM8EMLKi7EaE+XIy+700wOJp4yqCqdNlxMjzVhsp8TV5F4ecylByOQSkJQEu4RXtXgL8s VUq+80Hin+lUYCyefv9aBDeLdmvLXGfPZ3Loc0em2k0USlDkp5cJ1ZgIPh+GNvgNy4aKqxC NEAvqM8QFGGg8NzQshMPBIHxEClC1iQWNxvEVWO3QNofYPrhfeLWxqZgOB8JPfMrSASxso9 o52bsfEgUze/crCw0G5Th7OavL788+NIVUOImJD5FV0Pz0SFtHqUgyHDT3cwL6wbhul06Ky +LW8Vo/IfmpFF6NTaCWX6Qow5Bsz2dayF9gFmsNcJhXllg6F3IfyIzhIFcbl/LDnbhsMGi7 yt/zAqBpFF5pJr8U+KTPxv12JfE0+lWahSV1t1g25DJcZFJKu+N0qnuwGZzgxEnKR4C2A/u eMCz/pLNFHREiS7fy1bodjwj1dcQIMiWWAfK+qryhZM6Doh1VD13gd+cpSbK4OMs4DxLxRx ec7wobMAiBr69Ztix/0DLFAK2+d76TygGgssPKjG9oKLkKVUUlyymYHrGey2jgG3wx7X7iS oITKVj9lcYdswfWwHG6hPg7GQMOUvL8rhxFwgeJ6kB5VKO6xe6UI08+RzK8B2yZQFnK97Zt rbSl3m6qhgcCMH6zsmxbT5QiupqF64ZaIuj8uUEpZMddUiedfFg3TEJs51YmVt+iAhPnJIJ p0uySSf5sNVL8Dkyl8mtpi0RF8L21fHEecgMkDvQ== X-QQ-XMRINFO: MSVp+SPm3vtSI1QTLgDHQqIV1w2oNKDqfg== X-QQ-RECHKSPAM: 0 On Wed Jul 29, 2026 at 3:57 PM CST, Krzysztof Kozlowski wrote: > On 29/07/2026 09:46, Baihui Liang wrote: > > On Tue, Jul 28, 2026, Krzysztof Kozlowski wrote: > > > > [...] > > > > spacemit,k3-gpu is added to the existing ti,am62-gpu/ti,am62p= -gpu/ > > > > ti,j721s2-gpu "if" block that restricts clocks to a single en= try, > > > > since K3 has the same single-clock requirement. It does not m= atch any > > > > "if" block that constrains power-domains, so that property fa= lls back > > > > > > I don't get this explanation. Are you explaining what the patch is= doing > > > or explaining WHY you did this that way? > >=20 > >=20 > > That paragraph was describing schema mechanics, which does not belong i= n > > a commit message. v4 will drop it and state only the hardware facts: th= e > > K3 integration of the BXM-4-64 has a single "core" clock, and it has no > > software-controllable GPU power domain. > >=20 > >=20 > > > > to this schema's general constraints, where it is optional. T= his > > > > leaves room for a power-domains provider to be added later wi= thout a > > > > further binding change, should one ever be modelled in Linux = for this > > > > SoC. > > > > > > No, you need to provide constraints now. Please read carefully > > > writing-bindings. > >=20 > >=20 > > Understood. spacemit,k3-gpu currently matches no power-domains "if" > > block, so it falls back to the top-level 1-2 domains with > > power-domain-names "a"/"b". That would let a K3 DT with two power > > domains pass validation, which does not describe this hardware. v4 will > > add an explicit "if" block: > >=20 > >=20 > >     - if: > >         properties: > >           compatible: > >             contains: > >               const: spacemit,k3-gpu > >       then: > >         properties: > >           power-domains: false > >           power-domain-names: false > > I understand only half of this. Please fix your email client. > > And why this reply misses reply-to header which connects it to proper > thread? How am I supposed to find the thread now, among 200 I received > yesterday? Sorry -- that went out through a webmail client which sent HTML, so the quoting and the YAML indentation were destroyed, and it composed a new message instead of replying in place, which is why it lost the thread. I have switched to git send-email over our own SMTP; this reply should be plain text and properly threaded. > So your name is presented here as "Baihui Liang" then why do you use > some fake company name? liangbaihui@linux.spacemit.com is my real work address at SpacemiT. It is now sent through the company's own mail server. > Best regards, > Krzysztof