From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from SA9PR02CU001.outbound.protection.outlook.com (mail-southcentralusazon11013024.outbound.protection.outlook.com [40.93.196.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B68E8324B33 for ; Sun, 2 Aug 2026 18:38:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.196.24 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785695928; cv=fail; b=ouGdQ4WJaVXU4eDV3u5mb0iJwndA5wTFHm9nMmoqAcvlpjue0J6cxsMzcu6VWbbV5BgtWgRIICuF93JDi1H6whq+ltTlcIjcmQN2GkOqkJIDBJHVLvL63ExZ2pzO/rKNSWxfw2Y2wVlDdbjMGftuk2CpkMrCyEiNyIyeJ7MGCVA= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785695928; c=relaxed/simple; bh=3/9Av3mdnugieh0Ed5Q/++ROPk/OobhY+5uo3X4MVws=; h=Content-Type:Date:Message-Id:Cc:To:From:Subject:References: In-Reply-To:MIME-Version; b=YWUR7T2bFoLuEHqneJrIRGD+7N79G9BYW2WsidxibdyBvZgo9iavp9zO7ksppvaOsx3/P7JkkpocBrjrTtrhxEMoMreeN+E5mRBAYSOug/sh9jewexIfuRSXo8DqeZ2iDRgx7dRTF79YnK5Ev7836JSUo80fArw+3qIailBxjRQ= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=Fm1ezlTv; arc=fail smtp.client-ip=40.93.196.24 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="Fm1ezlTv" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=GGVlGLdP6a/AXmMM04GMfxkV+lzN1mg5vDGJvhpBeKbpHz9gwGzp5syZqcR6XHNqNKnEJOE2ikQ+qSDj0xWsPHAPudPgbgKrcBlLRga6tSyhVDSOod1E6dwcMI+DP304Mq5QkeAouBUaph3WxVf1d3xAvD3/hH1ic7pnzNO++0LUpLl5P/VUZQQoPaJTMxOSBu4ZA0ytxBosURwAkeHks5uSmcYVLBSmflymOUlCAxBdoxJ21Y/lTbBX2iDuxFXYqZnRnKW3gbD5EqsyFSRsalRM8ptkNsV0irJ5wZP3IRbf3Y64B7RO2LK4Nbgirkbq98q8+OqsOe/+UzldC4VGBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=w+nFUyl7uCnHI39cN8c3If+llDPOW7ASrjeUe/Yjpt0=; b=mQPu9Iykq7ot+uxv6rUy8pmQDIE8RMsrI12pPpD+2EJ0Ktq3PIhj5tSne2lhqAgcrcl1lZ2qwdAMzmmdickr/KOAWbQhj5kid+RMyyemYg/y4wtANPf+YGXqdFCxhALGjlpq46I+SFVza4CwFe+gMsIb7YAOsgdLyyWAzMu2O6w1WuGSpw40RvTHiA05H1GSM4XCuzjyZFuUpctIaIATu8kBWWs7dfbYD26VdEXQO/KZIpePxX2wJGhbs5i3vMVKwS36EDEi+N9kcVbU7RPYr1suykSjXZOu3bnA+PGVYHV8p1p51SuEN8A6n8bGUQrj+72EsVLuT1SmMkBXZs8qyA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=w+nFUyl7uCnHI39cN8c3If+llDPOW7ASrjeUe/Yjpt0=; b=Fm1ezlTvTFMj8SlNr0c7jWOkeiFKCQxzLBnLO9wan6ozNaZNf+FBkFOXIjo7Hpuz9xfS3isTqGd/JxPc8cVlhLgPT11XNm67TJjM1jaXl4XqkVS/K6nWz0gN1GtiYWtPdATQLg3vjL2UCgl5nRYjW+dIETxuSlSgk9xeL1SGZsfF0yfa/2Db6rGHU3bqxWOsHfVhTHXQOqpk6q+UCUrjgtW4gAT3jwVHZluqDc5zoCDN9aTBMiPyIW1l2VEct+muB82z6mjKepQZqexmogY6aEyJ4AzGw4dncicO9j5XC52gGJQEd8Ksa72c+Sz7ka6tFumgDr29UEN+yj5nqwIHxg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from IA0PR12MB8374.namprd12.prod.outlook.com (2603:10b6:208:40e::7) by BL3PR12MB6403.namprd12.prod.outlook.com (2603:10b6:208:3b3::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.270.17; Sun, 2 Aug 2026 18:38:42 +0000 Received: from IA0PR12MB8374.namprd12.prod.outlook.com ([fe80::d85f:4c87:ae84:3f16]) by IA0PR12MB8374.namprd12.prod.outlook.com ([fe80::d85f:4c87:ae84:3f16%5]) with mapi id 15.21.0270.016; Sun, 2 Aug 2026 18:38:42 +0000 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Sun, 02 Aug 2026 14:38:41 -0400 Message-Id: Cc: "David Hildenbrand" , "Matthew Wilcox (Oracle)" , "Andrew Morton" , "Muchun Song" , "Lorenzo Stoakes" , "Liam R. Howlett" , "Vlastimil Babka" , "Mike Rapoport" , "Suren Baghdasaryan" , "Michal Hocko" , "Baolin Wang" , "Nico Pache" , "Ryan Roberts" , "Dev Jain" , "Barry Song" , "Lance Yang" , "Gregory Price" , "Ying Huang" , "Alistair Popple" , "Johannes Weiner" , "Qi Zheng" , "Shakeel Butt" , "Kairui Song" , , , "Oscar Salvador" To: "Usama Arif" From: "Zi Yan" Subject: Re: [PATCH RFC 05/14] mm/hugetlb: use direct assignment instead of folio_change_private() X-Mailer: aerc 0.21.0 References: <20260731-remove-pg_private-v1-5-142c97ba3562@nvidia.com> <20260802121613.1590412-1-usama.arif@linux.dev> In-Reply-To: <20260802121613.1590412-1-usama.arif@linux.dev> X-ClientProxiedBy: BL1PR13CA0296.namprd13.prod.outlook.com (2603:10b6:208:2bc::31) To IA0PR12MB8374.namprd12.prod.outlook.com (2603:10b6:208:40e::7) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: IA0PR12MB8374:EE_|BL3PR12MB6403:EE_ X-MS-Office365-Filtering-Correlation-Id: 7d7ac1e5-e72f-42f8-ef69-08def0c546f6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|366016|376014|7416014|1800799024|10067099003|11063799006|56012099006|4143699003|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: wGi42BEYM/93fpTw0corajzseMFKDs6bzPh1315aI6+TISSfmApYCeFfdK1WLflF1gPlY1pscWJq+HibJHSFV7y50arJTAGIRPs+1Uz8m+3MM/QeeG3QnclrNHjGeJDhD1bhIXUWMQ0b3VgCmKmzOZOj17E+27DbuLhNzflszdXoGuzrGNLnlMl7c67WvzV8m2dF9Kx6qhm4FyZHWH6lrbgLFzthRxJIDrJoij4A+vwU9HS9p4ebDV/OnV15Pa/u89fLvX+QzUBQ2aloqj0oQK1CIzJZZVl8QeAnjYaEljPpr6cD4Y3QBo7sKG2v6VlElwKjK7J7LN0ZnmjRM5IX7gumeh2DKlSVrgngj17JHknj5qiTfJU1SN/BHP03OCVuV1+zz5V4vnWkv8X6qo9R7uTjP9aZh/qCMuJJefidQ80cwq6gRsK8XdSgNXkoAnQ6LzkqdiLacy00oOyqAF6cpqWO4SGZ4W/aV9rEelch8CpsRy0s7i7Wo/89kbPvCNgznNmmYsr/ckwxLU65qSBaNB0XlnfTsYKelrSVsVge13d6bvNlm/8MqLGanPpE7SzApcmERTyWJy+EEUFuxabsInv1lz/JofHUi71g4K1PMjjJKX+opXz5AQMCmialBtj2G1Hb0fxEoxhkCEou5SET+AXwk8xn/PqQT1JKI2sDNYc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:IA0PR12MB8374.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(23010399003)(366016)(376014)(7416014)(1800799024)(10067099003)(11063799006)(56012099006)(4143699003)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OHN0bDl2TG5RM1BKOThwODFTam93OU9ZcmJpTTdSV29SN0hiWWJ1SU5mMVpO?= =?utf-8?B?ZHRSbCtxRHNaNkRNVlByR3VVWmxMd0pad0dlTHVzd1l1bW9zNG12em1EcEZ4?= =?utf-8?B?L3dQVXpCd0lKMFd3RURzUWo4ZUZ1MTlnUE5mdkZnWmRKNkc1WURUWW1sd1d5?= =?utf-8?B?b09VcWZINUVHMkp2d3M3cEVXYTF4RnFJQ2NOaGtERlBBekNKM0YyeWV0cFM2?= =?utf-8?B?VjJqRGV3YzdKTGI0VEFqSFREZnRuNUN1M2s1czZSUi9jTTEyQjdRdUc0TlhU?= =?utf-8?B?NWxOL2hlU2d4elRpTy9CUzFnY3luZi9BM1JTQmYyMEwxSEVZNEdqOTFKelNE?= =?utf-8?B?TTR4YU85a3d3anQycFRKL3E3MUUvZmd1SEozUERoQjl1Qy9aZ0plUC9YOGxv?= =?utf-8?B?U0RZemUxQzUrc0NVSkNGWDE3UzBUeWF1Z1d5V1BUcUFhNHB5T1lBMlFSdTJz?= =?utf-8?B?K0xNWDN0UmN4ZFI5d2pEMUtHajVWeENTTXZrMzZvc1h5TVNRQUlXZ0ZzaXFY?= =?utf-8?B?VDlGUUZESUpSb1BrR2lBVi9jV2VJQ2ZneDBtMkdxQlFacWVxdGZTUFh4bm5F?= =?utf-8?B?YTJIV0JQcFBXTFFFRkJUaEpoU0h1a0Q5MCtLMkRMMDN3ZHMzY1l0TEY3QU9t?= =?utf-8?B?aS9UdjUyTERlQThFTkVDOVB2T1RZV05Jd0pkbjRjSWE4ZTVXRGJXVWY0dUV1?= =?utf-8?B?ZkdTN0ZRdTRJZ3Z6OXNUUWU4UGpLODBQb2ZaZjByZ2Y0aHJSREVzRUlqT0tU?= =?utf-8?B?c3dJZnFMMzZuQTRyOFRnNVZBTUczMWV4MHk2dWpDVFV0QU5RdEUvbk1TOTkz?= =?utf-8?B?Z1A1WUFacllreVhsb2Y2Smx4R3ExVTJaY0l6S1RRa3lQUWUveGtWZTdJS0tY?= =?utf-8?B?dnN4U3phMlE2T1I0WU1QWVdVM2N6V05KOEdldjg4bWZOaVBMR2w2QUpaSmd0?= =?utf-8?B?WUhGWmpNQVEzZ25JVGtpYzBhdXUrd0RkenNlS2xKRnB5alRTM3ZabkFndEl6?= =?utf-8?B?Kzh1S3dNcHcxZmRuU1lvZjIwUThRdHM4TGx2WCsrajFWRitpQUFnSitJb1ZS?= =?utf-8?B?MnNpaHU5ek51Z1BzTW9nd2VCR2VtRXdQUWp1UUdFUlRQTEQrSE5nQ2FvZEsv?= =?utf-8?B?SlFBYlUyUEVCelFhUFpnbEUrN0NKaE5zc1ZFV0d6aUtwSmJuTzV2T1NQeUNw?= =?utf-8?B?cjRqajJVTGJKWDVlTGxHZUFteXovdUFWZWVRR25XSEF5YzFVcUxidnNhakJ0?= =?utf-8?B?REN3a3RGMDVQb2hYdVgzQ3FFVExNYWFiREZ0U05Pa0VOVUhnUzFGMFRnem5I?= =?utf-8?B?ekNjZVF1ditnT0pKelBJZHZtVU5ZSjZQWHFNV1pSL0prOTZmS1ROcVZYVGFR?= =?utf-8?B?MmxSK2pWajBtSkw3ZzZNeU1DSG1LLzBtN3d5QkZCNXEvaCtGTWdwWG83MWJy?= =?utf-8?B?VFZHci9ackRuek1YYXpvZ2tQeXF1akJZS1l1a2JRcWpWRGpRSVBleDFkenNZ?= =?utf-8?B?Q2VEdE1uRml0Uy9TanByTlBrQTZqN0RJNlhDU0xhZTFOMm9GeDRPS0h5QldK?= =?utf-8?B?ckpSVURSQk5VVlhBQkdha08xWlpQRUx3K2xiV2tHZkhpdzdLVmhFVklUZ0F2?= =?utf-8?B?SDdCd2lIdkp4clU0Um5KNmJDU3g0L2tYSTR5K01UNVFhQTM4S0krczZUdmQv?= =?utf-8?B?bkJoalJudGZLeDRkRDVZd2J2cUNMOUVCN29ZWFYyNmdNLzl6cWNDQkpFd2Iz?= =?utf-8?B?ZDlrd0JERm9Wa3JQSHJ4VlI1UkxkVEJUN2pOUE5PR1p6LzYvV25PdnU5UjhE?= =?utf-8?B?L1hlU05oVFJJWDRxeEtpeUd3M052VlphSFh5MlZEQVlNNlIzb3RqdjN1Z1Ny?= =?utf-8?B?NzVOWEVkNG9iVXp0VG5hVnRCKzRlelc0OUJDZ1VjdmxPb3VpU0phdEV3cDRW?= =?utf-8?B?dmhRMXdIZTJaRitmdzczdVJJYlRFc3Q2d2ozQXJ5UElRWEM4ZkZYS21RVW51?= =?utf-8?B?TnBrdEdTVjFwb0p0Ym94MDlKbzgrNjhDbGppYThndFpFS1BYWE1zdk02c1Zm?= =?utf-8?B?TDl1RWFOTDMxd2E3YlY2dm5nY3RmVS9oY3p6dk9VeloxSXo3VzhnVkJjZEhl?= =?utf-8?B?RWFPSkNmSXRhazdNaWZ4UWMwWFZ6djhBL0hLSGJubWN2VDE3TzRyVkNBYWhT?= =?utf-8?B?S0tDZUZia2JObnVYaEFHM1hYejgvTUtpY0k5R3RvcmdkdW5uNFVRTTBjMDBw?= =?utf-8?B?NGs1S1Z2bXlMdzB1SUlnQjVkVFRzbWRudmJtUjNzWU1keUdQc2pwOERuSm1v?= =?utf-8?Q?S8cbK0Rr7J3a6+Mcgx?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7d7ac1e5-e72f-42f8-ef69-08def0c546f6 X-MS-Exchange-CrossTenant-AuthSource: IA0PR12MB8374.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Aug 2026 18:38:42.4370 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: odb5MxCzPlpr+cnQ0/zCEuUrr3zkXGVZWS0p2vFBMUfBO/lIaZ9XARfOj3uAr00w X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR12MB6403 On Sun Aug 2, 2026 at 8:16 AM EDT, Usama Arif wrote: > On Fri, 31 Jul 2026 22:13:28 -0400 Zi Yan wrote: > >> folio_change_private() should be used along with folio_attach_private() = and >> folio_detach_private(), where adding and remove ->private content requir= es >> folio refcount change. add_hugetlb_folio() simply sets folio->private to >> NULL without refcount manipulation. Change it to direct assignment to av= oid >> semantic confusion. >>=20 >> It prepares for a future commit that remove PG_private. > > >>=20 >> No funtional change intended. >>=20 >> Assisted-by: Claude:claude-opus-4-8 >> Assisted-by: Codex:gpt-5 >> Signed-off-by: Zi Yan >> To: Muchun Song >> To: Oscar Salvador >> To: Andrew Morton >> Cc: David Hildenbrand >> Cc: linux-mm@kvack.org >> Cc: linux-kernel@vger.kernel.org >> --- >> mm/hugetlb.c | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >>=20 >> diff --git a/mm/hugetlb.c b/mm/hugetlb.c >> index a77c3c1cb8943..0abaeb47890cb 100644 >> --- a/mm/hugetlb.c >> +++ b/mm/hugetlb.c >> @@ -1433,10 +1433,10 @@ void add_hugetlb_folio(struct hstate *h, struct = folio *folio, >> } >> =20 >> __folio_set_hugetlb(folio); >> - folio_change_private(folio, NULL); >> + folio->private =3D NULL; >> /* >> - * We have to set hugetlb_vmemmap_optimized again as above >> - * folio_change_private(folio, NULL) cleared it. >> + * We have to set hugetlb_vmemmap_optimized again as hugetlb page flag= s >> + * are all cleared above. >> */ > > The return value of folio_change_private() is never checked so LGTM. > > In the comment, saying "above" is not very clear. How about something lik= e: > > /* > * The hugetlb flags live in folio->private, so the assignment > * above cleared them all; restore hugetlb_vmemmap_optimized. > */ > > With the comment clearer, feel free to add Sure. > > Acked-by: Usama Arif > Thanks. --=20 Best Regards, Yan, Zi