From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from PH8PR06CU001.outbound.protection.outlook.com (mail-westus3azon11012000.outbound.protection.outlook.com [40.107.209.0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 40B1D349CDF for ; Thu, 6 Aug 2026 01:00:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.209.0 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785978032; cv=fail; b=VLBFDfMyAqC91C7x9DaDKqozHzOozltt00bThUy79uuzkua7rufIYRHXpl7A1lDTZL95baqP4IIxrvHHXXUpb5cZCq169oUpfl6fjDWYYh1mihoAix1n42IbUB5AjnsZu8ldegfwEGGgxHMuQ7rMvfMrCpKPZvqld9OtUb2AyLk= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785978032; c=relaxed/simple; bh=mjizXSbxNwA67gpYiLQHA53W38DnfATKT9MA0EXHIY4=; h=Content-Type:Date:Message-Id:From:Subject:Cc:To:References: In-Reply-To:MIME-Version; b=QrfT+sF4usBzTggopzA7EB1qn3cxs0GsbwVabiyK8KBdPW05uhyy2p1el9+exhBGiwJIsx9d9VIvKyTb8pYURHcxv/LKa2hPXp2GQ2oL4ilk+bXsvPbWwgZH0JCiKjEUnLMKg7n7Z6H4+SODFcc7P4/730m7dQHOTrVZE7VHgc4= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=Kc+g5KpW; arc=fail smtp.client-ip=40.107.209.0 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="Kc+g5KpW" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=SweQGUcUskt3zkbs34sSKqRNTDuO9ld6J2azg03GJaPQCB9a5aNa2eHDkES+/FhaD9bPprlLS0k0ZOua+xESNBrAUtrcZ2VKc5arO67MWFkJkwGkjA4Ykvt5D42Lq27CbucN90CLuZ57DbksZ30xVxxTI/L1dtfZkJuEUeMQ/zz/0Y3JEg3DU+k0VCo/wqtScEwczMgvzPn3Xq1+akxrHMdZ7dMDLFwpXYyL22KGYuJKhl4+oiXYJ/tCvySYL8S7xCXSdmwwKIPFdMg4eF9mrJAsIPGu6xwrhfDJnagEXYhThZXFWe1GMaX9imSpWchO6FWSFG2oYD8sH8I2FBigYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/auAtIb2LQma91X6m6M/7Q2/FIClsknvJAZM+dJs11c=; b=fYBsFz3f568n7+wc4Dymq6MjA1Uba25uQ7MCV/BJz2yuakvKg/9UWb2NFQpUAOiuSW/mHMExdmJz7YtqSNpHmWTFbbqutxY4YFjQ9YjmAig++AP4oOsSXzPHjfUe1dbGM8VkDcFDVLIBmptXgHcmUuhMBbw6mkDUtrazQ3b2BTQy3w9DA5Vy2erN5E6wHNWefs3YJ+LTLQghCq4sMfdHQ3YU/ChQ+93lgJ/SzoUcrMX83CDdLTp2pDO3da4/ZJS5SSpnmQRPo5rxafXqOFKvmmZs2VoyygznSnO74+eMdJfa345Vn062Ht/cllUpmugvz5kunxAw5ZkKjBYnP6oAhA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/auAtIb2LQma91X6m6M/7Q2/FIClsknvJAZM+dJs11c=; b=Kc+g5KpWXWS/SHVEJf9EXm/CmeIEVJ2/TPXYU1vUDBRxcJWD9+1WMrOl0ZmvxCFYxBqUdDC/ZkponMUefuuPh0MAnE8XnfZeZtJl8AreuR5oT6vwinKXR/vJTekonnqOn3gt2S763vviIn/3f2EXWm8227reWHEPQkzxHY0iNQSclGv5HLLCzuJ5OCRGtVOpx0FTWGRHeV2XmPsAhcndMxVEus2Loc1uJeGxiTRFByDqf/efE7V2OZsh44+lyBkQdyegErCoDpuDHTEOYd8OkHr+UV2jJ6tvCQFkDKkNcADuzJTPi2yW+5RWMS7+lYD0dbhkuCd4N1RanQ47/HLH3w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from IA0PR12MB8374.namprd12.prod.outlook.com (2603:10b6:208:40e::7) by CY8PR12MB7561.namprd12.prod.outlook.com (2603:10b6:930:94::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.292.19; Thu, 6 Aug 2026 01:00:20 +0000 Received: from IA0PR12MB8374.namprd12.prod.outlook.com ([fe80::d85f:4c87:ae84:3f16]) by IA0PR12MB8374.namprd12.prod.outlook.com ([fe80::d85f:4c87:ae84:3f16%5]) with mapi id 15.21.0292.018; Thu, 6 Aug 2026 01:00:19 +0000 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 05 Aug 2026 21:00:18 -0400 Message-Id: From: "Zi Yan" Subject: Re: [PATCH] mm: debug_page_alloc: fix NULL buf in debug_guardpage_minorder_setup Cc: "Ye Liu" , "Suren Baghdasaryan" , "Michal Hocko" , "Brendan Jackman" , "Johannes Weiner" , , To: "Ye Liu" , "Andrew Morton" , "Vlastimil Babka" X-Mailer: aerc 0.21.0 References: <20260806004556.2633049-1-ye.liu@linux.dev> In-Reply-To: <20260806004556.2633049-1-ye.liu@linux.dev> X-ClientProxiedBy: BLAP220CA0025.NAMP220.PROD.OUTLOOK.COM (2603:10b6:208:32c::30) To IA0PR12MB8374.namprd12.prod.outlook.com (2603:10b6:208:40e::7) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: IA0PR12MB8374:EE_|CY8PR12MB7561:EE_ X-MS-Office365-Filtering-Correlation-Id: 38c21841-8498-4e2a-66f2-08def3561602 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|1800799024|376014|23010399003|366016|10067099003|18002099003|22082099003|56012099006|11063799006; X-Microsoft-Antispam-Message-Info: POo5c1ahhQY/Hgmo9sPkNPmBR8CECyV0gBv9LhWOAaeXkDzy854xNmAE8EoHgqfwd0t0u4H/pl3nKeo1EelshStOFR4kSatiTrPFy/11B9BE0dBye+auujpKq+X3YaJowCQFwJDb07A0V9kzozp0ybR6Dal+ShKilTLHy/bv/VzkHYJ9CN4RViuaqKx6mWBCWlPGmbpacp7xqO4At/uFCfb8f3MFZLQ8gZcI08UcqVQJdep0Pnv47w8xNY8lU8d8TX9c+rOfvR91blkhK7VTSYGlgb+QLAndCIsilELKbkgSUzZiSHF4ZGpLfpdutDLlsJKX7Il9qy7h4ffG8xYFo+jeZxbODv0xe6w6nFMeyOkbI6IuHq4JHc6jjSp0wg4jeiTeHvOYEsL9SYIF+zXM6ljQ6qo5nQtCjDUsRekEuyQqCFaZyXeIUVjzhrEByWQGYqH6VAGm59qUGTBvwUoHL381FK9ED4XLt5oH15UuBycJCIZnQ575YRRhir7ltQW6fiBVIoCK80BxXBk5n4CPVFrG1oNL6gy5raJm8oy4LNNukX1Wd6hYufOAfyW5qGEtOB+aqMWsp78gBtCNKwaYZ936ss1SkNITjAXUg0cgomSeoOA7OPXFIR+NLNQAKZpGcJ/YzVOQ1KXIdUy2KrACM6kTvVRKfeedm3x/qgYB8WY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:IA0PR12MB8374.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(1800799024)(376014)(23010399003)(366016)(10067099003)(18002099003)(22082099003)(56012099006)(11063799006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L25BTTVHSmdnWG9wcVF3QWZDQ3FQVDdrQ3YzazZzZGFjYTVKdHR4VjhaRkta?= =?utf-8?B?RW5idHNVb1ByaFZxN2FMNU5DNnF3K2pXb2pqd211ZVkvZ3k4MEplcjhDd1Yx?= =?utf-8?B?c1hVS01XQUh0Q1VnZDc5emtibU5PMmV5VThUdExacys3MDk2MWg4Wk5GcXNV?= =?utf-8?B?UERKMnBlWGpnWDRDVGdZVjExcFpjYnVZMHA2b1BTam5NNEppYnh3MENpNFNE?= =?utf-8?B?TkhmZHZrYmhLM0pCaWJ1ckJvTTZCTTliNzFuQndTSGtWUTdWRTMxcGZmZitY?= =?utf-8?B?MW5pTkRqSm94MUcvaEVuRi9aSk9xQ2JWSGdLdkVrVjBTemxkTUJMSnhxa1Qw?= =?utf-8?B?by9HTzhGNXMranBHZ3FTK0F6UTRoQnlkVmI4NnNxTDE3WlY2TE1ES1g5OVQ0?= =?utf-8?B?NXEwbWg5NVRua0IwNkFsNlVUK3ZnR0FabHp1eUtqR3hUVkNubWtNRHRESThi?= =?utf-8?B?Yyt0dldid0NKY1M1cWhEeWZpMCtlek1mbmxWOXdaYXhZZTJLSk9BVzJMZFJJ?= =?utf-8?B?Y3pnSWhDSDFtSGI5cG5Ja2J2Q1hhNzllaUNVUFFNTHJ6dkVkVjB6K0k5dTRD?= =?utf-8?B?a3ZvV0NVa3JQWSs2M0ZnbHMwR0RVN3JiSmxZTFJ3aWJ0NkMyZTVhL2ZhVDhz?= =?utf-8?B?aHlPVmZoZFA1ME5pZTBySmZqVk1iK2xJSFdSL1FXUllnYnNXUm9xUkhVaWti?= =?utf-8?B?TDhGVWhwNENybVFxdFJoeWhGcCtLck85ZWxiemMvNzhlZlY0VThXWkFsbWdT?= =?utf-8?B?U3B3YnNLRGpKTnpScEFodmt6RUlqdnhmQjZtbGcvMkszK0xuZ0RoWTNXYk11?= =?utf-8?B?Sm1JNlptRzU1SHM5eE9vRUJUVGxXTEs3UFJlLzdTd1pMRFNkYkFBaUNaamZB?= =?utf-8?B?K3Z3ZUhXM2NVT0p1QWZXSDY4SXNIR3MxeWtJaEl0Q1JQdGRkRWRpRDloRExY?= =?utf-8?B?QUVsaitKNkhNNkVWQkNKZlVoa2V3Qk1nZ3dJYS9yMVpNdlpUZjd5NTZBRW82?= =?utf-8?B?eXFVaTNhVU9CUHIrVDhKNVhxZFlPaUZSczR6MGRINWtWd0NoVElDSldYZHNC?= =?utf-8?B?KytXMnc2SGRYR2s5UDY0a1ZvcEgwRHo1d3FvNjk0NmdUVUp2dzJIYmpiaVI2?= =?utf-8?B?ZU50c3lGOStvZGV0ekh2elRRblFCUnNiMWdYdzlqd1hjczNGSjJyWUltWkRJ?= =?utf-8?B?ZFVTRkNOVmpjRWRKeXpZV09Od2tsajVwa2xoeE9CcjBhaUJ3SmlBakVOeFF2?= =?utf-8?B?RHdrNjJEeFNWZ3JLcUcxTXdvb2hjZlR4VDVVUkZVNVQ3U3hmaE5rdkZYa09L?= =?utf-8?B?R2NRK2dkTFYrc3N4U2k5VHhtZjNuNkV0bkJDKysxL2l5U1d2VnhXM3NncTRX?= =?utf-8?B?T05kSGtkYWdGSkptZzVCYnZtajNYZk5JVFFlS3FneWJIaDN5bnordHFEYkp4?= =?utf-8?B?S3FVTWNMM3llcEd3VzhqN3FFZC9aOXFMRno2UnJYcUpBaEFxR1JUVDU5Y0Z1?= =?utf-8?B?OURjVTk3Mk5zQjJxKyt3dXh3Smx3TlVMODZLVytZblYwUUhOY0FCUVNGSjR3?= =?utf-8?B?WVFaTkJrRVVZcE1jblFYck1UNmpvNVY3ek9ZbllXOGU4MDBSTytoYUE0Tlp4?= =?utf-8?B?Wm90NlBhZndBMzc3VEVsSUQrMlNaT0JrUk4ydlM4WXZYdkxBOUxGeHJ6NmNV?= =?utf-8?B?R1EvSWtJbitoOThFeXc3aVgyb1lXVnk2ekNNMlg2bzVQVnlWZktLcTIvYlNF?= =?utf-8?B?TmFYWElMOU5ycWVPZ3ZYdmVtWERFSlVGYUlkemlyVVV6SHZ4cVdrMFJWZG43?= =?utf-8?B?QnJIN25xZEpvTitXSEZmSjBvVjRqRytRSVF3V29YUUh2U0lLRU1kQ00yUHpj?= =?utf-8?B?dmdWOWdPdHpZNFBVZHZoYy9kY1d6T2I1QkhjZzZ6WnJtcHp1Rmw3cWtHYmNP?= =?utf-8?B?eDFyOUR2bTFQMDgycTl2OVNoUGllaldydG9CekY4em9CU1lyRm1tcGR4UTl1?= =?utf-8?B?azhGNk5tbGxnU3MyeXlMbnAxS2dHUEJ4SWFySWRSdGhGcGhKZDFISmlGRGdE?= =?utf-8?B?dHl0SjJaSE8wL3RsR3BJUkF6MjlTem8wbjYwWWZ3aTRuNVFsYlczVHNaUkh4?= =?utf-8?B?TEVXZnh3bkpaVjl4VEtaVVl1Qk9PNkVMRGJCR0NNK1dueHRZSS9FMHQybkdP?= =?utf-8?B?NU82alhQWTlNbXhZZ205VHF3K1hOaXZJRG96eHJKbkxDanlFeDZHbWpXTHh1?= =?utf-8?B?bzJjSk1ZTzB6OEdmUEhzUVJDbTN2MjB2Q0VoWHZYc3krbEhWaVVTejdESnZV?= =?utf-8?Q?DPvwVTO8Fkqp+XIJM1?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 38c21841-8498-4e2a-66f2-08def3561602 X-MS-Exchange-CrossTenant-AuthSource: IA0PR12MB8374.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Aug 2026 01:00:19.6991 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: HkA4YclrBFVUtWHx8Y8k5NFxq2cAdIm+m9HXLzwdiF++A0iTy6wontnsH1LTJgfW X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB7561 On Wed Aug 5, 2026 at 8:45 PM EDT, Ye Liu wrote: > From: Ye Liu > > If the kernel command line includes "debug_guardpage_minorder" without > an equals sign (i.e., no value is provided), the early parameter > parser passes a NULL buf pointer to the setup function. > > kstrtouint() does not perform a NULL check on its input and calls > directly into kstrtoull() which dereferences s[0] unconditionally, > leading to a NULL pointer dereference and early boot crash. > > Additionally, the error path's pr_err("%s", buf) would also crash with > a NULL format argument. > > Signed-off-by: Ye Liu > --- > mm/debug_page_alloc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > LGTM. Acked-by: Zi Yan --=20 Best Regards, Yan, Zi