From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f46.google.com (mail-ej1-f46.google.com [209.85.218.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6845A2D5C83 for ; Thu, 6 Aug 2026 12:55:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786020928; cv=none; b=QtIhfOKrBMf/SsAj7iVYwdgPkF1J7z0zcnVVOnA1fC6PCtnSVcgULZsx9rLxeXswTEBrFW4RPJlRlOE952thlktqCT0wvJoNA9O24YKMTKYPUtFM4+9UDy6RwOWXBusMrqOUDIsSi5PM1TjzWdDSdfYNCFyGvXqEkQ6GxVQe94E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786020928; c=relaxed/simple; bh=aYkON+w1cvWz64PcaoerIEUwxylH1wQ7nbm75N5PQsw=; h=Mime-Version:Content-Type:Date:Message-Id:To:Cc:Subject:From: References:In-Reply-To; b=Yzn7ZQjzDoV8VpPjuJCVn/DQwoDZFSXQZC479VVXr6td3wtOvpHfG4lbgmkwZd4/XIfbv05A82VqUlR8czMKHnly7BWXWcleA4NcNBGuT8kU92jdqa4H5Tcg/Aj52Bl2Qb583b5gXK2Ogl+9j5ow+owbI20lO1vXRGzNGEMvSmM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hzF2tI9m; arc=none smtp.client-ip=209.85.218.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hzF2tI9m" Received: by mail-ej1-f46.google.com with SMTP id a640c23a62f3a-c15ba3a2b4bso259406366b.1 for ; Thu, 06 Aug 2026 05:55:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786020925; x=1786625725; darn=vger.kernel.org; h=in-reply-to:references:from:subject:cc:to:message-id:date :content-type:content-transfer-encoding:mime-version:from:to:cc :subject:date:message-id:reply-to:content-type; bh=WTmj5FYe3yse6KML3UCWlkLbz6Awba2heIHPiZBa1KE=; b=hzF2tI9mXAJKvWAWq5MDa0QL7CfZvu/3Cvbac1vX071TaFsM/qSiORysjk7bg8YO99 S3r6mtbo+KZmsjXf1dTNa0N5r7cb6e7b0X5uFkeTT5/ACFnjD5c4Pg8iyY9r7+1FHGPD zLJzLRbEakdX3GoM+mLfBAbQc7cfO7XWJarS6+OCWzJp4ue/CtkeDO2FgDqnvQa8QHz1 tUDSPa2Ci823EtwqC3rxn0LtRz5sT5ZUEJRp+67O2WXxvSRt4cdRuZUzD+Ryhox4vDbt OfbBjqvX+nGg140jKG5YCts/WTpxAkQjDUi3MEroyEteZgdgYrwAUM2pY196tYkdfgD9 5jFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786020925; x=1786625725; h=in-reply-to:references:from:subject:cc:to:message-id:date :content-type:content-transfer-encoding:mime-version:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=WTmj5FYe3yse6KML3UCWlkLbz6Awba2heIHPiZBa1KE=; b=Bwd7LUjAvHRhbM7bKk/+fWMm356uoaySxVJNqytyzIbCkaDLvkKo+7QMTWtGOz/3IF qYI95jmH1L7lgVPq6XkkitBxn3QfEtHjD7D7fP8xJOzW7+7ivDG6wauPUn2NiRv2oVL1 zGFhiAin7G5sqTTfoLKBs2RcjXO96Li1ECD8hXCCxQorKwH/FlmVE4vYXUqWlb2mwPDx YvGL8WuAYxa15ot1vWbU69lAy/SwfH+8W3kar0k/6fO/XtGRnk210hj+eby+u5c09j/z vd6gR4dQApgNklCk/AqIichiFOuRz9tDiak/ewCGHjstw7qEUBzpXv3z3ZLBNraSr9r3 QgBg== X-Forwarded-Encrypted: i=1; AHgh+RoD0SV4jOWKkNwiZZn3x8ao96gcg347hVK3zvrtLW3ZNU5xt0ZfFom9LOGtBiKnJTSZAOECcTv1klu0eR4=@vger.kernel.org X-Gm-Message-State: AOJu0YyJ9kaFYUfkYeYbIqx8fyDieQViTXyDyro+qtr7E0TjsDR945sn 4eWwOq//3NNKAgGK4zQI0FJTIkvriggmnvR7TAymGOZtf5dJEDxzwLRj X-Gm-Gg: AR+sD13ulAffiHypUYEzz5QpH6eImO0jLWxrQC6e6W+Gx7llemBuDKycZdzykB9OjPo X43eWkTCFedeK9g5QJsNTgsm+pu9cZiLDVLvL21RsOJgC7/MEKJ9JAfJTxE4yNvLZlqlnNTkN5Z r1ektn+B6HFCPxGrumEdjmPx8ddaqiONJrTu0whKjn8x1LWg2/jTv2Fnkp+Tge2HdFQOgKb7SNe Pk8qFQekKrRsAGp5YE82w3T1PGn1v0Lu6dyGAGDznYok4wkGVPMe8FzpsvsCAoZ1a1Vj8zO9bhI PixhdVkJxV5Wpq0fXL2fdVzCEyh+CdnjkNOPnAarKziNgLqe5w4EaVpN0hXb4hJu4/mslLELlsy QiyeRO1jnm3fbJ6Ff3sueg6EfWpA4kg650Os9zN/q3P7tUJGBLHeucLwb547mXLQ1uJX8zckeeW 9XlppHNdM7r+utLU64hqeGRQhPRaH3HIfzaGW8BPA3c3wRPN0GjRzXuIQ= X-Received: by 2002:a17:907:398c:b0:c12:b2db:873d with SMTP id a640c23a62f3a-c2039c03328mr804230666b.5.1786020925435; Thu, 06 Aug 2026 05:55:25 -0700 (PDT) Received: from localhost ([87.129.199.250]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c2036276e58sm252606166b.28.2026.08.06.05.55.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 Aug 2026 05:55:24 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Thu, 06 Aug 2026 14:55:25 +0200 Message-Id: To: =?utf-8?q?Nuno_S=C3=A1?= , "Linmao Li" Cc: "Jonathan Cameron" , "Maxwell Doose" , "David Lechner" , =?utf-8?q?Nuno_S=C3=A1?= , "Andy Shevchenko" , , Subject: Re: [PATCH] iio: flow: slf3s: restart measurement if VDD disable fails From: "Wadim Mueller" X-Mailer: aerc 0.17.0 References: <20260805110255.504576-1-lilinmao@kylinos.cn> In-Reply-To: On Thu Aug 6, 2026 at 11:39 AM CEST, Nuno S=C3=A1 wrote: > On Wed, Aug 05, 2026 at 07:02:55PM +0800, Linmao Li wrote: > > I'm also not sure about the above. If the regulator fails to disable I > would say things are already in a bad state anyways. Is there any strong > reason to do `slf3s_send_cmd(sf->client, slf3s_cmd_stop_meas)` before > disabling vdd? I would assume that without vdd things will terminate > anyways. Asking because if we just disable it then the above stops > being a question. Though I do understand it's better to gracefully > terminate things. Just not sure if there's any added value for that in > this path. on quite a few boards vdd is tied directly to the always-on rail, so there'= s no real supply node in the DT and the regulator core falls back to a dummy = regulator there regulator_disable() becomes a pure no-op that always returns success withou= t actually removing power. so we can't rely on cutting vdd to stop the sensor Wadim > > Just my 2 cents. No strong feelings so if the driver author is fine with > this, also looks like a sensible change. > > - Nuno S=C3=A1 > > > } > > =20 > > static int slf3s_resume(struct device *dev) > >=20 > > base-commit: 0efaefce4e95a3331550329c0078b2fb38b3ff1f > > --=20 > > 2.25.1 > >=20