From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from BL2PR02CU003.outbound.protection.outlook.com (mail-eastusazon11011008.outbound.protection.outlook.com [52.101.52.8]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3D58533CE86 for ; Sat, 8 Aug 2026 17:08:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.52.8 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786208882; cv=fail; b=s5pXe1T1/scWAkqhWpWr6vZlIYVKzYLwXEmCmjRI0UUFiYNfK1G3Frlg48NQ72+hjgHB+Fzudn73tBbv1bBbpfSJnNunfOXgmN7A5XBkD0VrH+X23rxEBHg4MwOVK5L/fNDvq18130VHcjWNYQ9iG6H1h5jbM6M73N+NV+CaBK4= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786208882; c=relaxed/simple; bh=l+b+lEJ9o+U30MsJ3iPQQk3i7Gi98sCLZA80Qsj3lOA=; h=Content-Type:Date:Message-Id:From:Subject:Cc:To:References: In-Reply-To:MIME-Version; b=Sml+fLe6w1XLuMYynJfmhCOkWdn68rv9rY0UjQ0ym9VzaNouZKvpXYg6SokrHUbZwW061ze1T1uT1VOykN3uYcV1rpvARKK1vKWo6Olvg/tq5O+S3FVWskrFikPjcO2tranPuoyPwnSBUL10ulN1d0U2yjO6JrUepzaqk3YHXLw= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=ADdbNH2k; arc=fail smtp.client-ip=52.101.52.8 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="ADdbNH2k" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=nwjVFaWKf+2jYPr/QV5/XSaWKK1I4YGONfKCkco3GI2UjHGw3B55hv82Fh0JLqd/IbUvh1OUpW9TlgtTq5GY2QMeGc0nIxAXZ2IRpPYcRXhYvuhz6v8Xk1ukW2J/jHhtmPRZAty8G+sICAVL/qeN097oKGTeBEd9apwR1WtOPL9K6AKPDxXlePGqVwTsCsAmmBZBPFh/PEXjIq+Q3osKc0PPNkeyFLyvFJ0nhmMkq2qWqHGY0iQ8lFOP4554XEwfVOgh0ru9sU3QCHvsOkULMyFmw6p4ROHLjhSTUwq+cqYNk/t5Swkyn8FbVLHJQ2SiiDewd3J++wm1r2xtOxycEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jeQWGE2WNFCPDpIuTg/nUnc3bgLphNLiF4YardBGcsg=; b=ULpAVd1M/AEM31Bmkv51l0nU4fQk0HeuPWmiYGtd8uZQtuq2iCMVa9sPUecvK5GFWfgY1kDGmv7zGrVbTGWKp6+v5TqMzu1CnqY/Yh0h+6tK+f2CQqM4edQWY+pTwQWtGZjjKyEftayH/amN38s8vur5kwuO/epM6aQe5XbZOBlotD//MNf6CtmVmYsdAy9kXzJAoDtzC7MiY2FcJhnQOXOTuoCd3pfN+whsspH8ySPYj5/96Yb/uK/mzKtF6p7WQ45NKMYzL+EgQNnsYgaMVlXD7v0eortPNhlXUFpBbZhrI2MZHP8e9recBOtJToq8sazkEUSBBNNqLuWMWKen6g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jeQWGE2WNFCPDpIuTg/nUnc3bgLphNLiF4YardBGcsg=; b=ADdbNH2kWluELraof+rqG/Y8FY3RNACv37PeLjWdYLTp42Y5RKOdBMBRFFYjppHCUz6NVDWX0iA6hCe/Xgaon+l2u5I+p1+SPKDMT4Fcs3S3pgteTLGglyBdX1M0nuNvCLj9Buz23kR5aTvLvS1Gm2ckeBr6XMnaU9My4qKmza23jgOcS3qPLKTVYq0NqWxI+GNwNocdeM3I8StVl1bGEKKafGFMj7NQaj+wfRjF9OoPxPxvqM0FOfRkhSGxmL26BgAx6pRx3OgTTnyxVmfPk20Hr35YpG6lj7Sd5KQTYHvuFaHmYNhfZtaHxW/nutztTwO+BTueSwK+klotuCyQWQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from IA0PR12MB8374.namprd12.prod.outlook.com (2603:10b6:208:40e::7) by IA0PR12MB8088.namprd12.prod.outlook.com (2603:10b6:208:409::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.292.21; Sat, 8 Aug 2026 17:07:51 +0000 Received: from IA0PR12MB8374.namprd12.prod.outlook.com ([fe80::d85f:4c87:ae84:3f16]) by IA0PR12MB8374.namprd12.prod.outlook.com ([fe80::d85f:4c87:ae84:3f16%5]) with mapi id 15.21.0292.024; Sat, 8 Aug 2026 17:07:51 +0000 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Sat, 08 Aug 2026 13:07:50 -0400 Message-Id: From: "Zi Yan" Subject: Re: [PATCH RFC 01/13] mm/swap: fix off-by-one in swap cache replace sanity check Cc: , "Andrew Morton" , "David Hildenbrand" , "Lorenzo Stoakes" , "Baolin Wang" , "Liam R. Howlett" , "Nico Pache" , "Ryan Roberts" , "Dev Jain" , "Lance Yang" , "Usama Arif" , "Vlastimil Babka" , "Mike Rapoport" , "Suren Baghdasaryan" , "Michal Hocko" , "Chris Li" , "Kemeng Shi" , "Nhat Pham" , "Baoquan He" , "Barry Song" , "Youngjun Park" To: , X-Mailer: aerc 0.21.0 References: <20260808-swap-thp-cleanup-v1-0-689939a7ccc3@tencent.com> <20260808-swap-thp-cleanup-v1-1-689939a7ccc3@tencent.com> In-Reply-To: <20260808-swap-thp-cleanup-v1-1-689939a7ccc3@tencent.com> X-ClientProxiedBy: BL1PR13CA0224.namprd13.prod.outlook.com (2603:10b6:208:2bf::19) To IA0PR12MB8374.namprd12.prod.outlook.com (2603:10b6:208:40e::7) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: IA0PR12MB8374:EE_|IA0PR12MB8088:EE_ X-MS-Office365-Filtering-Correlation-Id: 86053e81-dc98-4595-8d0d-08def56f948a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|366016|1800799024|7416014|376014|22082099003|18002099003|56012099006|4143699003|11063799006|10067099003|6133799003; X-Microsoft-Antispam-Message-Info: trv3X8aUUbuUY8bsXIdSqLlp3k4gMPRNSZh//nY7MEE6scXRtiUt/feA/csGdFcf8VN+z5qsk0g5nlC0TZvSfLTh8A3SKjTi5pAAGDhTxksf8cqKkzPJi9aviOzi7mIh85P6aTDBo2aYXrg5GjNX5gRlnVlP5h4nDHM1+pngRTfHYNQi/kynBT+pKsYofSggKpBC0CbvQ4Broq6HcL5lE+fMATmzgfCqjyIIB31k1UUvlTNZ2vSQ4+IeAVts05RxA6Vxb+akCL0sAN1VC3U75I+af4QUz1q0pS4/A5dwlhq3SDH8/POQb/+4KvU3qQP9kGaA/uUn9Mw9vUVupOohoJ4WUoMSdJXAuq1SP4Q6oTf8504sVfO7p3O+wlki1nJdE2v4SfqbUnMYUMlz78u8uiVw/acZFN8Yj4Lm7NgUQPgY14ymfFhWe44r68O0P5RoDk6vxv1NKrBiMph9ye3GGaaTIaWyH3Di5GZtE3ZlPkCNpPOfze7Q6xSEGi/EDS5IPwH59dPnmLZK792v180WP2aYnQGTIVB7YJLQ/HmO7+BtgrbKhhgHK+tCEs4wqp00yg4p1fbNtbEnlKwaV+ieY60P0aEBN1Z0tBlHWwEoLoA0x/e4G9a7STSc7o/gGkJeJUMwqZPNS7PsV1OA0Z1juB5NCcUfTAgBorniIWeQigI= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:IA0PR12MB8374.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(23010399003)(366016)(1800799024)(7416014)(376014)(22082099003)(18002099003)(56012099006)(4143699003)(11063799006)(10067099003)(6133799003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?a3J5Zk5vMnU4VmJYZ21nSndnSy9Rclhrd2NnOFBybWNENmEwQ2dObEVjdXJZ?= =?utf-8?B?emhnVFVwQXpHOUpCQytYY0RiMmxGbnhxTjAyNWVuRG9VQTVvd2tMdzJMZ0Js?= =?utf-8?B?MGdoNGh4NVViRFdmTnJkdlFzdGtqeS9VRmkzZXZ2czMrbFFTN05PR053QjJh?= =?utf-8?B?Wm9GMEpPbm5pOWQ5MHJaSVpJUHQxL3Y2SjN0cmVaOFA4VndlK2N1bjVsdEtu?= =?utf-8?B?M2JpVFZySXVDTmh3cU5iVEUyR0wydGxlQzlVQXBReHJnSkhJUmJEZUEwL3lh?= =?utf-8?B?VlhMTXQ5bEJCOUwyUGpFakdCRjgxQ25Xams0MUcyZm4xdStpaDhYdXpOZFBK?= =?utf-8?B?Mm9sZllBY0MrVzAydHhDNkpoOWtIT2xTUFVKTmlRUTZaczZRay9RTlIvdnJt?= =?utf-8?B?eGJ1RFBDNDZvcnJzTFJIR0NKTzBRQ1NIQVYzbGlkYjM0RmYybjlBWWI3TkpU?= =?utf-8?B?aktFSGFvVkN4RDAvejNYVHo0SklsRDg2alBQR2o1ajkvUVpiSUtsVDdqTHBt?= =?utf-8?B?c1lRcno2RS8wS2ZKYlc5RUdqanQrOWxvd0FWYURNNzJXOHhtZ3ZvbEc1alVQ?= =?utf-8?B?L1k3VHdsS1RiYTkvUENjVXhjNGRMZ1ZyUm9ZUS8wZkkvV21oTnRodVhJa2tH?= =?utf-8?B?bWJKamFzOUFNSTFSRlFleU5vN040NGw0aW4rejRhS0IzamJycEhOT3p5Snps?= =?utf-8?B?djZTc2Z3aXRUSXg5ZkZTQjRBVVU5UUt1WWlaeGdJNFUxQ2lsYjJkVUVRa0Yy?= =?utf-8?B?dnFFalpGejBYdGt4Ylp0SCsxUnc5NU9mK0RtLzE4SEpnUWl0SGF3dHdodjRm?= =?utf-8?B?b1RHS2h1c1FqYmNvQWV3cEpCU1dCbVVWZ285Q08walRDN0RoQkxTUDZreHNQ?= =?utf-8?B?dUhMWWtmMXZsNmFrWUZYZXRodnErTlZxbUlrVnQ1S2dkWXpVb2VwVElzRmta?= =?utf-8?B?Z0duYm1LNjFWYWJCNnYyaTdYZW94QlEyTlJCeU56dzllN2dJTnliSEV6b2w2?= =?utf-8?B?OWRYTXdLUGxudHdIYXowem8zMzlEaVlsY1MweDRqM2JrdlhNWHVVNmVIa2pR?= =?utf-8?B?S0RNVVNuMHozQVFTUnE5NWhiYXJRN1JQTXJRV3U2V290bjdTemFhMWgwQTJP?= =?utf-8?B?TGtMWHAzUGhFOHdOSlVKWFY3WlpNNDJ0SHRIdE1RcG5OYXd0Rk9qekYyRGJS?= =?utf-8?B?UXcrZVJ2VDZ0aFFxZG5mOFdJa0QxbGN3RzFCV3p3K0xRYmVJU1U3cjRxK2kv?= =?utf-8?B?emY0N01Td3pnYUYwN0NaVjdwZ0VJemJlNyt2WUo0b2o4NHN5ZGk0eXE3cm5t?= =?utf-8?B?YmN6M0xqMFpvSE15aFlNQ3ZiQ1h2bVAwTmkwdU8raU1GZjYvZVBRMWhhUmFK?= =?utf-8?B?WlU4Ynl3UDRRTWtkZ0d3cmxUMFdrMmw5RmE3RUdaOElHK3NGNjNOM0dHN01M?= =?utf-8?B?NC9WdmY1T001Zmxjdlp1bVgrUnlRaklYMVBTcWRmcHh0ajY4WmFBMUpsall3?= =?utf-8?B?dmwyWGpJZDhZYmZ5dS9OOE0zNkdIOGduRi9UazFCWVVlK2VrTE5vTW50Q2hP?= =?utf-8?B?cUhZVlRzajBSUWtxMFNKUEFQWWVtRWRNZVp4MEt4T0JmMitpdGdnNkwycEo5?= =?utf-8?B?Y1dEaWtuMWMzSUhpbnRqRmVWSXpoNHlaaFRsZlpJOFhaTGxFMndOaHNjZ3VM?= =?utf-8?B?bHVuOHJrRW5wVCt6NkR6OFdmdGNqMGN3TmJBL3RqVTNnaTZORlE0Zms0VG83?= =?utf-8?B?bmdReXkxYXBBek9UZE1WWmV4Lzc5YUtHT3RtSWM0OTRXTkdFbVhhVkVwaHVH?= =?utf-8?B?d3lFclI0VStRVWF2U1J2T2ZQYmlOU1RyYlRhU2E3STJPQ2tpNStETUtIZnl2?= =?utf-8?B?VjdxRVFuRjBsV3RyeHlGcGdNY3hZMFRYVjZablZqeXhBdFVKZHk0RWFIelpW?= =?utf-8?B?WmlnMGRPT01EWnpwTUdENzNZWGxXT2cvaEswV0lVa3dQaHkveHBqTUZ1VTJL?= =?utf-8?B?WUp1U2c4V1BzcHkrK01Sb0o2UUc2NWIwdUZCZ1pKYnJUMGNjTVMzWW5Ua0ND?= =?utf-8?B?YWkxd04yZXh4bXluakx5a3hneHVkY281U21McUlsbVArbE9VcGcxZHFKendV?= =?utf-8?B?VDZJd3FDRGNSWVV0am5yakJLZkZVNFRLT3BmWEVySlU1Y2VOOGx1bDdMQ2JQ?= =?utf-8?B?emdDaDIyYlVBMTFWUFk0SEtNTkJESmpEaUZCUmppcnZicE52WHIxMlY5emw5?= =?utf-8?B?d3JTUU1PMzlocjVvak82WHVRSGZZcHg0dHBTbVY3VXAwUHByaUZ3UW9TdWoz?= =?utf-8?Q?ydKYS8PkgM2BxgwBLc?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 86053e81-dc98-4595-8d0d-08def56f948a X-MS-Exchange-CrossTenant-AuthSource: IA0PR12MB8374.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Aug 2026 17:07:51.7155 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: fHWicmhUi0024oTHdMR5kOr7roc1rLEZLisNU0UXA5Fb51vtx0vUeLXo5fNLmBtJ X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB8088 On Fri Aug 7, 2026 at 5:17 PM EDT, Kairui Song via B4 Relay wrote: > From: Kairui Song > > The DEBUG_VM sanity check in __swap_cache_replace_folio() iterates > the old folio's range with "while (ci_off++ < ci_end)", so the loop > body runs on the already-incremented offset: the first entry is > skipped and one entry past the range is read. For a folio split > that entry belongs to the first after-split folio and was just > repointed by the replacement loop above, so the check would warn > spuriously whenever sub-folio orders differ from the head folio's, > as non-uniform swapcache splits now do. > > Use the same do-while pattern as the replacement loop. > > Fixes: 8578e0c00dcf ("mm, swap: use the swap table for the swap cache and= switch API") > Signed-off-by: Kairui Song > --- > mm/swap_state.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) LGTM. Acked-by: Zi Yan --=20 Best Regards, Yan, Zi