From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-vk1-f170.google.com (mail-vk1-f170.google.com [209.85.221.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D34303AAF4D for ; Sun, 9 Aug 2026 08:29:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786264145; cv=none; b=cxNdbTESTzcwWVd+R4/DsxsZU+18CoccFN6QjHboRzQQFEzmPJBZNdFphi2/z00XZXoYOyUTW+AqvbnSOPeWcGR4xILP8XFYY4oTnwZXguTHWYjwwPS5QpT8HhIzjNBx2Er/nygQjHMcDjXMEjqBZ+8k8HaPu/h1Efuch/yydXQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786264145; c=relaxed/simple; bh=DjBhbqW14d9nmpPCYYk6v+xFyikmQDSHMu3Aajds3Lg=; h=Content-Type:Date:Message-Id:Cc:Subject:From:To:Mime-Version: References:In-Reply-To; b=Mtu522CDhfpWcvs2r/1yt5Cz0Zn8OnkfMGWJRIZTm7+2RsH2pDEvoMAx5uPb5duY0ITExMW+Oe2sRlk55LCk73t4dQ8qUYchq9UThA0Nwyzk97PFmXcNL6RQ8Kuk4fzqNkZtyUA9Y6J5H7aEclDZueaWycWM+Nzj4lWAHyf0gzM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FzovIO6f; arc=none smtp.client-ip=209.85.221.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FzovIO6f" Received: by mail-vk1-f170.google.com with SMTP id 71dfb90a1353d-5bf959b820cso645185e0c.3 for ; Sun, 09 Aug 2026 01:29:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786264143; x=1786868943; darn=vger.kernel.org; h=in-reply-to:references:mime-version:content-transfer-encoding:to :from:subject:cc:message-id:date:content-type:from:to:cc:subject :date:message-id:reply-to:content-type; bh=rqHnH3bazfPo8L9yN8K7qxpi9gCCvgA/6bCTLUUeJSw=; b=FzovIO6fwwTaNTJKTj37e3TwV5BuW0iQUg6l0854Vs5HEsKCCWWWf+M0KB0Wmi3xcG CQTAuxwWYxDdqx6urzDylQ5vQjti48MHkE1D2bWIjSjuJW80uHKjYTsvcSv6Jjm9AY1q nNCCBFwTPfBUjaVr4fbduGGy/zUVo9PH58K1kefbxDvUS+oH3Tc+uoAH8WbS4Gpu0MqD 8QK/HxvOmP7WsdxDprU0bUy2q2kF4w6KjI6o2IbhvpI5jLXPcuurapSBWfWW3MihFkAi uzffmWwO/o+eJGfQIJUWZx93nrpROhJo6P6tOjpUrRqqYxgWmEVG5t5TwNR6v/CGXAe5 LqDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786264143; x=1786868943; h=in-reply-to:references:mime-version:content-transfer-encoding:to :from:subject:cc:message-id:date:content-type:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=rqHnH3bazfPo8L9yN8K7qxpi9gCCvgA/6bCTLUUeJSw=; b=BS9zQUMXt+7IxiGnQJ4PtwdvGtu7Arl1kx7oKI9M95IhkTLhbUTX6QLeuwvRNJgCY9 By7L245kKLginochmleef/cVEMIeyzpogTs+YvbpQ2sNfgnhLBsR8TXxPvrHNqDvhUA/ LjdUwFL+UW2L9JkeHfjF4VSTfeSABcfvTaI17mqZJ2C6HOR5dsBwvydWGLAFXq1C5ZgD LPjVTnvJFdx/niEXHk4nZ0HzpQDkQaRlUmkPmJLcrO6YS49VgnuwRCqLH2LraR63LsNz S2E82j8oTWD7fFdyaVbLNwjyfHx4Pp8YdfRlZYMK6g+Ta0AjJOTeizhqqamUOt8VnpsM BITQ== X-Forwarded-Encrypted: i=1; AHgh+Rp0chQRm4rMIqzwq+NwvdYZjITfSLAz1qWoxv+frWsWj7yI5R1a8juz7Sg/onLqaoKnYUdjp9GitOrVnmM=@vger.kernel.org X-Gm-Message-State: AOJu0YyqjwCQ9iQzofmAwQ51J40u3uwcsj+/8r7Qog3VblfPY1Sb9YVR kThbcTMw2UrMjoQ0gxGyWzOI+5k4m0vo7mShFdbJc9HXe5J08+p6FZw0 X-Gm-Gg: AR+sD11BhOjyPgQ/6CLB3cIOwJc4x6yFparzJ4YtsC3sT/i2F6vjnQCtil6oMGxjDgy ZM+dPvju6cVIZ9eU/KYjkLAVQyyPMNPUtnYRFLc/fzZvX5PAoYEalC+Y4FWczVLphm2XD1dCTIw gNAmBjbe477AxiPRnwnLBIetgU9K1Nz8IVUucRnyZVi58anqWMKngZnhGKRxQe0Uprs63q9WHPd RQnW0uTkU59ERzsjrHM0R+4O//pxES7ghWeondyf37EAMXnZQExb/LFsjX9p7MW/l5eELCm6ddu EJoz6GO5Dk847XpbNGpNZvBo10PlVQI+CdnZqQ5Sd1LiDZ+Y4/RZAsxTz5DqTFGrsarogdAfaMs V6XoKy9Ys/JyhhgyDO9KbqE4TVsxObySuQ+VfYuVVAVJbBgIwJR6ZQKxzUrQK7EQyOu85MjzlEb Bf4Dk7OaPl7Hjqa0iuVJPjaQQWNXOZqvWpqQsQKNnx0wl6/h7j6IXRsJezcMxSwDw= X-Received: by 2002:a05:6122:ca2:b0:55b:d85:5073 with SMTP id 71dfb90a1353d-5c411331e5amr1700380e0c.4.1786264142723; Sun, 09 Aug 2026 01:29:02 -0700 (PDT) Received: from localhost ([2800:bf0:82:11a2:7ac4:1f2:947b:2b6]) by smtp.gmail.com with ESMTPSA id 71dfb90a1353d-5c4130b358csm2114122e0c.14.2026.08.09.01.29.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 09 Aug 2026 01:29:02 -0700 (PDT) Content-Type: text/plain; charset=UTF-8 Date: Sun, 09 Aug 2026 03:28:55 -0500 Message-Id: Cc: =?utf-8?q?Nuno_S=C3=A1?= , "Andy Shevchenko" , , , , Subject: Re: [PATCH v3 8/9] iio: adc: ti-ads1262: support REFOUT and VBIAS regulators From: "Kurt Borja" To: "David Lechner" , "Kurt Borja" , "Jonathan Cameron" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Linus Walleij" , "Bartosz Golaszewski" Content-Transfer-Encoding: quoted-printable Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 X-Mailer: aerc 0.21.0-0-g5549850facc2 References: <20260807-ads126x-v3-0-f89925d72792@gmail.com> <20260807-ads126x-v3-8-f89925d72792@gmail.com> <9f0779e5-3139-4c49-96b7-330f70b523a9@baylibre.com> In-Reply-To: <9f0779e5-3139-4c49-96b7-330f70b523a9@baylibre.com> On Sat Aug 8, 2026 at 1:40 PM -05, David Lechner wrote: > On 8/7/26 10:58 PM, Kurt Borja wrote: >> Register the "refout" and "vbias" regulators to be able to use them as >> common mode supplies. >>=20 >> Signed-off-by: Kurt Borja >> --- >> drivers/iio/adc/Kconfig | 1 + >> drivers/iio/adc/ti-ads1262.c | 90 +++++++++++++++++++++++++++++++++++++= +++++++ >> 2 files changed, 91 insertions(+) [...] >> diff --git a/drivers/iio/adc/ti-ads1262.c b/drivers/iio/adc/ti-ads1262.c >> index 24a7ecb9fbd4..533574169b04 100644 >> --- a/drivers/iio/adc/ti-ads1262.c >> +++ b/drivers/iio/adc/ti-ads1262.c [...] >> +static const struct regulator_ops ads1262_vbias_regulator_ops =3D { >> + .enable =3D ads1262_regulator_enable, >> + .disable =3D ads1262_regulator_disable, >> + .is_enabled =3D ads1262_regulator_is_enabled, > > This should also have a get_voltage() op that returns > (VAVDD + VAVSS) / 2. Otherwise it won't be usable as a > common mode voltage. I'll add this. > >> +}; >> + >> +static const struct regulator_ops ads1262_refout_regulator_ops =3D { }; >> + >> +static const struct regulator_desc ads1262_vbias_regulator_desc =3D { >> + .name =3D "vbias", >> + .of_match =3D "vbias", >> + .regulators_node =3D "regulators", >> + .supply_name =3D "avdd", > > What does supply_name do? Make "avdd-supply" the parent supply? I haven't looked at the code, but it seems like it (sysfs verfies it). I'll check how is supply_name handled before the next version. --=20 Thanks, ~ Kurt