From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.forwardemail.net (smtp.forwardemail.net [149.28.215.223]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CA8BC39CCED for ; Sun, 9 Aug 2026 17:13:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=149.28.215.223 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786295617; cv=none; b=HH6HIGk5b9DdpeMvZCIgKNQPb3fE7eVfqbVTRNNvCqWuNa8riTMqeVKGw6gETUDC2u0ea1pzVy46omG+rlI52ztSSYU2tmEFZ7YBueVQwTQ8K5fpsJnWstOnE8laEe3PsDLWyGGaWRgwJgfk/qPnkwRK1O2yHhX2UCPEwOfvPic= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786295617; c=relaxed/simple; bh=sdkVaGxQ9WXK8ISzY26/7j0yy/WLWXIs5Q/P9RAMv4U=; h=Mime-Version:Content-Type:Date:Message-Id:From:To:Cc:Subject: References:In-Reply-To; b=r7vNe+Jqkn1SiqhjyFMQd1zkfU/xVB4i/ApLUPz/9wktrnMDLAzrDPqnql+kEp/jyVXsJyQ3DQKddLRRIqj38iF5DDE5Ufvs8j6VIL1+IwDo7POtAZ/3RIrHhyNX7eiThjchoza3KclihIfg44pDdfPOOrjwebBQcw7lKLaCFr0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ubuntu.com; spf=pass smtp.mailfrom=fe-bounces.ubuntu.com; dkim=pass (2048-bit key) header.d=ubuntu.com header.i=@ubuntu.com header.b=H2SRcHHF; arc=none smtp.client-ip=149.28.215.223 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ubuntu.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fe-bounces.ubuntu.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ubuntu.com header.i=@ubuntu.com header.b="H2SRcHHF" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ubuntu.com; h=In-Reply-To: References: Subject: Cc: To: From: Message-Id: Date: Content-Type: Content-Transfer-Encoding: Mime-Version; q=dns/txt; s=fe-953a8a3ca9; t=1786295611; bh=sdkVaGxQ9WXK8ISzY26/7j0yy/WLWXIs5Q/P9RAMv4U=; b=H2SRcHHFVTG0P9PNymtJUlceUBgzDoPWHRxrmsjsGBdLIEup1jxHkOPMlIA+AzSNCACBQFGV+ W/xoER/uil9BHUHTAoBjvTSsLNjWpWW6HfSE9tYWRs2MEKRGo96rwy9076AtvSGaTkI8jHek5ka OuJ1sn/7G4Rg2v4ZT6adKMj4LWyixr2cqj5Af2ZPvPEiE9O7QiBibxcShi1W6QaOA0h1eo/y9cQ hyO9Gz1PJ4wKn07GROMsaWkF+5TmhnFSm5hFjyOSF8g0j0n8h+OCkyYVVukOZHiQJKUhyvDVdHb Ka0gFiLa1n9T0CcaVVyXKctnd2HMJfVcuTuvm90uvxbQ== X-Forward-Email-ID: 6a78b531430e5f5f6cba74ac X-Forward-Email-Sender: rfc822; jpeisach@ubuntu.com, smtp.forwardemail.net, 149.28.215.223 X-Forward-Email-Version: 2.13.10 X-Forward-Email-Website: https://forwardemail.net X-Complaints-To: abuse@forwardemail.net X-Report-Abuse: abuse@forwardemail.net X-Report-Abuse-To: abuse@forwardemail.net Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8; format=Flowed Date: Sun, 09 Aug 2026 13:13:18 -0400 Message-Id: From: "Joshua Peisach" To: "Sven Peter" , "Joshua Peisach" Cc: , "Philipp Zabel" , "Rob Herring" , "Conor Dooley" , , "Neal Gompa" , , , "Janne Grunau" , "Krzysztof Kozlowski" Subject: Re: [PATCH 2/3] reset: Add Apple SoC CIO reset driver X-Mailer: aerc 0.21.0 References: <20260809-b4-cio-reset-v1-0-4f33777d9b4b@kernel.org> <20260809-b4-cio-reset-v1-2-4f33777d9b4b@kernel.org> <7a170485-b349-4502-adb1-3ce6217bc435@kernel.org> In-Reply-To: <7a170485-b349-4502-adb1-3ce6217bc435@kernel.org> On Sun Aug 9, 2026 at 11:20 AM EDT, Sven Peter wrote: > On 09.08.26 16:30, Joshua Peisach wrote: >> On Sun Aug 9, 2026 at 8:16 AM EDT, Sven Peter wrote: >>> Add a driver for the reset of the CIO (USB4/Thunderbolt) blocks on >>> Apple Silicon SoCs which has to be deasserted before their >>> co-processor can be booted. On t8103 each port comes with a dedicated >>> register page while t600x uses a single register with one request bit >>> per port shared by all ports of a die inside the PMGR MMIO region. >>> >>> Signed-off-by: Sven Peter >>> --- >>> =C2=A0MAINTAINERS=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0= =C2=A0 1 + >>> =C2=A0drivers/reset/Kconfig=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0 |=C2=A0 10 +++ >>> =C2=A0drivers/reset/Makefile=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0 |=C2=A0=C2=A0 1 + >>> =C2=A0drivers/reset/reset-apple-cio.c | 182 +++++++++++++++++++++++++++= ++++=20 >>> +++++++++ >>> =C2=A04 files changed, 194 insertions(+) >>=20 >>> + >>> +static int apple_cio_reset_probe(struct platform_device *pdev) >>> +{ >>> +=C2=A0=C2=A0=C2=A0 struct device *dev =3D &pdev->dev; >>> +=C2=A0=C2=A0=C2=A0 struct apple_cio_reset *priv; >>> +=C2=A0=C2=A0=C2=A0 int ret; >>> + >>> +=C2=A0=C2=A0=C2=A0 priv =3D devm_kzalloc(dev, sizeof(*priv), GFP_KERNE= L); >>> +=C2=A0=C2=A0=C2=A0 if (!priv) >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return -ENOMEM; >>> + >>> +=C2=A0=C2=A0=C2=A0 priv->variant =3D of_device_get_match_data(dev); >>=20 >> Might be a dumb question, but does priv->variant also need to be >> checked? Because later priv->variant->pmgr_child is and I *think* >> it could return NULL. >>=20 >> (Or is this not necessary since in theory the device should only run >> this if detected... so this should never be an issue?) > > You might be able to get this driver to probe without a device tree node= =20 > by manually forcing it with sysfs but well... play stupid games, win=20 > stupid prizes. > Adding the check is just two lines and doesn't hurt though. Meh, not worth the extra lines of instruction. FAFO for the curious.