From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oo1-f46.google.com (mail-oo1-f46.google.com [209.85.161.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 957EB264614 for ; Mon, 10 Aug 2026 21:44:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786398277; cv=none; b=nUN0ZmSrz9FHAVQt/0bhNgoeiBZIXhStjk3bis131MOOGa1IKo6s9U6p02t8McVuFwYi09kS6L1GBWwDPKshYx6G8+eG/JmkIhi1qm+qm58Arxfd28pA4LwJ9MhJ0hAxygHxX6pT4mtFwUP0BtrGMkcVOlbqYXdpnn3FMQjRVxE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786398277; c=relaxed/simple; bh=M7XmmNDhObpDscq/5NITervqrqbUm2SJhQ96QdA+7DU=; h=Mime-Version:Content-Type:Date:Message-Id:Subject:Cc:To:From: References:In-Reply-To; b=Fd9vR3HVdPFOnQCOQZJ6cvlcWLLn4ewkxgLjBdJOfxjxa24HTSuP01zQHzUnydvp0TxNvjfweoucBofWa0jI4vAw+SP+qnd+FIgioaSG5rIJ5+udwpFvwxjyuAUC7ZIVQlr4TbkCo7OQwImpbuzdTPapwuXMsPtuQmYUoIkq0ms= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=marliere.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=marliere.net header.i=@marliere.net header.b=Fh+IG77x; arc=none smtp.client-ip=209.85.161.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=marliere.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=marliere.net header.i=@marliere.net header.b="Fh+IG77x" Received: by mail-oo1-f46.google.com with SMTP id 006d021491bc7-6aae90e595fso971025eaf.1 for ; Mon, 10 Aug 2026 14:44:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786398274; x=1787003074; h=in-reply-to:references:from:to:cc:subject:message-id:date :content-type:content-transfer-encoding:mime-version:dkim-signature :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=2V078lMCX/mS2MTPu9h7Yq1IlSrt9Zb9hUAWqMeTHe8=; b=UTyIr7hdz3XEdBAY8UVKqWtbnBWeZCzVB5qs7umiq1q8dUwJxdTOtLueEO3/PIYN4c sLpsf4amMysj02/ZIq47IxZTsyzXrcgMDVH+DXxumkSgGDU8yMDk1jTpuJhIVwCaN9Z2 nv1uYXbxerx9LWaYpfE9M49E4xIUf4g/qjdEjKw+F3f/Y4Gz3OuBvXXD7DwWASm7K4Rp 1oxCtYu1K9vXrFbQAgfggsxaJYt/w6H/2vtlOB8rI5+cLt2AkZhP4kMVR8ba32BRSgqw JosP1NKJu8NYscPTMPVNlbFrTeKIFezk5dyyghKS/O9rOl6oemfKx2skZBEMLRDRLlAf TsHA== X-Forwarded-Encrypted: i=1; AHgh+RrgFmmi71ENQ5K3PRYIoJiC0TXaRH5CpqiyAM/KPahuw6Z/MVPxG7mT9fWPNhUIlP3SqzxiPyihXN8HTSc=@vger.kernel.org X-Gm-Message-State: AOJu0YxN6+Cc5t6S0BdBqxHXGLcBH9gxvNMxHzacTpWZKSpFy3QjbD4D uD0GN0D4QGq1XN6HpbcZWxcE5kMb2gMiMCFOPAN47lHTrqQ2VY7kTRkt X-Gm-Gg: AR+sD12VHr+DZ4lEYC2K++cRRGybqJMJXQqKNjPDhuMguERoBZN6E2Jjs18mgoA/g0T 4LykYbWZW06xq/IdxpZe+eew77RuTC/rzaQ8AiZqVODC+YN+seVnbeD+DClFlQ7TweEg5XNI2F1 RxqNEfL0ClklJOZ0zvKaPG8kQY+VDdPyoW+39iT6a/g0uHrUxg2Hyxp51oQ3Jvrb24ociTETCDi zKdBIC7/RZW34O0cK7gRiHGHZDu85/kS/AaEau546DW75BvbzS1HS9popyr2tYU4LIcE/9o8IIM P86mnsW10YXn8KIKfOed3Sbz0guQrE+jbDJIx6i7mwY0gQpmy4+ZGrHMcsVsFaIwA1vA3mNicas +hfoRysgA7IA/UjWulGi0sSpSNVCk1HcfSOjhJhLRvGd8KOiAKVjjsawH7MAd6oqYhh55VRlNiB vVwdUivjkbAVXXrpmSiS3c3+rdsaVnLfVrvd9e/hqIjxAZiHn6E7n1KaPuKGTHowkD7UPwAw6Gm SwyrelN+h6Fz9PSQz1U+fWYN+i+iFVFe7TEYglt6OsUFey3TyK2uXVIUkhyW4ZbfQ== X-Received: by 2002:a05:6820:f035:b0:6b0:42c3:5524 with SMTP id 006d021491bc7-6b042c36ac3mr11647167eaf.36.1786398274296; Mon, 10 Aug 2026 14:44:34 -0700 (PDT) Received: from mail.marliere.net (137.65.66.34.bc.googleusercontent.com. [34.66.65.137]) by smtp.gmail.com with ESMTPSA id 006d021491bc7-6b02bc2631esm10684691eaf.4.2026.08.10.14.44.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Aug 2026 14:44:33 -0700 (PDT) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id E320A609A3; Mon, 10 Aug 2026 21:44:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marliere.net; s=dkim; t=1786398272; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=2V078lMCX/mS2MTPu9h7Yq1IlSrt9Zb9hUAWqMeTHe8=; b=Fh+IG77xsYlsk5i9VmxWrG4eJBTu3Ywb/C2nf7tQJ4moWpPMWhFRVImXNCajcTU0Ybx1PH s3GykM862+CpdHjIgex8ixPbzK0fnK0HH4hF7xMyq0xmX6JkWnBeRcE7Qw6KtE0u8EwsDo kbJdajDVi71ENQ0d1QwuGsKTlMmqzz3JR+MjtY5dqaEVDJjd09Ybywjhgkvz+RZ239kLsU AYSVg5btF9qJn6kuETDgB6PIULefzDErl5srVpNtqbnTPAwEuBFR67xm7mRPDc6adQA4hP 85pJGz5afvIyRLNZZPIjQ9uVAksgvkjrLrw7OrysGInpJQ9PZGknMaCOkAMj2Q== Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Mon, 10 Aug 2026 18:44:26 -0300 Message-Id: Subject: Re: [PATCH RESEND 1/1] checkpatch: Skip CamelCase cache for --no-tree without root Cc: "Andy Whitcroft" , "Joe Perches" , "Dwaipayan Ray" , "Lukas Bulwahn" , "Cryolitia PukNgae" To: "Petr Vorel" , From: =?utf-8?b?UmljYXJkbyBCLiBNYXJsacOocmUgKFNVU0Up?= X-Mailer: aerc 0.21.0-146-g87073a0460e3-dirty References: <20260810161159.1044160-1-pvorel@suse.cz> In-Reply-To: <20260810161159.1044160-1-pvorel@suse.cz> X-Last-TLS-Session-Version: TLSv1.3 On Mon Aug 10, 2026 at 1:11 PM -03, Petr Vorel wrote: > Running outside tree (--no-tree) without git root (--root DIR) is not > doable because we have no include/ directory which could be cached. But > 3445686af721 expected that we are always in Linux tree (w/a git). > But --no-tree does not require --root. Therefore skip whole caching in > that case. > > This fixes perl and find errors when running checkpatch.pl *with* > --no-tree --strict and *without* --root: > > No structs that should be const will be found - file 'scripts/const_s= tructs.checkpatch': No such file or directory > Use of uninitialized value $root in concatenation (.) or string at sc= ripts/checkpatch.pl line 1213. > find: =E2=80=98/include=E2=80=99: No such file or directory > > Fixes: 3445686af721 ("checkpatch: ignore existing CamelCase uses from inc= lude/...") > Signed-off-by: Petr Vorel > --- > NOTE: I found that running checkpatch.pl on projects which vendored > checkpatch.pl (e.g. LTP or u-boot). > > scripts/checkpatch.pl | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl > index 4f7325fd5825..9ce1113a64de 100755 > --- a/scripts/checkpatch.pl > +++ b/scripts/checkpatch.pl > @@ -1206,6 +1206,8 @@ sub seed_camelcase_includes { > my $git_last_include_commit =3D `${git_command} log --no-merges --pret= ty=3Dformat:"%h%n" -1 -- include`; > chomp $git_last_include_commit; > $camelcase_cache =3D ".checkpatch-camelcase.git.$git_last_include_comm= it"; > + } elsif (not defined $root) { > + return; Reviewed-by: Ricardo B. Marli=C3=A8re (SUSE) > } else { > my $last_mod_date =3D 0; > $files =3D `find $root/include -name "*.h"`;