The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: "Wadim Mueller" <wafgo01@gmail.com>
To: "Maxwell Doose" <maxwell@maxwelld.cc>, "Linmao Li" <lilinmao@kylinos.cn>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
	"David Lechner" <dlechner@baylibre.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: flow: slf3s: restart measurement if VDD disable fails
Date: Tue, 11 Aug 2026 11:48:45 +0200	[thread overview]
Message-ID: <DKM0QN83P2C9.1OHOGCFIUGS4Q@gmail.com> (raw)
In-Reply-To: <DKLOQNAMLRWA.20JM0MR23ECCK@maxwelld.cc>

On Tue Aug 11, 2026 at 2:24 AM CEST, Maxwell Doose wrote:
> On Wed Aug 5, 2026 at 9:21 PM CDT
> Linmao Li <lilinmao@kylinos.cn> wrote:
>
> >
> > One thing I noticed while doing this, not specific to my patch: the
> > datasheets for all three supported variants say that after the stop
> > command the sensor "needs up to 0.5 ms to power down the heater, enter
> > idle mode and be receptive for a new command".  probe() and
> > slf3s_set_medium() both send the next command right away, and my
> > rollback can too.  Is that something you have had to care about in
> >
> > practice?
> >
>
> Perhaps something that would be good to test on actual hardware to see
> if it matters. Maybe Wadim can check? However in all of the (very very
> basic) drivers I've written I've tried my best to account for hardware
> delays so I would do some more research into this.
>
> thanks,
> max

It's definitely a missing piece. I haven't observed any issues with the
current implementation, but the required timing should still be respected.

I'll add the delay in a follow-up patch.

Thanks,
Wadim

  reply	other threads:[~2026-08-11  9:48 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-05 11:02 [PATCH] iio: flow: slf3s: restart measurement if VDD disable fails Linmao Li
2026-08-05 12:59 ` David Lechner
2026-08-06  2:18   ` Linmao Li
2026-08-05 16:45 ` Maxwell Doose
2026-08-06  2:21   ` Linmao Li
2026-08-11  0:24     ` Maxwell Doose
2026-08-11  9:48       ` Wadim Mueller [this message]
2026-08-06  9:39 ` Nuno Sá
2026-08-06 12:55   ` Wadim Mueller
2026-08-06 13:05     ` Nuno Sá

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DKM0QN83P2C9.1OHOGCFIUGS4Q@gmail.com \
    --to=wafgo01@gmail.com \
    --cc=andy@kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=jic23@kernel.org \
    --cc=lilinmao@kylinos.cn \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maxwell@maxwelld.cc \
    --cc=nuno.sa@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox