The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: "Danilo Krummrich" <dakr@kernel.org>
To: "Daniel Almeida" <daniel.almeida@collabora.com>
Cc: "Onur Özkan" <work@onurozkan.dev>,
	linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org,
	dri-devel@lists.freedesktop.org, aliceryhl@google.com,
	airlied@gmail.com, simona@ffwll.ch, ojeda@kernel.org,
	boqun@kernel.org, gary@garyguo.net, bjorn3_gh@protonmail.com,
	lossin@kernel.org, a.hindborg@kernel.org, tmgross@umich.edu
Subject: Re: [PATCH v6 2/3] drm/tyr: add GPU reset infrastructure
Date: Fri, 21 Aug 2026 20:53:41 +0200	[thread overview]
Message-ID: <DKUULBNAMK8L.F52N7AN3QB5M@kernel.org> (raw)
In-Reply-To: <74217098-8793-4701-8292-FBE0DB31FD48@collabora.com>

On Fri Aug 21, 2026 at 7:23 PM CEST, Daniel Almeida wrote:
> I agree, no argument from me there. The problem is, when the GPU is resetting,
> things are far from "working". In fact, things went so bad somewhere that it
> brought the device down for everybody, and the system is taking steps to (try
> to) bring it up again.
>
> As a user, I very much appreciated this when games went down, it made me think
> that the problem was important enough to report, and also likely explained why,
> in that particular hardware, things didn't really work 100% well afterwards,
> which prompted me to reboot the machine.
>
> Two outcomes could have come from that, a) filing a bug on the game itself, and
> b) telling the kernel guys that their reset code wasn't really working 100%
> well either.
>
> I do agree that "Starting GPU reset" is frivolous, but at least a message
> saying that a reset took place, either sucessfully or not, is better than
> silence.

I had a brief look at panthor, and it seems to me that this reset only ever
happens when the hardware is truely malfunctioning. I.e. it never runs under
"normal" error conditions, right?

In that case, I think it's fine. But I'd still rather print where the error
occurs and about the error / recovery condition. The "Starting GPU reset" one
still doesn't seem overly useful to me.

In general, the reset prints should still hint some additional information that
helps to understand the root cause.

  reply	other threads:[~2026-08-21 18:53 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-19 18:45 [PATCH v6 0/3] drm/tyr: GPU reset infrastructure Onur Özkan
2026-08-19 18:45 ` [PATCH v6 1/3] drm/tyr: clear stale IRQ state before soft reset Onur Özkan
2026-08-19 18:45 ` [PATCH v6 2/3] drm/tyr: add GPU reset infrastructure Onur Özkan
2026-08-21 15:31   ` Daniel Almeida
2026-08-21 15:58     ` Onur Özkan
2026-08-21 16:12       ` Danilo Krummrich
2026-08-21 16:39       ` Daniel Almeida
2026-08-21 16:42         ` Onur Özkan
2026-08-21 17:01         ` Danilo Krummrich
2026-08-21 17:23           ` Daniel Almeida
2026-08-21 18:53             ` Danilo Krummrich [this message]
2026-08-19 18:45 ` [PATCH v6 3/3] drm/tyr: put iomem behind the hardware gate Onur Özkan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DKUULBNAMK8L.F52N7AN3QB5M@kernel.org \
    --to=dakr@kernel.org \
    --cc=a.hindborg@kernel.org \
    --cc=airlied@gmail.com \
    --cc=aliceryhl@google.com \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun@kernel.org \
    --cc=daniel.almeida@collabora.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gary@garyguo.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lossin@kernel.org \
    --cc=ojeda@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=simona@ffwll.ch \
    --cc=tmgross@umich.edu \
    --cc=work@onurozkan.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox