The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: "Luca Ceresoli" <luca.ceresoli@bootlin.com>
To: "Doug Anderson" <dianders@chromium.org>,
	"Haoxiang Li" <haoxiang_li2024@163.com>
Cc: <andrzej.hajda@intel.com>, <neil.armstrong@linaro.org>,
	<rfoss@kernel.org>, <Laurent.pinchart@ideasonboard.com>,
	<jonas@kwiboo.se>, <jernej.skrabec@gmail.com>,
	<luca.ceresoli@bootlin.com>, <maarten.lankhorst@linux.intel.com>,
	<mripard@kernel.org>, <tzimmermann@suse.de>, <airlied@gmail.com>,
	<simona@ffwll.ch>, <sam@ravnborg.org>,
	<dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drm/bridge: ti-sn65dsi86: Fix DSI host node reference leak
Date: Wed, 18 Nov 2026 18:23:52 +0100	[thread overview]
Message-ID: <DMYIF16G9BI6.22TYKMLFPA3IM@bootlin.com> (raw)
In-Reply-To: <CAD=FV=WQQyw8_bhVi8Y0JbxXB8XP62ivBPUnfrgWGMcLo7qLtQ@mail.gmail.com>

On Wed Nov 18, 2026 at 5:42 PM CET, Doug Anderson wrote:
> Hi,
>
> On Wed, Nov 18, 2026 at 7:01 AM Haoxiang Li <haoxiang_li2024@163.com> wrote:
>>
>> ti_sn_bridge_parse_dsi_host() acquires a reference to the remote DSI
>> host node with of_graph_get_remote_node(). If ti_sn_attach_host()
>> fails, the probe error path removes the bridge but does not release
>> this reference.
>>
>> Call of_node_put() after removing the bridge in the probe error path.
>>
>> Fixes: c3b75d4734cb ("drm/bridge: sn65dsi86: Register and attach our DSI device at probe")
>> Signed-off-by: Haoxiang Li <haoxiang_li2024@163.com>
>> ---
>>  drivers/gpu/drm/bridge/ti-sn65dsi86.c | 1 +
>>  1 file changed, 1 insertion(+)
>
> Reviewed-by: Douglas Anderson <dianders@chromium.org>

Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
Tested-by: Luca Ceresoli <luca.ceresoli@bootlin.com>

> I'll probably let this sit for a bit and then merge it in a week or
> two. It doesn't seem urgent, so I'd plan to land it in drm-misc-next
> instead of -fixes. If anyone else feels like landing it sooner, feel
> free.

Agreed.

Luca

--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

      reply	other threads:[~2026-11-18 17:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18 15:00 [PATCH] drm/bridge: ti-sn65dsi86: Fix DSI host node reference leak Haoxiang Li
2026-11-18 16:42 ` Doug Anderson
2026-11-18 17:23   ` Luca Ceresoli [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DMYIF16G9BI6.22TYKMLFPA3IM@bootlin.com \
    --to=luca.ceresoli@bootlin.com \
    --cc=Laurent.pinchart@ideasonboard.com \
    --cc=airlied@gmail.com \
    --cc=andrzej.hajda@intel.com \
    --cc=dianders@chromium.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=haoxiang_li2024@163.com \
    --cc=jernej.skrabec@gmail.com \
    --cc=jonas@kwiboo.se \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=rfoss@kernel.org \
    --cc=sam@ravnborg.org \
    --cc=simona@ffwll.ch \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox