The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: "Luca Ceresoli" <luca.ceresoli@bootlin.com>
To: "Daniel Golle" <daniel@makrotopia.org>,
	"Luca Ceresoli" <luca.ceresoli@bootlin.com>
Cc: "Andrzej Hajda" <andrzej.hajda@intel.com>,
	"Neil Armstrong" <neil.armstrong@linaro.org>,
	"Robert Foss" <rfoss@kernel.org>,
	"Laurent Pinchart" <Laurent.pinchart@ideasonboard.com>,
	"Jonas Karlman" <jonas@kwiboo.se>,
	"Jernej Skrabec" <jernej.skrabec@gmail.com>,
	"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
	"Maxime Ripard" <mripard@kernel.org>,
	"Thomas Zimmermann" <tzimmermann@suse.de>,
	"David Airlie" <airlied@gmail.com>,
	"Simona Vetter" <simona@ffwll.ch>,
	"Matthias Brugger" <matthias.bgg@gmail.com>,
	"AngeloGioacchino Del Regno"
	<angelogioacchino.delregno@collabora.com>,
	"Hermes Wu" <hermes.wu@ite.com.tw>,
	"Allen Chen" <allen.chen@ite.com.tw>,
	"Pin-yen Lin" <treapking@chromium.org>,
	"Chen-Yu Tsai" <wenst@chromium.org>,
	<dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-mediatek@lists.infradead.org>
Subject: Re: [PATCH v8 06/14] drm/bridge: it6505: bail out of the IRQ handler when status reads fail
Date: Thu, 19 Nov 2026 18:08:49 +0100	[thread overview]
Message-ID: <DMZCQ276BVDA.2K9ZE12X5VF97@bootlin.com> (raw)
In-Reply-To: <179481904177.211952.7029866729856302771@makrotopia.org>

On Mon Nov 16, 2026 at 9:55 AM CET, Daniel Golle wrote:
> Hi Luca,
>
> On Tue, Oct 20, 2026 at 06:51:39PM +0200, Luca Ceresoli wrote:
>> One first question it whether a read failure is realistic or not, and
>> whether you have experienced it on real hardware.
>
> I have not hit it on hardware. It takes a failing i2c transfer, e.g.
> the chip NACKing while held in reset, which can be provoked through
> the force_power_on_off debugfs knob: it6505_poweroff() only calls
> disable_irq_nosync(), so a running handler keeps reading from a chip
> that is being put into reset.
>
> And hostesly, my interest here is basically getting audio going on
> that Lenovo Ideapad, and for that
>
> https://lore.kernel.org/all/cover.1784561622.git.daniel@makrotopia.org/
>
> is sufficient. The 12 other patches are what Sahsiko has been chasing
> me into, and all the complains it had looked valid and legitimate, so
> I took on writing the fixes for that as well.

Ah, well, I understand.

I had missed the initial history of this series, thanks for the recap!

>> I would consider replacing all the 3 it6505_read() calls with a single
>> regmap_bulk_read(), making error management cleaner.
>>
>> What do you think about this option?
>>
>> Perhaps the three it6505_write() below could also become a bulk write.
>
> Makes sense, INT_STATUS_01..03 are contiguous and the driver already
> uses multi-byte transfers elsewhere. I'll switch to a bulk read and
> write in v9.

Good, thanks!

Luca

--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2026-11-19 17:09 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-27 23:49 [PATCH v8 00/14] drm/bridge: it6505: DP audio support + shared-DAI hw_params fix Daniel Golle
2026-09-27 23:49 ` [PATCH v8 01/14] drm/bridge: it6505: quiesce event sources and work on remove() Daniel Golle
2026-10-20 16:51   ` Luca Ceresoli
2026-09-27 23:49 ` [PATCH v8 02/14] drm/bridge: it6505: quiesce work items before powering off Daniel Golle
2026-10-20 16:51   ` Luca Ceresoli
2026-09-27 23:49 ` [PATCH v8 03/14] drm/bridge: it6505: balance and disable runtime PM on remove Daniel Golle
2026-10-20 16:51   ` Luca Ceresoli
2026-09-27 23:50 ` [PATCH v8 04/14] drm/bridge: it6505: unregister DP AUX adapter on bridge detach Daniel Golle
2026-10-20 16:51   ` Luca Ceresoli
2026-11-16  8:52     ` Daniel Golle
2026-09-27 23:50 ` [PATCH v8 05/14] drm/bridge: it6505: complete poweroff even if disabling regulators fails Daniel Golle
2026-10-20 16:51   ` Luca Ceresoli
2026-09-27 23:50 ` [PATCH v8 06/14] drm/bridge: it6505: bail out of the IRQ handler when status reads fail Daniel Golle
2026-10-20 16:51   ` Luca Ceresoli
2026-11-16  8:55     ` Daniel Golle
2026-11-19 17:08       ` Luca Ceresoli [this message]
2026-09-27 23:50 ` [PATCH v8 07/14] drm/bridge: it6505: avoid division by zero in pixel clock calculation Daniel Golle
2026-10-20 16:51   ` Luca Ceresoli
2026-09-27 23:50 ` [PATCH v8 08/14] drm/bridge: it6505: avoid division by zero in audio FS debug print Daniel Golle
2026-10-20 16:51   ` Luca Ceresoli
2026-11-16  8:56     ` Daniel Golle
2026-11-18  3:12       ` Hermes.Wu
2026-11-19 16:26         ` Daniel Golle
2026-11-19 17:05           ` Luca Ceresoli
2026-09-27 23:50 ` [PATCH v8 09/14] drm/bridge: it6505: guard against zero channel count in audio infoframe Daniel Golle
2026-09-27 23:50 ` [PATCH v8 10/14] drm/bridge: it6505: hold endpoint OF node reference while parsing it Daniel Golle
2026-09-27 23:51 ` [PATCH v8 11/14] drm/bridge: it6505: reject a too short link-frequencies property Daniel Golle
2026-09-27 23:51 ` [PATCH v8 12/14] drm/bridge: it6505: don't write an error code back to the reset register Daniel Golle
2026-09-27 23:51 ` [PATCH v8 13/14] drm/bridge: it6505: Add audio support Daniel Golle
2026-09-27 23:51 ` [PATCH v8 14/14] drm/bridge: it6505: Don't reject audio hw_params without an encoder Daniel Golle
2026-11-14 12:19 ` [PATCH v8 00/14] drm/bridge: it6505: DP audio support + shared-DAI hw_params fix Daniel Golle
2026-11-16  7:22   ` Luca Ceresoli
2026-11-16  9:00     ` Daniel Golle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DMZCQ276BVDA.2K9ZE12X5VF97@bootlin.com \
    --to=luca.ceresoli@bootlin.com \
    --cc=Laurent.pinchart@ideasonboard.com \
    --cc=airlied@gmail.com \
    --cc=allen.chen@ite.com.tw \
    --cc=andrzej.hajda@intel.com \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=daniel@makrotopia.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=hermes.wu@ite.com.tw \
    --cc=jernej.skrabec@gmail.com \
    --cc=jonas@kwiboo.se \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=matthias.bgg@gmail.com \
    --cc=mripard@kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=rfoss@kernel.org \
    --cc=simona@ffwll.ch \
    --cc=treapking@chromium.org \
    --cc=tzimmermann@suse.de \
    --cc=wenst@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox