PATCH: ipfwadm IP accounting (2.4.1)

PATCH: ipfwadm IP accounting (2.4.1)

[Eric Berenguier]

[-- Attachment #1: Type: text/plain, Size: 417 bytes --]

Hello,


Using ipfwadm on a 2.4.1 kernel, some ip accouting rules for outgoing
packets have theirs packet and byte counter stuck to 0 value. There is no
such problem with incoming packets.

For example try this one: ipfwadm -A out -a -W eth0 -S 0/0 -D 0/0

The included patch solves this problem (this was probably a typo).
I've only tested it with ipfwadm and with simple rules like the one above.


Eric Berenguier

[-- Attachment #2: 2.4.1_ipfwadm_ip_acct_out_patch --]
[-- Type: text/plain, Size: 433 bytes --]

--- linux-2.4.1/net/ipv4/netfilter/ip_fw_compat.c	Tue Feb  6 11:10:01
2001
+++ linux/net/ipv4/netfilter/ip_fw_compat.c	Tue Feb  6 09:03:17 2001
@@ -132,7 +132,7 @@
 		if (ret == FW_ACCEPT || ret == FW_SKIP) {
 			if (fwops->fw_acct_out)
 				fwops->fw_acct_out(fwops, PF_INET,
-						   (struct net_device *)in,
+						   (struct net_device *)out,
 						   (*pskb)->nh.raw, &redirpt,
 						   pskb);
 			confirm_connection(*pskb);

[-- Attachment #3: Type: text/plain, Size: 360 bytes --]

--
Eric Berenguier

-----------------------------------------------------------------
                    SYCOMORE Groupe EADS
63 Ter, Av. Edouard Vaillant - 92517 Boulogne-Billancourt Cedex
  Tel. : +33 (0)1 46 08 61 55 - Fax : +33 (0)1 46 08 63 19
                    http://www.sycomore.fr
-----------------------------------------------------------------

Re: PATCH: ipfwadm IP accounting (2.4.1)

[Rusty Russell]

In message <l0310280ab6a59b6a53d3@[172.30.8.86]> you write:
> Using ipfwadm on a 2.4.1 kernel, some ip accouting rules for outgoing
> packets have theirs packet and byte counter stuck to 0 value. There is no
> such problem with incoming packets.

Hi Eric!

You're exactly right: it was a typo.  Thanks.

Linus, please apply.

Rusty.
--- linux-2.4.1/net/ipv4/netfilter/ip_fw_compat.c	Tue Feb  6 11:10:01 2001
+++ linux/net/ipv4/netfilter/ip_fw_compat.c	Tue Feb  6 09:03:17 2001
@@ -132,7 +132,7 @@
 		if (ret == FW_ACCEPT || ret == FW_SKIP) {
 			if (fwops->fw_acct_out)
 				fwops->fw_acct_out(fwops, PF_INET,
-						   (struct net_device *)in,
+						   (struct net_device *)out,
 						   (*pskb)->nh.raw, &redirpt,
 						   pskb);
 			confirm_connection(*pskb);

--
Premature optmztion is rt of all evl. --DK
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/