From: Rusty Russell <rusty@linuxcare.com.au>
To: Pavel Machek <pavel@suse.cz>
Cc: kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Hot swap CPU support for 2.4.1
Date: Mon, 12 Feb 2001 10:05:35 +1100 [thread overview]
Message-ID: <E14S5Ym-0003m4-00@halfway> (raw)
In-Reply-To: Your message of "Sun, 11 Feb 2001 00:29:55 BST." <20010211002955.I7877@bug.ucw.cz>
In message <20010211002955.I7877@bug.ucw.cz> you write:
> This is not quite right:
>
> @@ -1643,7 +1643,7 @@
> printk(KERN_NOTICE "apm: disabled on user
> request.\n");
> return -ENODEV;
> }
> - if ((smp_num_cpus > 1) && !power_off) {
> + if ((num_online_cpus() > 1) && !power_off) {
> printk(KERN_NOTICE "apm: disabled - APM is not SMP
>
> I do not think it is safe to call APM when there is just CPU #5
> running. smp_num_cpus in this context means "if we ever had more than
> boot cpu".
Um, it's not safe to call APM in SMP full stop: we try anyway.
However, this code changes nothing since it's only run at boot.
Cheers,
Rusty.
--
Premature optmztion is rt of all evl. --DK
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2001-02-11 23:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-02-05 4:00 [PATCH] Hot swap CPU support for 2.4.1 Rusty Russell
2001-02-05 5:50 ` Lars Marowsky-Bree
2001-02-05 6:06 ` Anton Blanchard
2001-02-05 21:19 ` [PATCH] Hot swap CPU support for 2.4.1@ lists
2001-02-06 14:17 ` Anton Blanchard
2001-02-10 23:29 ` [PATCH] Hot swap CPU support for 2.4.1 Pavel Machek
2001-02-11 23:05 ` Rusty Russell [this message]
-- strict thread matches above, loose matches on Subject: below --
2001-02-05 4:51 Frank Davis
2001-02-05 6:54 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E14S5Ym-0003m4-00@halfway \
--to=rusty@linuxcare.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox