From: Masaru Kawashima <masaruk@gol.com>
To: moffe@amagerkollegiet.dk
Cc: linux-kernel@vger.kernel.org, jgarzik@mandrakesoft.com,
Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: [PATCH] Re: [MINOR PROBLEM] RTL8139C: transmit timed out
Date: Sat, 14 Jul 2001 03:21:46 +0900 [thread overview]
Message-ID: <E15L7Zp-0006k9-00@smtp01.fields.gol.com> (raw)
In-Reply-To: <Pine.LNX.4.33.0107122043350.1097-100000@grignard.amagerkollegiet.dk>
In-Reply-To: <Pine.LNX.4.33.0107122043350.1097-100000@grignard.amagerkollegiet.dk>
[-- Attachment #1: Type: text/plain, Size: 277 bytes --]
Hi!
> Jul 12 20:36:43 wiibroe kernel: NETDEV WATCHDOG: eth0: transmit timed out
I had the same problem with linux-2.4.6-ac2, and I found a bug
in the function rtl8139_start_xmit() of 8139too.c.
Attached patch will fix this bug.
Enjoy!
--
Masaru Kawashima <masaruk@gol.com>
[-- Attachment #2: 8139too.patch --]
[-- Type: text/plain, Size: 602 bytes --]
--- drivers/net/8139too.c.orig Wed Jul 4 14:34:27 2001
+++ drivers/net/8139too.c Sat Jul 14 02:34:50 2001
@@ -1732,7 +1732,6 @@
RTL_W32_F (TxAddr0 + (entry * 4), dma_addr);
RTL_W32_F (TxStatus0 + (entry * sizeof (u32)),
tp->tx_flag | (skb->len >= ETH_ZLEN ? skb->len : ETH_ZLEN));
- spin_unlock_irq(&tp->lock);
dev->trans_start = jiffies;
@@ -1740,6 +1739,7 @@
mb();
if ((tp->cur_tx - NUM_TX_DESC) == tp->dirty_tx)
netif_stop_queue (dev);
+ spin_unlock_irq(&tp->lock);
DPRINTK ("%s: Queued Tx packet at %p size %u to slot %d.\n",
dev->name, skb->data, skb->len, entry);
next prev parent reply other threads:[~2001-07-13 18:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-07-12 19:11 [MINOR PROBLEM] RTL8139C: transmit timed out Rasmus Bøg Hansen
2001-07-13 18:21 ` Masaru Kawashima [this message]
2001-07-13 22:06 ` [PATCH] " Rasmus Bøg Hansen
2001-07-20 9:03 ` Rasmus Bøg Hansen
2001-07-20 15:15 ` Masaru Kawashima
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E15L7Zp-0006k9-00@smtp01.fields.gol.com \
--to=masaruk@gol.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=jgarzik@mandrakesoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=moffe@amagerkollegiet.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox