From: Rusty Russell <rusty@rustcorp.com.au>
To: torvalds@transmeta.com
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] 2.4 vsnprintf fix.
Date: Thu, 20 Sep 2001 21:29:05 +1000 [thread overview]
Message-ID: <E15k20v-00008w-00@wagner> (raw)
Following patch fixes calling vsnprintf with (NULL, 0) to get the
length of the string. The problem is that the end ptr is set to
0xFFFFFFFF in this case, causing a write into address 0 as start <
end.
Cheers,
Rusty.
--
Premature optmztion is rt of all evl. --DK
--- working-pmac-module/lib/vsprintf.c.~1~ Mon Sep 17 08:53:56 2001
+++ working-pmac-module/lib/vsprintf.c Thu Sep 20 21:26:05 2001
@@ -246,6 +246,8 @@
/* 'z' support added 23/7/1999 S.H. */
/* 'z' changed to 'Z' --davidm 1/25/99 */
+ /* buf = NULL, size = 0 is common for getting length */
+ if (size == 0) buf = (void *)1;
str = buf;
end = buf + size - 1;
next reply other threads:[~2001-09-20 11:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-09-20 11:29 Rusty Russell [this message]
2001-09-21 19:26 ` [PATCH] 2.4 vsnprintf fix Crutcher Dunnavant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E15k20v-00008w-00@wagner \
--to=rusty@rustcorp.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox