From: Rusty Russell <rusty@rustcorp.com.au>
To: Richard Gooch <rgooch@ras.ucalgary.ca>
Cc: linux-kernel@vger.kernel.org
Subject: Re: bit ops on unsigned long?
Date: Mon, 25 Mar 2002 18:07:07 +1100 [thread overview]
Message-ID: <E16pOZP-00043F-00@wagner.rustcorp.com.au> (raw)
In-Reply-To: Your message of "Sun, 24 Mar 2002 23:21:16 PDT." <200203250621.g2P6LG023329@vindaloo.ras.ucalgary.ca>
In message <200203250621.g2P6LG023329@vindaloo.ras.ucalgary.ca> you write:
> > These changed are required because otherwise you try to do set_bit on
> > something not aligned as a long on all archs.
>
> But of course. I'm not denying that. Naturally the type should be
> changed. I thought that was obvious so I didn't bother agreeing. But
> in fact, it already *is* aligned on a long boundary. Better, in
> fact. It's aligned on a 16 byte boundary. Even though the type was
> __u32.
I'm confused:
@@ -212,7 +212,7 @@
struct minor_list
{
int major;
- __u32 bits[8];
+ unsigned long bits[256 / BITS_PER_LONG];
struct minor_list *next;
};
How, exactly, did "bits" end up on a 16-bute boundary before this
patch?
Rusty.
--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
next prev parent reply other threads:[~2002-03-25 7:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-03-16 0:52 bit ops on unsigned long? Rusty Russell
2002-03-16 0:58 ` Linus Torvalds
2002-03-16 3:08 ` Rusty Russell
2002-03-18 4:08 ` David S. Miller
2002-03-18 6:03 ` Jeff Garzik
2002-03-18 6:43 ` David S. Miller
2002-03-18 9:13 ` Rusty Russell
2002-03-25 2:45 ` Richard Gooch
2002-03-25 4:27 ` Rusty Russell
2002-03-25 6:21 ` Richard Gooch
2002-03-25 7:07 ` Rusty Russell [this message]
2002-03-25 7:12 ` Richard Gooch
2002-03-16 1:00 ` Anton Blanchard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E16pOZP-00043F-00@wagner.rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=rgooch@ras.ucalgary.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox