From: Rusty Russell <rusty@rustcorp.com.au>
To: Benjamin LaHaise <bcrl@redhat.com>
Cc: torvalds@transmeta.com, linux-kernel@vger.kernel.org, akpm@zip.com.au
Subject: Re: [PATCH] XBUG(comment) BUG enhancement
Date: Fri, 24 May 2002 17:19:51 +1000 [thread overview]
Message-ID: <E17B9Me-00019p-00@wagner.rustcorp.com.au> (raw)
In-Reply-To: Your message of "Fri, 24 May 2002 02:49:06 -0400." <20020524024906.A1547@redhat.com>
In message <20020524024906.A1547@redhat.com> you write:
> On Fri, May 24, 2002 at 03:24:30PM +1000, Rusty Russell wrote:
> > __asm__ __volatile__( "ud2\n" \
> > - "\t.word %c0\n" \
> > + "\t.long %c0\n" \
> > "\t.long %c1\n" \
> > - : : "i" (__LINE__), "i" (__FILE__))
> > + : : "i" (__stringify(__LINE__)), "i" (__FILE__))
>
> This part I can't agree with: changing the line number to a string
> results in excess pollution of the data segment with useless strings
> that are frequently duplicates. Why not leave it as a number?
To unify the trap handler to handle both cases. If you really think
this is unacceptable bloat, please measure the difference, then use
line number zero or something for XBUG and place the comment string at
in a third .long.
But I was lazy, and this was tested...
Rusty.
--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
next prev parent reply other threads:[~2002-05-24 7:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-05-24 5:24 [PATCH] XBUG(comment) BUG enhancement Rusty Russell
2002-05-24 6:49 ` Benjamin LaHaise
2002-05-24 7:19 ` Rusty Russell [this message]
2002-05-24 15:01 ` Kai Germaschewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E17B9Me-00019p-00@wagner.rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=akpm@zip.com.au \
--cc=bcrl@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox