From: Brian Murphy <brm@murphy.dk>
To: linux-kernel@vger.kernel.org
Cc: linus@transmeta.com
Subject: [PATCH 2.5] invalid irqs accepted in serial pci driver
Date: Mon, 04 Nov 2002 22:13:47 +0100 [thread overview]
Message-ID: <E188oXb-0004Hi-00@brian.localnet> (raw)
Hi,
the pci serial driver should not allow the configuration of
devices which return an irq of 255 - it is illegal according to the
standard and means the device has not had an irq configured.
The patch adds rejection of these invalid devices.
/Brian
--- drivers/serial/8250_pci.c 1 Nov 2002 23:26:57 -0000 1.4
+++ drivers/serial/8250_pci.c 4 Nov 2002 21:05:31 -0000
@@ -735,6 +735,9 @@
memset(&serial_req, 0, sizeof(serial_req));
for (k = 0; k < board->num_ports; k++) {
serial_req.irq = get_pci_irq(dev, board, k);
+ if (serial_req.irq == 255)
+ /* not initialised */
+ break;
if (get_pci_port(dev, board, &serial_req, k))
break;
#ifdef SERIAL_DEBUG_PCI
reply other threads:[~2002-11-04 21:07 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E188oXb-0004Hi-00@brian.localnet \
--to=brm@murphy.dk \
--cc=linus@transmeta.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox