public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH 2.5] invalid irqs accepted in serial pci driver
@ 2002-11-04 21:13 Brian Murphy
  0 siblings, 0 replies; only message in thread
From: Brian Murphy @ 2002-11-04 21:13 UTC (permalink / raw)
  To: linux-kernel; +Cc: linus

Hi,
	the pci serial driver should not allow the configuration of 
devices which return an irq of 255 - it is illegal according to the 
standard and means the device has not had an irq configured.

The patch adds rejection of these invalid devices.

/Brian

--- drivers/serial/8250_pci.c	1 Nov 2002 23:26:57 -0000	1.4
+++ drivers/serial/8250_pci.c	4 Nov 2002 21:05:31 -0000
@@ -735,6 +735,9 @@
 	memset(&serial_req, 0, sizeof(serial_req));
 	for (k = 0; k < board->num_ports; k++) {
 		serial_req.irq = get_pci_irq(dev, board, k);
+		if (serial_req.irq == 255)
+			/* not initialised */
+			break;
 		if (get_pci_port(dev, board, &serial_req, k))
 			break;
 #ifdef SERIAL_DEBUG_PCI

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2002-11-04 21:07 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2002-11-04 21:13 [PATCH 2.5] invalid irqs accepted in serial pci driver Brian Murphy

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox