public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [patch 08/14]  radio/miropcm20-rds: replace  schedule_timeout() with msleep()
@ 2004-09-01 23:16 janitor
  0 siblings, 0 replies; only message in thread
From: janitor @ 2004-09-01 23:16 UTC (permalink / raw)
  To: akpm; +Cc: linux-kernel, janitor







I would appreciate any comments from the janitor@sternweltens list.

Thanks,
Nish



Description: Uses msleep() instead of schedule_timeout() so the task
is guaranteed to delay the desired time.

Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
Signed-off-by: Maximilian Attems <janitor@sternwelten.at>



---

 linux-2.6.9-rc1-bk7-max/drivers/media/radio/miropcm20-rds.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff -puN drivers/media/radio/miropcm20-rds.c~msleep-drivers_media_radio-miropcm20-rds drivers/media/radio/miropcm20-rds.c
--- linux-2.6.9-rc1-bk7/drivers/media/radio/miropcm20-rds.c~msleep-drivers_media_radio-miropcm20-rds	2004-09-01 19:35:12.000000000 +0200
+++ linux-2.6.9-rc1-bk7-max/drivers/media/radio/miropcm20-rds.c	2004-09-01 19:35:12.000000000 +0200
@@ -14,6 +14,7 @@
 #include <linux/slab.h>
 #include <linux/fs.h>
 #include <linux/miscdevice.h>
+#include <linux/delay.h>
 #include <asm/uaccess.h>
 #include "miropcm20-rds-core.h"
 
@@ -60,8 +61,7 @@ static ssize_t rds_f_read(struct file *f
 	char c;
 	char bits[8];
 
-	current->state=TASK_UNINTERRUPTIBLE;
-	schedule_timeout(2*HZ);
+	msleep(2000);
 	aci_rds_cmd(RDS_STATUS, &c, 1);
 	print_matrix(&c, bits);
 	if (copy_to_user(buffer, bits, 8))

_

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2004-09-01 23:21 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-09-01 23:16 [patch 08/14] radio/miropcm20-rds: replace schedule_timeout() with msleep() janitor

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox