From: janitor@sternwelten.at
To: akpm@osdl.org
Cc: linux-kernel@vger.kernel.org, janitor@sternwelten.at
Subject: [patch 13/14] message/i2o_core: replace schedule_timeout() with msleep()
Date: Thu, 02 Sep 2004 01:16:50 +0200 [thread overview]
Message-ID: <E1C2eLS-0002tZ-Jd@sputnik> (raw)
I would appreciate any comments from the janitor@sternweltens list.
Thanks,
Nish
Description: Uses msleep() instead of schedule_timeout() so the task
is guaranteed to delay the desired time.
Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
Signed-off-by: Maximilian Attems <janitor@sternwelten.at>
Looks good to me, please forward to Linus to apply.
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
---
linux-2.6.9-rc1-bk7-max/drivers/message/i2o/i2o_core.c | 3 +--
1 files changed, 1 insertion(+), 2 deletions(-)
diff -puN drivers/message/i2o/i2o_core.c~msleep-drivers_message_i2o_i2o_core drivers/message/i2o/i2o_core.c
--- linux-2.6.9-rc1-bk7/drivers/message/i2o/i2o_core.c~msleep-drivers_message_i2o_i2o_core 2004-09-01 19:35:24.000000000 +0200
+++ linux-2.6.9-rc1-bk7-max/drivers/message/i2o/i2o_core.c 2004-09-01 19:35:24.000000000 +0200
@@ -892,8 +892,7 @@ int i2o_release_device(struct i2o_device
if((err=i2o_issue_claim(I2O_CMD_UTIL_RELEASE, d->controller, d->lct_data.tid, I2O_CLAIM_PRIMARY)) )
{
err = -ENXIO;
- current->state = TASK_UNINTERRUPTIBLE;
- schedule_timeout(HZ);
+ msleep(1000);
}
else
{
_
reply other threads:[~2004-09-02 0:11 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1C2eLS-0002tZ-Jd@sputnik \
--to=janitor@sternwelten.at \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox