public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [patch 4/4]  mmc: replace schedule_timeout()  with msleep_interruptible()
@ 2004-09-23 20:49 janitor
  2004-09-29 13:44 ` Russell King
  0 siblings, 1 reply; 2+ messages in thread
From: janitor @ 2004-09-23 20:49 UTC (permalink / raw)
  To: akpm; +Cc: linux-kernel, janitor, nacc




Any comments would be appreciated.

Description: Use msleep_interruptible() instead of schedule_timeout()
to guarantee the task delays as expected.

Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>

Signed-off-by: Maximilian Attems <janitor@sternwelten.at>
---

 linux-2.6.9-rc2-bk7-max/drivers/mmc/mmc.c |    3 +--
 1 files changed, 1 insertion(+), 2 deletions(-)

diff -puN drivers/mmc/mmc.c~msleep_interruptible-drivers_mmc_mmc drivers/mmc/mmc.c
--- linux-2.6.9-rc2-bk7/drivers/mmc/mmc.c~msleep_interruptible-drivers_mmc_mmc	2004-09-21 21:17:16.000000000 +0200
+++ linux-2.6.9-rc2-bk7-max/drivers/mmc/mmc.c	2004-09-21 21:17:16.000000000 +0200
@@ -270,8 +270,7 @@ static inline void mmc_delay(unsigned in
 		yield();
 		mdelay(ms);
 	} else {
-		set_current_state(TASK_INTERRUPTIBLE);
-		schedule_timeout(ms * HZ / 1000);
+		msleep_interruptible (ms);
 	}
 }
 
_

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [patch 4/4]  mmc: replace schedule_timeout()  with msleep_interruptible()
  2004-09-23 20:49 [patch 4/4] mmc: replace schedule_timeout() with msleep_interruptible() janitor
@ 2004-09-29 13:44 ` Russell King
  0 siblings, 0 replies; 2+ messages in thread
From: Russell King @ 2004-09-29 13:44 UTC (permalink / raw)
  To: janitor; +Cc: akpm, linux-kernel, nacc

On Thu, Sep 23, 2004 at 10:49:10PM +0200, janitor@sternwelten.at wrote:
> Description: Use msleep_interruptible() instead of schedule_timeout()
> to guarantee the task delays as expected.

Applied, thanks.

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 PCMCIA      - http://pcmcia.arm.linux.org.uk/
                 2.6 Serial core

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2004-09-29 13:58 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-09-23 20:49 [patch 4/4] mmc: replace schedule_timeout() with msleep_interruptible() janitor
2004-09-29 13:44 ` Russell King

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox