From: janitor@sternwelten.at
To: akpm@digeo.com
Cc: linux-kernel@vger.kernel.org, janitor@sternwelten.at, drizzd@aon.at
Subject: [patch 2/3] __FUNCTION__ string concatenation
Date: Thu, 23 Sep 2004 23:22:43 +0200 [thread overview]
Message-ID: <E1CAb35-0005sn-Il@sputnik> (raw)
I've replaced the __FUNCTION__ string concatenation with the
%s placeholder and a printf parameter in
drivers/net/wireless/prism65/islpci_mgt.h, as suggested in the TODO
list.
I don't have the hardware to do a run-time check. It should not pose any
problems though.
# This is a BitKeeper generated diff -Nru style patch.
#
# ChangeSet
# 2004/07/04 22:08:37+02:00 drizzd@aon.at
# __FUNCTION__ string concatenation is deprecated
#
# drivers/net/wireless/prism54/islpci_mgt.h
# 2004/07/03 17:18:20+02:00 drizzd@aon.at +1 -1
# __FUNCTION__ string concatenation is deprecated
#
Signed-off-by: Maximilian Attems <janitor@sternwelten.at>
---
linux-2.6.9-rc2-bk7-max/drivers/net/wireless/prism54/islpci_mgt.h | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
diff -puN drivers/net/wireless/prism54/islpci_mgt.h~printk-net_wireless_prism54_islpci_mgt.h drivers/net/wireless/prism54/islpci_mgt.h
--- linux-2.6.9-rc2-bk7/drivers/net/wireless/prism54/islpci_mgt.h~printk-net_wireless_prism54_islpci_mgt.h 2004-09-21 20:47:57.000000000 +0200
+++ linux-2.6.9-rc2-bk7-max/drivers/net/wireless/prism54/islpci_mgt.h 2004-09-21 20:47:57.000000000 +0200
@@ -31,7 +31,7 @@
#define K_DEBUG(f, m, args...) do { if(f & m) printk(KERN_DEBUG args); } while(0)
#define DEBUG(f, args...) K_DEBUG(f, pc_debug, args)
-#define TRACE(devname) K_DEBUG(SHOW_TRACING, VERBOSE, "%s: -> " __FUNCTION__ "()\n", devname)
+#define TRACE(devname) K_DEBUG(SHOW_TRACING, VERBOSE, "%s: -> %s()\n", devname, __FUNCTION__)
extern int pc_debug;
#define init_wds 0 /* help compiler optimize away dead code */
_
next reply other threads:[~2004-09-23 21:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-23 21:22 janitor [this message]
2004-09-23 21:24 ` [patch 2/3] __FUNCTION__ string concatenation maximilian attems
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1CAb35-0005sn-Il@sputnik \
--to=janitor@sternwelten.at \
--cc=akpm@digeo.com \
--cc=drizzd@aon.at \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox