From: janitor@sternwelten.at
To: rmk+lkml@arm.linux.org.uk
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org,
janitor@sternwelten.at, nacc@us.ibm.com
Subject: [patch 3/8] serial/pmac_zilog: replace schedule_timeout() with msleep()
Date: Sun, 31 Oct 2004 00:47:05 +0200 [thread overview]
Message-ID: <E1CO202-00030e-8U@sputnik> (raw)
Any comments would be appreciated.
Description: Use msleep() instead of schedule_timeout() to
guarantee the task delays as expected.
Signed-off-by: Maximilian Attems <janitor@sternwelten.at>
---
linux-2.6.10-rc1-max/drivers/serial/pmac_zilog.c | 6 ++----
1 files changed, 2 insertions(+), 4 deletions(-)
diff -puN drivers/serial/pmac_zilog.c~msleep-drivers_serial_pmac_zilog drivers/serial/pmac_zilog.c
--- linux-2.6.10-rc1/drivers/serial/pmac_zilog.c~msleep-drivers_serial_pmac_zilog 2004-10-24 17:05:09.000000000 +0200
+++ linux-2.6.10-rc1-max/drivers/serial/pmac_zilog.c 2004-10-24 17:05:09.000000000 +0200
@@ -949,8 +949,7 @@ static int pmz_startup(struct uart_port
*/
if (pwr_delay != 0) {
pmz_debug("pmz: delaying %d ms\n", pwr_delay);
- set_current_state(TASK_UNINTERRUPTIBLE);
- schedule_timeout((pwr_delay * HZ)/1000);
+ msleep(pwr_delay);
}
/* IrDA reset is done now */
@@ -1684,8 +1683,7 @@ static int pmz_resume(struct macio_dev *
*/
if (pwr_delay != 0) {
pmz_debug("pmz: delaying %d ms\n", pwr_delay);
- set_current_state(TASK_UNINTERRUPTIBLE);
- schedule_timeout((pwr_delay * HZ)/1000);
+ msleep(pwr_delay);
}
pmz_debug("resume, switching complete\n");
_
next reply other threads:[~2004-10-30 22:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-30 22:47 janitor [this message]
2004-11-01 12:35 ` [patch 3/8] serial/pmac_zilog: replace schedule_timeout() with msleep() Russell King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1CO202-00030e-8U@sputnik \
--to=janitor@sternwelten.at \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nacc@us.ibm.com \
--cc=rmk+lkml@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox