From: Miklos Szeredi <miklos@szeredi.hu>
To: akpm@osdl.org
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] FUSE: disable sendfile with direct_io
Date: Sun, 24 Apr 2005 17:50:40 +0200 [thread overview]
Message-ID: <E1DPjNY-0000PZ-00@localhost> (raw)
In case a filesystem is mounted with "direct_io", sendfile should not
use the generic function, but return an error instead. The generic
sendfile uses the page cache, which could return stale data.
Signed-off-by: Miklos Szeredi <miklos@szeredi.hu>
diff -rup linux-2.6.12-rc2-mm3/fs/fuse/file.c linux-fuse/fs/fuse/file.c
--- linux-2.6.12-rc2-mm3/fs/fuse/file.c 2005-04-24 17:41:47.000000000 +0200
+++ linux-fuse/fs/fuse/file.c 2005-04-24 17:42:53.000000000 +0200
@@ -531,6 +531,17 @@ static int fuse_file_mmap(struct file *f
return generic_file_mmap(file, vma);
}
+static ssize_t fuse_file_sendfile(struct file *file, loff_t *ppos,
+ size_t count, read_actor_t actor,
+ void *target)
+{
+ struct fuse_conn *fc = get_fuse_conn(file->f_dentry->d_inode);
+ if (fc->flags & FUSE_DIRECT_IO)
+ return -EINVAL;
+ else
+ return generic_file_sendfile(file, ppos, count, actor, target);
+}
+
static int fuse_set_page_dirty(struct page *page)
{
printk("fuse_set_page_dirty: should not happen\n");
@@ -547,7 +558,7 @@ static struct file_operations fuse_file_
.flush = fuse_flush,
.release = fuse_release,
.fsync = fuse_fsync,
- .sendfile = generic_file_sendfile,
+ .sendfile = fuse_file_sendfile,
};
static struct address_space_operations fuse_file_aops = {
reply other threads:[~2005-04-24 15:51 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1DPjNY-0000PZ-00@localhost \
--to=miklos@szeredi.hu \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox