From: Matthew Wilcox <matthew@wil.cx>
To: Linus Torvalds <torvalds@osdl.org>, Andrew Morton <akpm@osdl.org>
Cc: Matthew Wilcox <matthew@wil.cx>, Ingo Molnar <mingo@elte.hu>,
linux-kernel@vger.kernel.org, Russell King <rmk@arm.linux.org.uk>,
Ian Molton <spyro@f2s.com>, David Howells <dhowells@redhat.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>
Subject: [PATCH 4/5] Centralise NO_IRQ definition
Date: Sun, 20 Nov 2005 20:14:08 -0500 [thread overview]
Message-ID: <E1Ee0G0-0004CN-Az@localhost.localdomain> (raw)
Move the definition of NO_IRQ from asm directories to <linux/hardirq.h>.
All existing definitions were already -1.
Signed-off-by: Matthew Wilcox <matthew@wil.cx>
Acked-by: Ingo Molnar <mingo@elte.hu>
---
include/asm-arm/irq.h | 8 --------
include/asm-arm26/irq.h | 8 --------
include/asm-frv/irq.h | 3 ---
include/asm-parisc/irq.h | 2 --
include/asm-powerpc/irq.h | 3 ---
include/linux/hardirq.h | 8 ++++++++
6 files changed, 8 insertions(+), 24 deletions(-)
applies-to: c2fd3b28a74be2ae6274c85c7a9538c7bf1dd949
604c0538936822cbb1c0958f0f835cbbaf723530
diff --git a/include/asm-arm/irq.h b/include/asm-arm/irq.h
index 59975ee..0545e36 100644
--- a/include/asm-arm/irq.h
+++ b/include/asm-arm/irq.h
@@ -11,14 +11,6 @@
#define NR_IRQS 128
#endif
-/*
- * Use this value to indicate lack of interrupt
- * capability
- */
-#ifndef NO_IRQ
-#define NO_IRQ ((unsigned int)(-1))
-#endif
-
struct irqaction;
extern void disable_irq_nosync(unsigned int);
diff --git a/include/asm-arm26/irq.h b/include/asm-arm26/irq.h
index 06bd5a5..7957d4e 100644
--- a/include/asm-arm26/irq.h
+++ b/include/asm-arm26/irq.h
@@ -14,14 +14,6 @@
#endif
-/*
- * Use this value to indicate lack of interrupt
- * capability
- */
-#ifndef NO_IRQ
-#define NO_IRQ ((unsigned int)(-1))
-#endif
-
struct irqaction;
#define disable_irq_nosync(i) disable_irq(i)
diff --git a/include/asm-frv/irq.h b/include/asm-frv/irq.h
index 2c16d8d..fbc5bd7 100644
--- a/include/asm-frv/irq.h
+++ b/include/asm-frv/irq.h
@@ -20,9 +20,6 @@
* drivers
*/
-/* this number is used when no interrupt has been assigned */
-#define NO_IRQ (-1)
-
#define NR_IRQ_LOG2_ACTIONS_PER_GROUP 5
#define NR_IRQ_ACTIONS_PER_GROUP (1 << NR_IRQ_LOG2_ACTIONS_PER_GROUP)
#define NR_IRQ_GROUPS 4
diff --git a/include/asm-parisc/irq.h b/include/asm-parisc/irq.h
index b0a30e2..26ab3be 100644
--- a/include/asm-parisc/irq.h
+++ b/include/asm-parisc/irq.h
@@ -11,8 +11,6 @@
#include <linux/cpumask.h>
#include <asm/types.h>
-#define NO_IRQ (-1)
-
#ifdef CONFIG_GSC
#define GSC_IRQ_BASE 16
#define GSC_IRQ_MAX 63
diff --git a/include/asm-powerpc/irq.h b/include/asm-powerpc/irq.h
index 8eb7e85..1b41206 100644
--- a/include/asm-powerpc/irq.h
+++ b/include/asm-powerpc/irq.h
@@ -15,9 +15,6 @@
#include <asm/types.h>
#include <asm/atomic.h>
-/* this number is used when no interrupt has been assigned */
-#define NO_IRQ (-1)
-
/*
* These constants are used for passing information about interrupt
* signal polarity and level/edge sensing to the low-level PIC chip
diff --git a/include/linux/hardirq.h b/include/linux/hardirq.h
index 71d2b8a..9ee4946 100644
--- a/include/linux/hardirq.h
+++ b/include/linux/hardirq.h
@@ -87,6 +87,14 @@ extern void synchronize_irq(unsigned int
# define synchronize_irq(irq) barrier()
#endif
+/*
+ * This value means "Device has no interrupt". For most pieces of code,
+ * any value above NR_IRQS would do, but -1 is traditional. The PCI
+ * subsystem currently uses 0, but that's a legal IRQ number on some
+ * architectures.
+ */
+#define NO_IRQ ((unsigned int)(-1))
+
#define nmi_enter() irq_enter()
#define nmi_exit() sub_preempt_count(HARDIRQ_OFFSET)
---
0.99.8.GIT
next reply other threads:[~2005-11-21 1:14 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-21 1:14 Matthew Wilcox [this message]
2005-11-21 11:12 ` [PATCH 4/5] Centralise NO_IRQ definition David Howells
2005-11-21 12:14 ` Matthew Wilcox
2005-11-21 18:55 ` Linus Torvalds
2005-11-21 19:06 ` Matthew Wilcox
2005-11-21 19:27 ` Linus Torvalds
2005-11-21 19:43 ` Matthew Wilcox
2005-11-21 19:59 ` Linus Torvalds
2005-11-21 21:15 ` Ingo Molnar
2005-11-21 21:25 ` Paul Mackerras
2005-11-21 21:35 ` Ingo Molnar
2005-11-21 21:51 ` Linus Torvalds
2005-11-21 22:09 ` Benjamin Herrenschmidt
2005-11-21 22:34 ` Linus Torvalds
2005-11-21 23:00 ` Benjamin Herrenschmidt
2005-11-21 21:49 ` Linus Torvalds
2005-11-21 22:06 ` Benjamin Herrenschmidt
2005-11-21 22:28 ` Linus Torvalds
2005-11-21 22:58 ` Benjamin Herrenschmidt
2005-11-21 23:20 ` Paul Mackerras
2005-11-22 1:26 ` Linus Torvalds
2005-11-22 2:45 ` Matthew Wilcox
2005-11-21 21:50 ` Benjamin Herrenschmidt
2005-11-21 22:20 ` Alan Cox
2005-11-22 11:13 ` David Woodhouse
2005-11-22 14:15 ` Alan Cox
2005-11-22 14:04 ` Matthew Wilcox
2005-11-22 17:03 ` Linus Torvalds
2005-11-22 18:20 ` Matthew Wilcox
2005-11-22 18:37 ` David Howells
2005-11-22 19:03 ` David Woodhouse
2005-11-22 19:21 ` Linus Torvalds
2005-11-22 23:58 ` David Woodhouse
2005-11-22 19:05 ` Linus Torvalds
2005-11-22 19:38 ` David Howells
2005-11-22 19:51 ` Linus Torvalds
2005-11-23 1:45 ` Pavel Machek
2005-11-21 21:16 ` Benjamin Herrenschmidt
2005-11-21 21:38 ` Linus Torvalds
2005-11-21 21:53 ` Benjamin Herrenschmidt
2005-11-21 22:18 ` Linus Torvalds
2005-11-21 22:20 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1Ee0G0-0004CN-Az@localhost.localdomain \
--to=matthew@wil.cx \
--cc=akpm@osdl.org \
--cc=benh@kernel.crashing.org \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=rmk@arm.linux.org.uk \
--cc=spyro@f2s.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox