Re: [PATCH 04/36] m68k: switch mac/misc.c to direct use of appropriate cuda/pmu/maciisi requests

Geert Uytterhoeven
2005-12-22T08:40:44Z

On Thu, 22 Dec 2005, Al Viro wrote:
> From: Al Viro <viro@zeniv.linux.org.uk>
> Date: 1134918770 -0500
>
> kill ADBREQ_RAW use, replace adb_read_time(), etc. with per-type variants,
> eliminated remapping from pmu ones, fix the ifdefs (PMU->PMU68K)
>
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

> + switch(macintosh_config->adb_type) {
> + case MAC_ADB_IISI:
> + func = maciisi_read_pram; break;
> + case MAC_ADB_PB1:
> + case MAC_ADB_PB2:
> + func = pmu_read_pram; break;
> + case MAC_ADB_CUDA:
> + func = cuda_read_pram; break;
> + default:
> func = via_read_pram;
> }

Wouldn't it be better to just have an ops structure with function pointers and
data fields, so we just have to initialize that once, instead of having `switch
(macintosh_config->adb_type) { ...}' in multiple places?

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds