From: hooanon05@yahoo.co.jp
To: Josef Sipek <jsipek@fsl.cs.sunysb.edu>
Cc: Pekka Enberg <penberg@cs.helsinki.fi>,
Andrew Morton <akpm@linux-foundation.org>,
unionfs@filesystems.org, linux-kernel@vger.kernel.org,
Adrian Bunk <bunk@stusta.de>
Subject: Re: [Unionfs] Re: [-mm patch] UNION_FS must depend on SLAB
Date: Wed, 21 Feb 2007 12:07:27 +0900 [thread overview]
Message-ID: <E1HJhpH-0000fR-4w@jroun> (raw)
In-Reply-To: <20070220151356.GA19239@filer.fsl.cs.sunysb.edu>
Josef Sipek:
> That's the only user of malloc_sizes. It is supposed to be an optimization -
> we get the smallest sized piece of memory even if we don't need all of it.
> This way we don't reallocate & memcpy needlessly.
How about exporting ksize to modules, and introduce a new function such
like this?
Of course, adding gfp_t to its parameter list make this function more generic.
void *kzrealloc(void *p, int nused, int new_sz)
{
void *q;
if (new_sz <= nused)
return p;
if (new_sz <= ksize(p)) {
memset(p + nused, 0, new_sz - nused);
return p;
}
q = kmalloc(new_sz, GFP_KERNEL);
if (unlikely(!q))
return NULL;
memcpy(q, p, nused);
memset(q + nused, 0, new_sz - nused);
kfree(p);
return q;
}
Junjiro Okajima
next prev parent reply other threads:[~2007-02-21 3:55 UTC|newest]
Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-18 5:51 2.6.20-mm2 Andrew Morton
2007-02-18 6:18 ` 2.6.20-mm2 Dave Airlie
2007-02-18 6:34 ` 2.6.20-mm2 Andrew Morton
2007-02-18 12:44 ` 2.6.20-mm2 Rafael J. Wysocki
2007-02-18 19:43 ` 2.6.20-mm2 Andrew Morton
2007-02-18 23:25 ` 2.6.20-mm2 Rafael J. Wysocki
2007-02-18 23:39 ` 2.6.20-mm2 Michal Piotrowski
2007-02-19 0:00 ` 2.6.20-mm2 Andrew Morton
2007-02-19 11:28 ` 2.6.20-mm2 Rafael J. Wysocki
2007-02-19 11:45 ` 2.6.20-mm2 Michal Piotrowski
2007-02-20 0:04 ` 2.6.20-mm2 Rafael J. Wysocki
2007-02-20 21:16 ` 2.6.20-mm2 Rafael J. Wysocki
2007-02-20 21:46 ` 2.6.20-mm2 Jeff Garzik
2007-02-20 0:43 ` 2.6.20-mm2 Rafael J. Wysocki
2007-02-20 1:20 ` 2.6.20-mm2 Rafael J. Wysocki
2007-02-20 6:31 ` 2.6.20-mm2 Andrew Morton
2007-02-20 22:12 ` 2.6.20-mm2 Rafael J. Wysocki
2007-02-18 13:06 ` 2.6.20-mm2: Oops in generic_make_request Laurent Riffard
2007-02-18 17:58 ` Mattia Dongili
2007-02-18 19:49 ` Andrew Morton
2007-02-18 20:05 ` Michal Piotrowski
2007-02-20 13:04 ` [-mm patch] fix locking in __make_request (was Re: 2.6.20-mm2: Oops in generic_make_request) Frederik Deweerdt
2007-02-19 13:34 ` Jens Axboe
2007-02-20 14:29 ` Frederik Deweerdt
2007-02-19 13:52 ` Michal Piotrowski
2007-02-19 14:08 ` Michal Piotrowski
2007-02-20 14:32 ` Frederik Deweerdt
2007-02-18 18:20 ` 2.6.20-mm2 Michal Piotrowski
2007-02-18 23:32 ` 2.6.20-mm2 Rafael J. Wysocki
2007-02-19 0:28 ` 2.6.20-mm2 Andrew Morton
2007-02-19 5:13 ` 2.6.20-mm2 David Brownell
2007-02-20 22:07 ` 2.6.20-mm2 Rafael J. Wysocki
2007-02-22 3:57 ` 2.6.20-mm2 David Brownell
2007-02-22 8:33 ` 2.6.20-mm2 Rafael J. Wysocki
2007-02-22 22:17 ` 2.6.20-mm2 David Brownell
2007-02-23 16:36 ` 2.6.20-mm2 David Brownell
2007-03-04 22:36 ` 2.6.20-mm2 Rafael J. Wysocki
2007-02-19 18:28 ` 2.6.20-mm2 Rafael J. Wysocki
2007-02-18 23:33 ` 2.6.20-mm2: compilation fix Rafael J. Wysocki
2007-02-19 0:29 ` Andrew Morton
2007-02-19 11:33 ` Rafael J. Wysocki
2007-02-20 0:07 ` [-mm patch] fs/9p/vfs_addr.c: make 2 functions static Adrian Bunk
2007-02-20 0:54 ` Eric Van Hensbergen
2007-02-20 0:07 ` [-mm patch] drivers/mmc/Kconfig source drivers/mmc/card/Kconfig Adrian Bunk
2007-02-20 6:45 ` Pierre Ossman
2007-02-20 0:08 ` [-mm patch] drivers/video/sm501fb.c: make 4 functions static Adrian Bunk
2007-02-20 0:08 ` 2.6.20-mm2: BLOCK=n compile error Adrian Bunk
2007-02-20 0:08 ` [-mm patch] UNION_FS must depend on SLAB Adrian Bunk
2007-02-20 6:37 ` Pekka Enberg
2007-02-20 15:13 ` Josef Sipek
2007-02-21 3:07 ` hooanon05 [this message]
2007-02-21 22:19 ` Andrew Morton
2007-02-22 2:00 ` Josef Sipek
2007-02-22 2:26 ` Andrew Morton
2007-02-22 3:10 ` Josef Sipek
2007-02-22 6:17 ` Pekka Enberg
2007-02-22 6:18 ` Pekka Enberg
2007-02-22 6:28 ` Josef Sipek
2007-02-22 6:42 ` Christoph Lameter
2007-02-22 2:33 ` [Unionfs] " Erez Zadok
2007-02-21 5:19 ` Josef Sipek
2007-02-20 7:39 ` 2.6.20-mm2 KAMEZAWA Hiroyuki
2007-02-20 10:06 ` 2.6.20-mm2 Andy Whitcroft
2007-02-20 11:14 ` 2.6.20-mm2 Maciej Rutecki
2007-02-20 11:38 ` 2.6.20-mm2 Maciej Rutecki
2007-02-20 21:23 ` 2.6.20-mm2: possible recursive locking detected (reiserfs-related) Rafael J. Wysocki
2007-02-20 22:48 ` Tilman Schmidt
2007-02-21 10:52 ` [-mm patch] MTD_UBI_DEBUG must depend on SYSFS Adrian Bunk
2007-02-21 11:57 ` [-mm patch] i386 mpparse.c: remove an unused variable Adrian Bunk
2007-02-25 13:15 ` 2.6.20-mm2 Jean Delvare
2007-02-27 20:25 ` 2.6.20-mm2 Andrew Morton
2007-02-28 9:07 ` 2.6.20-mm2 Jean Delvare
2007-02-26 22:23 ` [-mm patch] LGUEST must depend on NET Adrian Bunk
2007-02-26 23:42 ` Rusty Russell
2007-03-01 10:48 ` [-mm patch] arch/i386/xen/: possible cleanups Adrian Bunk
2007-03-01 10:53 ` Jeremy Fitzhardinge
2007-03-01 11:55 ` Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1HJhpH-0000fR-4w@jroun \
--to=hooanon05@yahoo.co.jp \
--cc=akpm@linux-foundation.org \
--cc=bunk@stusta.de \
--cc=jsipek@fsl.cs.sunysb.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=penberg@cs.helsinki.fi \
--cc=unionfs@filesystems.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox