From: Al Viro <viro@ftp.linux.org.uk>
To: torvalds@linux-foundation.org
Cc: linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org
Subject: [PATCH 13/13] fix ps3fb glue allowing a modular build
Date: Wed, 14 Mar 2007 09:17:04 +0000 [thread overview]
Message-ID: <E1HRPbU-0003Ha-Oq@ZenIV.linux.org.uk> (raw)
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
---
arch/powerpc/platforms/ps3/htab.c | 2 ++
drivers/video/Kconfig | 2 +-
include/asm-powerpc/ps3fb.h | 5 -----
3 files changed, 3 insertions(+), 6 deletions(-)
diff --git a/arch/powerpc/platforms/ps3/htab.c b/arch/powerpc/platforms/ps3/htab.c
index e12e59f..67d6f58 100644
--- a/arch/powerpc/platforms/ps3/htab.c
+++ b/arch/powerpc/platforms/ps3/htab.c
@@ -235,7 +235,9 @@ static void ps3_hpte_invalidate(unsigned long slot, unsigned long va,
static void ps3_hpte_clear(void)
{
/* Make sure to clean up the frame buffer device first */
+#ifdef CONFIG_PS3_FB
ps3fb_cleanup();
+#endif
lv1_unmap_htab(htab_addr);
}
diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig
index 7f5a598..ab43a32 100644
--- a/drivers/video/Kconfig
+++ b/drivers/video/Kconfig
@@ -1615,7 +1615,7 @@ config FB_IBM_GXT4500
adaptor, found on some IBM System P (pSeries) machines.
config FB_PS3
- bool "PS3 GPU framebuffer driver"
+ tristate "PS3 GPU framebuffer driver"
depends on FB && PS3_PS3AV
select FB_CFB_FILLRECT
select FB_CFB_COPYAREA
diff --git a/include/asm-powerpc/ps3fb.h b/include/asm-powerpc/ps3fb.h
index ad81cf4..a447387 100644
--- a/include/asm-powerpc/ps3fb.h
+++ b/include/asm-powerpc/ps3fb.h
@@ -43,13 +43,8 @@ struct ps3fb_ioctl_res {
#ifdef __KERNEL__
-#ifdef CONFIG_FB_PS3
extern void ps3fb_flip_ctl(int on);
extern void ps3fb_cleanup(void);
-#else
-static inline void ps3fb_flip_ctl(int on) {}
-static inline void ps3fb_cleanup(void) {}
-#endif
#endif /* __KERNEL__ */
--
1.5.0-rc2.GIT
next reply other threads:[~2007-03-14 9:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-14 9:17 Al Viro [this message]
2007-03-14 9:50 ` [PATCH 13/13] fix ps3fb glue allowing a modular build Geert Uytterhoeven
2007-03-14 16:02 ` Al Viro
2007-03-14 16:17 ` Geert Uytterhoeven
2007-03-14 17:07 ` Al Viro
2007-03-14 17:23 ` Geert Uytterhoeven
2007-03-14 17:30 ` Linus Torvalds
2007-03-14 17:45 ` Geert Uytterhoeven
2007-03-14 17:59 ` Al Viro
2007-03-14 18:09 ` Geert Uytterhoeven
2007-03-14 18:25 ` Al Viro
2007-03-20 21:06 ` kconfig `bool' (was: Re: [PATCH 13/13] fix ps3fb glue allowing a modular build) Geert Uytterhoeven
2007-03-20 21:16 ` Jan Engelhardt
2007-03-21 11:59 ` Roman Zippel
2007-03-15 1:17 ` [PATCH 13/13] fix ps3fb glue allowing a modular build Antonino A. Daplas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1HRPbU-0003Ha-Oq@ZenIV.linux.org.uk \
--to=viro@ftp.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox