* [PATCH 4/5] mn10300: get rid of set_fs(USER_DS) in sigframe setup
@ 2010-09-26 18:29 Al Viro
0 siblings, 0 replies; 2+ messages in thread
From: Al Viro @ 2010-09-26 18:29 UTC (permalink / raw)
To: linux-kernel; +Cc: dhowells, torvalds
It really has no business being there; short of a serious kernel bug
we should already have USER_DS at that point. It shouldn't have been
done on x86 either...
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
---
arch/mn10300/kernel/signal.c | 4 ----
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/arch/mn10300/kernel/signal.c b/arch/mn10300/kernel/signal.c
index 5a2c004..ae36480 100644
--- a/arch/mn10300/kernel/signal.c
+++ b/arch/mn10300/kernel/signal.c
@@ -333,8 +333,6 @@ static int setup_frame(int sig, struct k_sigaction *ka, sigset_t *set,
regs->d0 = sig;
regs->d1 = (unsigned long) &frame->sc;
- set_fs(USER_DS);
-
/* the tracer may want to single-step inside the handler */
if (test_thread_flag(TIF_SINGLESTEP))
ptrace_notify(SIGTRAP);
@@ -416,8 +414,6 @@ static int setup_rt_frame(int sig, struct k_sigaction *ka, siginfo_t *info,
regs->d0 = sig;
regs->d1 = (long) &frame->info;
- set_fs(USER_DS);
-
/* the tracer may want to single-step inside the handler */
if (test_thread_flag(TIF_SINGLESTEP))
ptrace_notify(SIGTRAP);
--
1.5.6.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH 4/5] mn10300: Get rid of set_fs(USER_DS) in sigframe setup
2010-09-27 10:47 [PATCH 1/5] mn10300: Avoid SIGSEGV delivery loop David Howells
@ 2010-09-27 10:48 ` David Howells
0 siblings, 0 replies; 2+ messages in thread
From: David Howells @ 2010-09-27 10:48 UTC (permalink / raw)
To: torvalds, akpm; +Cc: linux-am33-list, linux-kernel, Al Viro, David Howells
From: Al Viro <viro@ftp.linux.org.uk>
The set_fs(USER_DS) in the signal frame setup code really has no business
being there; short of a serious kernel bug we should already have USER_DS at
that point. It shouldn't have been done on x86 either...
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David Howells <dhowells@redhat.com>
---
arch/mn10300/kernel/signal.c | 4 ----
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/arch/mn10300/kernel/signal.c b/arch/mn10300/kernel/signal.c
index 5a2c004..ae36480 100644
--- a/arch/mn10300/kernel/signal.c
+++ b/arch/mn10300/kernel/signal.c
@@ -333,8 +333,6 @@ static int setup_frame(int sig, struct k_sigaction *ka, sigset_t *set,
regs->d0 = sig;
regs->d1 = (unsigned long) &frame->sc;
- set_fs(USER_DS);
-
/* the tracer may want to single-step inside the handler */
if (test_thread_flag(TIF_SINGLESTEP))
ptrace_notify(SIGTRAP);
@@ -416,8 +414,6 @@ static int setup_rt_frame(int sig, struct k_sigaction *ka, siginfo_t *info,
regs->d0 = sig;
regs->d1 = (long) &frame->info;
- set_fs(USER_DS);
-
/* the tracer may want to single-step inside the handler */
if (test_thread_flag(TIF_SINGLESTEP))
ptrace_notify(SIGTRAP);
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-09-27 10:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-09-26 18:29 [PATCH 4/5] mn10300: get rid of set_fs(USER_DS) in sigframe setup Al Viro
-- strict thread matches above, loose matches on Subject: below --
2010-09-27 10:47 [PATCH 1/5] mn10300: Avoid SIGSEGV delivery loop David Howells
2010-09-27 10:48 ` [PATCH 4/5] mn10300: Get rid of set_fs(USER_DS) in sigframe setup David Howells
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox