Re: Applied "mfd: tps65218: add version check to the PMIC probe" to the regulator tree

Lee Jones
2016-09-01T14:52:08Z

On Thu, 01 Sep 2016, Russell King - ARM Linux wrote:

> On Thu, Sep 01, 2016 at 12:19:18PM +0100, Lee Jones wrote:
> > On Thu, 01 Sep 2016, Russell King - ARM Linux wrote:
> >
> > > On Thu, Sep 01, 2016 at 09:18:34AM +0100, Lee Jones wrote:
> > > > On Wed, 31 Aug 2016, Russell King - ARM Linux wrote:
> > > >
> > > > > On Wed, Aug 31, 2016 at 09:31:14AM +0100, Lee Jones wrote:
> > > > > > On Wed, 10 Aug 2016, Mark Brown wrote:
> > > > > >
> > > > > > > The patch
> > > > > > >
> > > > > > > mfd: tps65218: add version check to the PMIC probe
> > > > > >
> > > > > > Why did you take this patch?
> > > > >
> > > > > I think folk need to start to understand the purpose of the To: and Cc:
> > > > > lines in emails.
> > > > >
> > > > > To: means you're sending the message _to_ the recipient, expecting them
> > > > > to be the _primary_ receiver of the message, and to _process_ the message
> > > > > in some way. In the case of a patch, that may be applying the change.
> > > > >
> > > > > Cc: means you're providing the recipient with a copy of the message, "for
> > > > > their information" and you're not expecting them to take action.
> > > > >
> > > > > If you think that there's no difference between To: and Cc: then ask
> > > > > yourself this question: what's the point of having the two headers,
> > > > > why not list all recipients under one single header.
> > > > >
> > > > > Mark was in the To: line, therefore it is perfectly reasonable for him
> > > > > to apply the patch when it gets acked, since the original author sent
> > > > > it _TO_ Mark implicitly asking him to apply it.
> > > > >
> > > > > If you have a problem with that, then you need to say something in
> > > > > reply to the patch, or you need to instruct folk who send patches for
> > > > > bits of your subsystem not to place others in the To: field who may
> > > > > pick up the patch.
> > > >
> > > > It's not up to submitters which repo patches get applied to. They are
> > > > free to make a verbal (written) request and if it's justified then we
> > > > can choose to agree to it or not.
> > >
> > > Wrong. It's up to submitters to send TO the person who they want to
> > > apply the patch - that's how it's always worked.
> > >
> > > What's become broken is this idea of "I absolutely own this area of the
> > > kernel, all patches _must_ come through me." That's never been the case.
> > >
> > > There may be a good reason why the submitter doesn't want the normal
> > > maintainer of an area of the kernel to take the patch, in which case
> > > the submitter has every right to decide who should take their patch.
> > > The wrong maintainer taking the patch can screw up the submitters
> > > workflow, cause additional conflicts, or break dependencies. The
> > > submitter is the best person to decide who should apply their change.
> >
> > I agree that the submitter is the best person to provide a compelling
> > case to re-route a patch's normal submission path. I disagree that
> > they have the final say.
>
> I'm *not* saying that they have the final say - that's completely _your_
> invention. They are making the request, and people can still ignore,
> refuse, or reply saying that they don't want to take it - all of those
> are valid actions of someone listed in the To: header.

Okay, we are in agreement then. :)

> However, you
> should not be surprised if a person listed in the To: header does action
> the merge if they think that's the reasonable thing for them to do.

I would never take a patch from another subsystem without permission
from its Maintainer. And I would/do get pretty shirty when others do
the same to me. It's not a terrestrial thing. If we transcended into
a free-for-all, or to a lesser extent, patches touching the same file
are routed into multiple repos, then we run the risk of conflict at
merge time. Hence why I go to all that effort to provide pull-
requests to immutable branches when I do so.

> > > If people want me to take some action with their message, they had
> > > better put me in the To: line and _not_ the Cc, otherwise they're
> > > risking me ignoring them for a long time.
> >
> > I'm not sure many people work like that, sending or receiving. In my
> > case I deal with every mail I receive, firstly by brain grepping --
> > skimming over the subject headers for mails I consider urgent.
> > Everything else gets marked as 'important' and is dealt with
> > chronologically. No where in my workflow to do filter by, or consider
> > To: and Cc: fields. That just sounds like too much effort.
>
> My mutt is normally set with "~p | ~P" so I don't even see any message
> that I'm not expicitly listed in the To or Cc anymore - that's because
> if I don't do that, due to the number of emails I get, I can't track
> _anything_. That was highlighted by a security bug that came up earlier
> this year that got totally buried in my mailbox and completely forgotten.
> Since then, I've decided that it's just impossible for me to do anything
> but filter away every mail that I'm not explicitly in those headers.

Apologies for misleading you a little. I too do that. I have lots of
filters which only place *relevant* mails in my 'Personal' folder,
which is the only mail folder I operate on. All filters are
duplicated though -- again I do not differentiate between To: and Cc:
headers.

> I asked Linus how he deals with his mail, and he's the same: he may be
> subscribed to several mailing lists, but he doesn't _read_ any email
> that he's not listed in the To or Cc fields, and even then he tries to
> get rid of it as quickly as possible.

Yeah, likewise.

> So, I'm doing kind of what Linus does to cope with his mail stream: if
> you want me to read your message, you have to put me in the headers,
> otherwise be prepared for me to ignore your message for a very long
> time (possibly never read it.) And as I've said, wanting me to do
> something needs me in the To: header because I'll look at those with
> a higher priority. Mutt makes that nice and easy, giving a T (for
> To), C (for Cc), and a + for personal messages in the index.

I didn't know know about those bindings, but as I say, I probably
wouldn't use them anyway. Do you seriously/actually use them? Even
knowing full well that contributors do not use them as you expect?

> But... my point still stands. This is how To and Cc have worked
> universally, even before email. There's plenty of articles on the net
> describing the correct use of To, Cc, and Bcc, most of which back up my
> point. It's a basic English writing skill and it was important when
> sending memos around a company to get it right. Thankfully, memos
> didn't need to be threaded unlike emails today. However, the same
> point _does_ still exist. It's down to pure laziness that this is not
> followed as it should be, and it's not surprising that things go wrong
> as a result.

I think there is certainly a place for To: and Cc:, but it is my
*personal* (I'm not trying to preach to anyone) that they are a) not
used as perhaps they should be and b) due to (a) not much use, thus I
ignore them.

And yes, I agree, it's due to laziness/lack of time/the fact that they
are pretty pointless in an ML setting that the difference between To:
and Cc: are not seen as important enough to be handled differently.

> So, keep making unreasonable expectations of others and writing poor
> emails if you like, just don't expect the outcome you wish every time,
> as illustrated by what happened earlier in this thread!

Not quite sure how we arrived at this point, but it is my belief that
this misunderstanding didn't have anything to do with mail headers.
Mark and I resolved the real issue in another part of the thread.

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog